Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-08 Thread Luca Fancellu
> On 2 May 2024, at 19:35, Stefano Stabellini wrote: > > On Tue, 30 Apr 2024, Luca Fancellu wrote: >> Commit 2209c1e35b47 ("xen/arm: Introduce a generic way to access memory >> bank structures") introduced a MISRA regression for Rule 1.1 because a >> flexible array member is introduced in the

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Luca Fancellu wrote: > Commit 2209c1e35b47 ("xen/arm: Introduce a generic way to access memory > bank structures") introduced a MISRA regression for Rule 1.1 because a > flexible array member is introduced in the middle of a struct, furthermore > this is using a GCC extension

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Luca Fancellu
> On 2 May 2024, at 11:30, Jan Beulich wrote: > > On 02.05.2024 12:12, Luca Fancellu wrote: In any case it would be used soon also for other architectures using bootinfo. >>> >>> Oh, would it? >> >> PPC people have plans on putting that interface in common: > > I'm aware, but

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Jan Beulich
On 02.05.2024 12:12, Luca Fancellu wrote: >>> In any case it would be used soon also for other architectures using >>> bootinfo. >> >> Oh, would it? > > PPC people have plans on putting that interface in common: I'm aware, but ... >

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Luca Fancellu
> >> In any case it would be used soon also for other architectures using >> bootinfo. > > Oh, would it? PPC people have plans on putting that interface in common:

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Jan Beulich
On 02.05.2024 10:13, Luca Fancellu wrote: > > >> On 2 May 2024, at 07:43, Jan Beulich wrote: >> >> On 02.05.2024 08:33, Luca Fancellu wrote: >>> >>> On 2 May 2024, at 07:14, Jan Beulich wrote: On 01.05.2024 08:57, Luca Fancellu wrote: > Hi Jan, > >> On 30 Apr 2024,

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Luca Fancellu
> On 2 May 2024, at 07:43, Jan Beulich wrote: > > On 02.05.2024 08:33, Luca Fancellu wrote: >> >> >>> On 2 May 2024, at 07:14, Jan Beulich wrote: >>> >>> On 01.05.2024 08:57, Luca Fancellu wrote: Hi Jan, > On 30 Apr 2024, at 12:37, Jan Beulich wrote: > > On

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Jan Beulich
On 02.05.2024 08:33, Luca Fancellu wrote: > > >> On 2 May 2024, at 07:14, Jan Beulich wrote: >> >> On 01.05.2024 08:57, Luca Fancellu wrote: >>> Hi Jan, >>> On 30 Apr 2024, at 12:37, Jan Beulich wrote: On 30.04.2024 13:09, Luca Fancellu wrote: > ---

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Luca Fancellu
> On 2 May 2024, at 07:14, Jan Beulich wrote: > > On 01.05.2024 08:57, Luca Fancellu wrote: >> Hi Jan, >> >>> On 30 Apr 2024, at 12:37, Jan Beulich wrote: >>> >>> On 30.04.2024 13:09, Luca Fancellu wrote: --- a/xen/arch/arm/include/asm/setup.h +++

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-02 Thread Jan Beulich
On 01.05.2024 08:57, Luca Fancellu wrote: > Hi Jan, > >> On 30 Apr 2024, at 12:37, Jan Beulich wrote: >> >> On 30.04.2024 13:09, Luca Fancellu wrote: >>> --- a/xen/arch/arm/include/asm/setup.h >>> +++ b/xen/arch/arm/include/asm/setup.h >>> @@ -64,18 +64,20 @@ struct membank { >>> }; >>> >>>

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-01 Thread Luca Fancellu
Hi Jan, > On 30 Apr 2024, at 12:37, Jan Beulich wrote: > > On 30.04.2024 13:09, Luca Fancellu wrote: >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -64,18 +64,20 @@ struct membank { >> }; >> >> struct membanks { >> -unsigned int nr_banks; >> -

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-04-30 Thread Nicola Vetrini
On 2024-04-30 13:09, Luca Fancellu wrote: Commit 2209c1e35b47 ("xen/arm: Introduce a generic way to access memory bank structures") introduced a MISRA regression for Rule 1.1 because a flexible array member is introduced in the middle of a struct, furthermore this is using a GCC extension that

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-04-30 Thread Jan Beulich
On 30.04.2024 13:09, Luca Fancellu wrote: > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -64,18 +64,20 @@ struct membank { > }; > > struct membanks { > -unsigned int nr_banks; > -unsigned int max_banks; > +__struct_group(membanks_hdr, common,

[PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-04-30 Thread Luca Fancellu
Commit 2209c1e35b47 ("xen/arm: Introduce a generic way to access memory bank structures") introduced a MISRA regression for Rule 1.1 because a flexible array member is introduced in the middle of a struct, furthermore this is using a GCC extension that is going to be deprecated in GCC 14 and a