Re: [PATCH 3/3] x86/entry: Make intra-funciton symbols properly local

2024-01-24 Thread Roger Pau Monné
On Mon, Jan 22, 2024 at 06:17:14PM +, Andrew Cooper wrote: > Each of these symbols are local to their main function. By not having them > globally visible, livepatch's binary diffing logic can reason about the > functions properly. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich >

Re: [PATCH 3/3] x86/entry: Make intra-funciton symbols properly local

2024-01-23 Thread Jan Beulich
On 22.01.2024 19:17, Andrew Cooper wrote: > Each of these symbols are local to their main function. By not having them > globally visible, livepatch's binary diffing logic can reason about the > functions properly. I'm not happy with this, and not only because of the way you're putting things:

[PATCH 3/3] x86/entry: Make intra-funciton symbols properly local

2024-01-22 Thread Andrew Cooper
Each of these symbols are local to their main function. By not having them globally visible, livepatch's binary diffing logic can reason about the functions properly. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Konrad Rzeszutek Wilk CC: Ross