Re: [PATCH 3/3] x86/livepatch: Relax permissions on rodata too

2024-03-07 Thread Ross Lagerwall
On Tue, Mar 5, 2024 at 1:02 PM Andrew Cooper wrote: > > On 05/03/2024 12:11 pm, Andrew Cooper wrote: > > diff --git a/xen/common/virtual_region.c b/xen/common/virtual_region.c > > index d2efe9e11492..f45812483b8e 100644 > > --- a/xen/common/virtual_region.c > > +++ b/xen/common/virtual_region.c >

Re: [PATCH 3/3] x86/livepatch: Relax permissions on rodata too

2024-03-05 Thread Roger Pau Monné
On Tue, Mar 05, 2024 at 01:02:37PM +, Andrew Cooper wrote: > On 05/03/2024 12:11 pm, Andrew Cooper wrote: > > diff --git a/xen/common/virtual_region.c b/xen/common/virtual_region.c > > index d2efe9e11492..f45812483b8e 100644 > > --- a/xen/common/virtual_region.c > > +++

Re: [PATCH 3/3] x86/livepatch: Relax permissions on rodata too

2024-03-05 Thread Andrew Cooper
On 05/03/2024 12:11 pm, Andrew Cooper wrote: > diff --git a/xen/common/virtual_region.c b/xen/common/virtual_region.c > index d2efe9e11492..f45812483b8e 100644 > --- a/xen/common/virtual_region.c > +++ b/xen/common/virtual_region.c > @@ -91,9 +91,15 @@ void relax_virtual_region_perms(void) > >

[PATCH 3/3] x86/livepatch: Relax permissions on rodata too

2024-03-05 Thread Andrew Cooper
This reinstates the capability to patch .rodata in load/unload hooks, which was lost when we stopped using CR0.WP=0 to patch. This turns out to be rather less of a large TODO than I thought at the time. Fixes: 8676092a0f16 ("x86/livepatch: Fix livepatch application when CET is active")