Re: [PATCH 6/7] xen/trace: Update final {__,}trace_var() users to the new API

2024-03-20 Thread George Dunlap
On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper wrote: > > This logically drops the cycles parameter, as it's now encoded directly in the > event code. So to make Jan's comment more specific, what about something like this: This primarily consists of converting the cycles parameter into the

Re: [PATCH 6/7] xen/trace: Update final {__,}trace_var() users to the new API

2024-03-20 Thread Jan Beulich
On 18.03.2024 17:35, Andrew Cooper wrote: > This logically drops the cycles parameter, as it's now encoded directly in the > event code. That encoding is an internal detail of the new API; for the purposes of the callers the pattern looks to be that ... > --- a/xen/arch/x86/hvm/emulate.c > +++

[PATCH 6/7] xen/trace: Update final {__,}trace_var() users to the new API

2024-03-18 Thread Andrew Cooper
This logically drops the cycles parameter, as it's now encoded directly in the event code. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: George Dunlap CC: Stefano Stabellini CC: Julien Grall CC: Nicola Vetrini CC: consult...@bugseng.com