Re: [PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-18 Thread Andrei Semenov
Thank you Jan for your feedback. From what I understood, Andrew is planning some "ground" changes on CPUID leaf discovery, so it probably will move here.  I'll wait for his changes to apply your and Andrew's remarks and to re-post the patches. Andrei. On 4/18/24 10:13, Jan Beulich wrote: On

Re: [PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-18 Thread Jan Beulich
On 10.04.2024 17:36, Andrei Semenov wrote: > Signed-off-by: Andrei Semenov A couple more nits on top of what Andrew said. First: Please no patches (which aren't blindingly trivial) without description. > @@ -1030,6 +1031,54 @@ static void amd_check_erratum_1485(void) >

Re: [PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-12 Thread Vaishali Thakkar
On 4/12/24 5:07 PM, Andrew Cooper wrote: On 12/04/2024 3:38 pm, Vaishali Thakkar wrote: On 4/12/24 4:06 PM, Andrei Semenov wrote: On 4/11/24 20:32, Andrew Cooper wrote: On 10/04/2024 4:36 pm, Andrei Semenov wrote: +    } + +    if (!(cpu_has_sme || cpu_has_sev)) +    return; + +    if

Re: [PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-12 Thread Andrew Cooper
On 12/04/2024 3:38 pm, Vaishali Thakkar wrote: > On 4/12/24 4:06 PM, Andrei Semenov wrote: >> On 4/11/24 20:32, Andrew Cooper wrote: >>> On 10/04/2024 4:36 pm, Andrei Semenov wrote: +    } + +    if (!(cpu_has_sme || cpu_has_sev)) +    return; + +    if

Re: [PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-12 Thread Vaishali Thakkar
On 4/12/24 4:06 PM, Andrei Semenov wrote: On 4/11/24 20:32, Andrew Cooper wrote: On 10/04/2024 4:36 pm, Andrei Semenov wrote: diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index ab92333673..a5903613f0 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -1030,6

Re: [PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-12 Thread Andrei Semenov
On 4/11/24 20:32, Andrew Cooper wrote: On 10/04/2024 4:36 pm, Andrei Semenov wrote: diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index ab92333673..a5903613f0 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -1030,6 +1031,54 @@ static void

Re: [PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-11 Thread Andrew Cooper
On 10/04/2024 4:36 pm, Andrei Semenov wrote: > diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c > index ab92333673..a5903613f0 100644 > --- a/xen/arch/x86/cpu/amd.c > +++ b/xen/arch/x86/cpu/amd.c > @@ -1030,6 +1031,54 @@ static void amd_check_erratum_1485(void) >

[PATCH v1 1/2] Implemented AMD SEV discovery and enabling.

2024-04-10 Thread Andrei Semenov
Signed-off-by: Andrei Semenov --- xen/arch/x86/cpu/amd.c | 53 ++ xen/arch/x86/hvm/svm/Makefile | 1 + xen/arch/x86/hvm/svm/sev.c | 4 ++ xen/arch/x86/include/asm/cpufeature.h | 3 ++ xen/arch/x86/include/asm/cpufeatures.h | 2 +