Re: [PATCH v1 5/7] tools/ocaml: fix compiler warnings

2022-08-03 Thread Christian Lindig
On 3 Aug 2022, at 11:39, Andrew Cooper mailto:andrew.coop...@citrix.com>> wrote: There are no side effects here. Can't the line simply be deleted? Yes. The compiler tells us about unused bindings like these and this is the easy way to acknowledge this without removing the code but it could

[PATCH v1 5/7] tools/ocaml: fix compiler warnings

2022-07-29 Thread Edwin Török
Fix compiler warning about: * unused value * ambiguous documentation comment * non-principal type inference (compiler version dependent) No functional change. Signed-off-by: Edwin Török --- tools/ocaml/xenstored/connection.ml | 2 +- tools/ocaml/xenstored/process.ml| 5 +++-- 2 files