Re: [PATCH v4 08/12] xen/spinlock: add another function level

2024-02-29 Thread Jan Beulich
On 12.12.2023 10:47, Juergen Gross wrote: > @@ -377,25 +388,25 @@ void _spin_unlock_irqrestore(spinlock_t *lock, unsigned > long flags) > local_irq_restore(flags); > } > > +static int always_inline spin_is_locked_common(const spinlock_tickets_t *t) > +{ > +return t->head != t->tail; >

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-13 Thread Jan Beulich
On 13.12.2023 10:55, Juergen Gross wrote: > On 13.12.23 10:48, Julien Grall wrote: >> I note this was a preference and weight against code duplication. It is not >> clear to me whether Jan agrees with this extra work now. >> >> Anyway, I am not against this approach and if this is what Jan much

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-13 Thread Jan Beulich
On 13.12.2023 10:48, Julien Grall wrote: > On 13/12/2023 09:17, Juergen Gross wrote: >> On 13.12.23 09:43, Julien Grall wrote: >>> On 13/12/2023 06:23, Juergen Gross wrote: On 12.12.23 20:10, Julien Grall wrote: > On 12/12/2023 09:47, Juergen Gross wrote: >> Add another function level

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-13 Thread Juergen Gross
On 13.12.23 10:48, Julien Grall wrote: On 13/12/2023 09:17, Juergen Gross wrote: On 13.12.23 09:43, Julien Grall wrote: Hi Juergen, On 13/12/2023 06:23, Juergen Gross wrote: On 12.12.23 20:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-13 Thread Julien Grall
On 13/12/2023 09:17, Juergen Gross wrote: On 13.12.23 09:43, Julien Grall wrote: Hi Juergen, On 13/12/2023 06:23, Juergen Gross wrote: On 12.12.23 20:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function level in spinlock.c hiding the

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-13 Thread Juergen Gross
On 13.12.23 09:43, Julien Grall wrote: Hi Juergen, On 13/12/2023 06:23, Juergen Gross wrote: On 12.12.23 20:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code.

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-13 Thread Julien Grall
Hi Juergen, On 13/12/2023 06:23, Juergen Gross wrote: On 12.12.23 20:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-12 Thread Juergen Gross
On 12.12.23 20:10, Julien Grall wrote: Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to

Re: [PATCH v4 08/12] xen/spinlock: add another function level

2023-12-12 Thread Julien Grall
Hi Juergen, On 12/12/2023 09:47, Juergen Gross wrote: Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to duplicate all of the locking code. So all

[PATCH v4 08/12] xen/spinlock: add another function level

2023-12-12 Thread Juergen Gross
Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to duplicate all of the locking code. Signed-off-by: Juergen Gross --- V2: - new patch ---