Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-14 Thread Bertrand Marquis
Hi, > On 14 Oct 2021, at 07:23, Jan Beulich wrote: > > On 13.10.2021 22:41, Stefano Stabellini wrote: >> On Wed, 13 Oct 2021, Jan Beulich wrote: >>> On 13.10.2021 14:11, Bertrand Marquis wrote: > On 13 Oct 2021, at 11:56, Roger Pau Monné wrote: > If vPCI for Arm on 4.16 is not going to

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-14 Thread Jan Beulich
On 13.10.2021 22:41, Stefano Stabellini wrote: > On Wed, 13 Oct 2021, Jan Beulich wrote: >> On 13.10.2021 14:11, Bertrand Marquis wrote: On 13 Oct 2021, at 11:56, Roger Pau Monné wrote: If vPCI for Arm on 4.16 is not going to be functional, why so much pressure in pushing those

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Stefano Stabellini
On Wed, 13 Oct 2021, Stefano Stabellini wrote: > On Wed, 13 Oct 2021, Roger Pau Monné wrote: > > > I think the second solution is the right one but it cannot be done so > > > near from the > > > feature freeze. > > > > > > The CDF flag as introduced right now is not creating any issue and will

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Stefano Stabellini
On Wed, 13 Oct 2021, Roger Pau Monné wrote: > > I think the second solution is the right one but it cannot be done so near > > from the > > feature freeze. > > > > The CDF flag as introduced right now is not creating any issue and will be > > used once > > the emulation flag will be introduce.

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Stefano Stabellini
On Wed, 13 Oct 2021, Jan Beulich wrote: > On 13.10.2021 14:11, Bertrand Marquis wrote: > >> On 13 Oct 2021, at 11:56, Roger Pau Monné wrote: > >> If vPCI for Arm on 4.16 is not going to be functional, why so much > >> pressure in pushing those patches so fast? I understand the need to > >> remove

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Roger Pau Monné
On Wed, Oct 13, 2021 at 12:11:30PM +, Bertrand Marquis wrote: > Hi Roger, > > > On 13 Oct 2021, at 11:56, Roger Pau Monné wrote: > > > > On Wed, Oct 13, 2021 at 09:36:01AM +, Bertrand Marquis wrote: > >> Hi Roger, > >> > >>> On 13 Oct 2021, at 09:30, Roger Pau Monné wrote: > >>> >

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Jan Beulich
On 13.10.2021 14:11, Bertrand Marquis wrote: >> On 13 Oct 2021, at 11:56, Roger Pau Monné wrote: >> If vPCI for Arm on 4.16 is not going to be functional, why so much >> pressure in pushing those patches so fast? I understand the need to >> remove stuff from the queue, but I don't think it's

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Bertrand Marquis
Hi Roger, > On 13 Oct 2021, at 11:56, Roger Pau Monné wrote: > > On Wed, Oct 13, 2021 at 09:36:01AM +, Bertrand Marquis wrote: >> Hi Roger, >> >>> On 13 Oct 2021, at 09:30, Roger Pau Monné wrote: >>> >>> On Tue, Oct 12, 2021 at 12:38:35PM +0200, Michal Orzel wrote: Hi Roger,

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Roger Pau Monné
On Wed, Oct 13, 2021 at 09:36:01AM +, Bertrand Marquis wrote: > Hi Roger, > > > On 13 Oct 2021, at 09:30, Roger Pau Monné wrote: > > > > On Tue, Oct 12, 2021 at 12:38:35PM +0200, Michal Orzel wrote: > >> Hi Roger, > >> > >> On 11.10.2021 11:27, Roger Pau Monné wrote: > >>> On Wed, Oct 06,

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Bertrand Marquis
Hi Roger, > On 13 Oct 2021, at 09:30, Roger Pau Monné wrote: > > On Tue, Oct 12, 2021 at 12:38:35PM +0200, Michal Orzel wrote: >> Hi Roger, >> >> On 11.10.2021 11:27, Roger Pau Monné wrote: >>> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: Introduce XEN_DOMCTL_CDF_vpci flag

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Roger Pau Monné
On Tue, Oct 12, 2021 at 12:38:35PM +0200, Michal Orzel wrote: > Hi Roger, > > On 11.10.2021 11:27, Roger Pau Monné wrote: > > On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: > >> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > >> Reject the use of this new flag

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Michal Orzel
On 13.10.2021 08:18, Jan Beulich wrote: > On 12.10.2021 23:48, Stefano Stabellini wrote: >> On Mon, 11 Oct 2021, Roger Pau Monné wrote: >>> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. Reject the use of

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-13 Thread Jan Beulich
On 12.10.2021 23:48, Stefano Stabellini wrote: > On Mon, 11 Oct 2021, Roger Pau Monné wrote: >> On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: >>> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. >>> Reject the use of this new flag for x86 as VPCI is not supported

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-12 Thread Stefano Stabellini
On Mon, 11 Oct 2021, Roger Pau Monné wrote: > On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: > > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > > Reject the use of this new flag for x86 as VPCI is not supported for > > DOMU guests for x86. > > I don't like this

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-12 Thread Michal Orzel
Hi Roger, On 11.10.2021 11:27, Roger Pau Monné wrote: > On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: >> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. >> Reject the use of this new flag for x86 as VPCI is not supported for >> DOMU guests for x86. > > I don't

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 01:35:18PM +0200, Jan Beulich wrote: > On 11.10.2021 13:29, Michal Orzel wrote: > > On 08.10.2021 23:46, Stefano Stabellini wrote: > >> On Fri, 8 Oct 2021, Julien Grall wrote: > >>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, > >>> wrote: > >>> On 06/10/2021 18:40,

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Michal Orzel
Hi Roger, On 11.10.2021 11:27, Roger Pau Monné wrote: > On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: >> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. >> Reject the use of this new flag for x86 as VPCI is not supported for >> DOMU guests for x86. > > I don't

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Jan Beulich
On 11.10.2021 13:29, Michal Orzel wrote: > On 08.10.2021 23:46, Stefano Stabellini wrote: >> On Fri, 8 Oct 2021, Julien Grall wrote: >>> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: >>> On 06/10/2021 18:40, Rahul Singh wrote: >>> > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Michal Orzel
Hi Stefano, On 08.10.2021 23:46, Stefano Stabellini wrote: > On Fri, 8 Oct 2021, Julien Grall wrote: >> Hi Andrew, >> >> On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: >> On 06/10/2021 18:40, Rahul Singh wrote: >> > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"): > Ian, for the 4.16 release, this series either needs completing with the > additional flag implemented, or this patch needs reverting to avoid us > shipping a broken interface

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote: > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > Reject the use of this new flag for x86 as VPCI is not supported for > DOMU guests for x86. I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86 PVH

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-11 Thread Julien Grall
Hi Stefano, On 08/10/2021 22:46, Stefano Stabellini wrote: On Fri, 8 Oct 2021, Julien Grall wrote: Hi Andrew, On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: On 06/10/2021 18:40, Rahul Singh wrote: > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. >

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-08 Thread Stefano Stabellini
On Fri, 8 Oct 2021, Julien Grall wrote: > Hi Andrew, > > On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: > On 06/10/2021 18:40, Rahul Singh wrote: > > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > > Reject the use of this new flag for x86 as VPCI is not

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-08 Thread Julien Grall
Hi Andrew, On Fri, 8 Oct 2021, 20:07 Andrew Cooper, wrote: > On 06/10/2021 18:40, Rahul Singh wrote: > > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > > Reject the use of this new flag for x86 as VPCI is not supported for > > DOMU guests for x86. > > > > Signed-off-by:

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-08 Thread Andrew Cooper
On 06/10/2021 18:40, Rahul Singh wrote: > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > Reject the use of this new flag for x86 as VPCI is not supported for > DOMU guests for x86. > > Signed-off-by: Rahul Singh > Reviewed-by: Stefano Stabellini > Acked-by: Christian Lindig

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -70,9 +70,11 @@ struct xen_domctl_createdomain { > #define XEN_DOMCTL_CDF_iommu (1U<<_XEN_DOMCTL_CDF_iommu) > #define _XEN_DOMCTL_CDF_nested_virt 6 > #define

[PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-06 Thread Rahul Singh
Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. Reject the use of this new flag for x86 as VPCI is not supported for DOMU guests for x86. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Acked-by: Christian Lindig --- Change in v5: - Added Acked-by: Christian Lindig