Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-14 Thread Jan Beulich
On 14.10.2021 11:03, Bertrand Marquis wrote: > Hi Jan, > >> On 14 Oct 2021, at 07:33, Jan Beulich wrote: >> >> On 13.10.2021 21:27, Stefano Stabellini wrote: >>> On Wed, 13 Oct 2021, Jan Beulich wrote: On 13.10.2021 16:51, Oleksandr Andrushchenko wrote: > On 13.10.21 16:00, Jan Beulich

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-14 Thread Bertrand Marquis
Hi Jan, > On 14 Oct 2021, at 07:33, Jan Beulich wrote: > > On 13.10.2021 21:27, Stefano Stabellini wrote: >> On Wed, 13 Oct 2021, Jan Beulich wrote: >>> On 13.10.2021 16:51, Oleksandr Andrushchenko wrote: On 13.10.21 16:00, Jan Beulich wrote: > On 13.10.2021 10:45, Roger Pau Monné

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-14 Thread Bertrand Marquis
Hi, > On 14 Oct 2021, at 07:33, Jan Beulich wrote: > > On 13.10.2021 21:27, Stefano Stabellini wrote: >> On Wed, 13 Oct 2021, Jan Beulich wrote: >>> On 13.10.2021 16:51, Oleksandr Andrushchenko wrote: On 13.10.21 16:00, Jan Beulich wrote: > On 13.10.2021 10:45, Roger Pau Monné wrote:

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-14 Thread Jan Beulich
On 13.10.2021 21:27, Stefano Stabellini wrote: > On Wed, 13 Oct 2021, Jan Beulich wrote: >> On 13.10.2021 16:51, Oleksandr Andrushchenko wrote: >>> On 13.10.21 16:00, Jan Beulich wrote: On 13.10.2021 10:45, Roger Pau Monné wrote: > On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Stefano Stabellini
On Wed, 13 Oct 2021, Jan Beulich wrote: > On 13.10.2021 16:51, Oleksandr Andrushchenko wrote: > > On 13.10.21 16:00, Jan Beulich wrote: > >> On 13.10.2021 10:45, Roger Pau Monné wrote: > >>> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: > --- /dev/null > +++

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Jan Beulich
On 13.10.2021 16:51, Oleksandr Andrushchenko wrote: > On 13.10.21 16:00, Jan Beulich wrote: >> On 13.10.2021 10:45, Roger Pau Monné wrote: >>> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: --- /dev/null +++ b/xen/arch/arm/vpci.c @@ -0,0 +1,102 @@ +/* + *

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Oleksandr Andrushchenko
On 13.10.21 16:00, Jan Beulich wrote: > On 13.10.2021 10:45, Roger Pau Monné wrote: >> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: >>> The existing VPCI support available for X86 is adapted for Arm. >>> When the device is added to XEN via the hyper call >>>

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Jan Beulich
On 13.10.2021 10:45, Roger Pau Monné wrote: > On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: >> The existing VPCI support available for X86 is adapted for Arm. >> When the device is added to XEN via the hyper call >> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space >>

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Jan Beulich
On 13.10.2021 12:02, Bertrand Marquis wrote: >> On 13 Oct 2021, at 07:10, Jan Beulich wrote: >> On 12.10.2021 23:37, Stefano Stabellini wrote: >>> Good point about MSIs not being setup before the traps. We should remove >>> the call to pci_cleanup_msi() in the error path then. >> >> Your reply

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Roger Pau Monné
On Wed, Oct 13, 2021 at 09:48:42AM +, Bertrand Marquis wrote: > Hi Roger, > > > On 13 Oct 2021, at 09:45, Roger Pau Monné wrote: > > > > On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: > >> The existing VPCI support available for X86 is adapted for Arm. > >> When the device is

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Bertrand Marquis
Hi Jan, > On 13 Oct 2021, at 07:10, Jan Beulich wrote: > > On 12.10.2021 23:37, Stefano Stabellini wrote: >> On Tue, 12 Oct 2021, Jan Beulich wrote: >>> On 11.10.2021 20:18, Stefano Stabellini wrote: On Mon, 11 Oct 2021, Jan Beulich wrote: > On 11.10.2021 15:34, Bertrand Marquis wrote:

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Bertrand Marquis
Hi Roger, > On 13 Oct 2021, at 09:45, Roger Pau Monné wrote: > > On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: >> The existing VPCI support available for X86 is adapted for Arm. >> When the device is added to XEN via the hyper call >> “PHYSDEVOP_pci_device_add”, VPCI handler for

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: > The existing VPCI support available for X86 is adapted for Arm. > When the device is added to XEN via the hyper call > “PHYSDEVOP_pci_device_add”, VPCI handler for the config space > access is added to the Xen to emulate the PCI

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-13 Thread Jan Beulich
On 12.10.2021 23:37, Stefano Stabellini wrote: > On Tue, 12 Oct 2021, Jan Beulich wrote: >> On 11.10.2021 20:18, Stefano Stabellini wrote: >>> On Mon, 11 Oct 2021, Jan Beulich wrote: On 11.10.2021 15:34, Bertrand Marquis wrote: >> On 11 Oct 2021, at 14:09, Jan Beulich wrote: >> On

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Stefano Stabellini
On Tue, 12 Oct 2021, Jan Beulich wrote: > On 11.10.2021 20:18, Stefano Stabellini wrote: > > On Mon, 11 Oct 2021, Jan Beulich wrote: > >> On 11.10.2021 15:34, Bertrand Marquis wrote: > On 11 Oct 2021, at 14:09, Jan Beulich wrote: > On 11.10.2021 14:41, Bertrand Marquis wrote: > >

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Bertrand Marquis
Hi Julien, > On 12 Oct 2021, at 17:20, Julien Grall wrote: > > > > On 12/10/2021 17:12, Bertrand Marquis wrote: >> Hi Julien, >>> On 12 Oct 2021, at 16:04, Julien Grall wrote: >>> >>> On 11/10/2021 13:41, Bertrand Marquis wrote: Hi Jan, >>> >>> Hi Bertrand, >>> As Rahul is on

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Julien Grall
On 12/10/2021 17:12, Bertrand Marquis wrote: Hi Julien, On 12 Oct 2021, at 16:04, Julien Grall wrote: On 11/10/2021 13:41, Bertrand Marquis wrote: Hi Jan, Hi Bertrand, As Rahul is on leave, I will answer you and make the changes needed. On 7 Oct 2021, at 14:43, Jan Beulich wrote:

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Bertrand Marquis
Hi Julien, > On 12 Oct 2021, at 16:04, Julien Grall wrote: > > On 11/10/2021 13:41, Bertrand Marquis wrote: >> Hi Jan, > > Hi Bertrand, > >> As Rahul is on leave, I will answer you and make the changes needed. >>> On 7 Oct 2021, at 14:43, Jan Beulich wrote: >>> Independent of this - is bare

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Julien Grall
On 11/10/2021 13:41, Bertrand Marquis wrote: Hi Jan, Hi Bertrand, As Rahul is on leave, I will answer you and make the changes needed. On 7 Oct 2021, at 14:43, Jan Beulich wrote: Independent of this - is bare metal Arm enforcing this same alignment restriction (unconditionally)? Iirc on

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Bertrand Marquis
Hi Julien, > On 12 Oct 2021, at 15:32, Julien Grall wrote: > > Hi Rahul, > > On 06/10/2021 18:40, Rahul Singh wrote: >> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h >> index c9277b5c6d..91d614b37e 100644 >> --- a/xen/include/asm-arm/domain.h >> +++

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Julien Grall
Hi Rahul, On 06/10/2021 18:40, Rahul Singh wrote: diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index c9277b5c6d..91d614b37e 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -2,6 +2,7 @@ #define __ASM_DOMAIN_H__ #include

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Jan Beulich
On 11.10.2021 20:18, Stefano Stabellini wrote: > On Mon, 11 Oct 2021, Jan Beulich wrote: >> On 11.10.2021 15:34, Bertrand Marquis wrote: On 11 Oct 2021, at 14:09, Jan Beulich wrote: On 11.10.2021 14:41, Bertrand Marquis wrote: > But digging deeper into this, I would have 2

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-12 Thread Bertrand Marquis
Hi Stefano, > On 11 Oct 2021, at 20:27, Stefano Stabellini wrote: > > On Mon, 11 Oct 2021, Oleksandr Andrushchenko wrote: >> On 11.10.21 20:15, Bertrand Marquis wrote: >>> Hi Roger, >>> On 11 Oct 2021, at 17:43, Roger Pau Monné wrote: On Mon, Oct 11, 2021 at 04:20:14PM +,

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Oleksandr Andrushchenko
On 11.10.21 22:27, Stefano Stabellini wrote: > On Mon, 11 Oct 2021, Oleksandr Andrushchenko wrote: >> On 11.10.21 20:15, Bertrand Marquis wrote: >>> Hi Roger, >>> On 11 Oct 2021, at 17:43, Roger Pau Monné wrote: On Mon, Oct 11, 2021 at 04:20:14PM +, Oleksandr Andrushchenko

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Stefano Stabellini
On Mon, 11 Oct 2021, Oleksandr Andrushchenko wrote: > On 11.10.21 20:15, Bertrand Marquis wrote: > > Hi Roger, > > > >> On 11 Oct 2021, at 17:43, Roger Pau Monné wrote: > >> > >> On Mon, Oct 11, 2021 at 04:20:14PM +, Oleksandr Andrushchenko wrote: > >>> > >>> On 11.10.21 19:12, Bertrand

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Oleksandr Andrushchenko
On 11.10.21 20:15, Bertrand Marquis wrote: > Hi Roger, > >> On 11 Oct 2021, at 17:43, Roger Pau Monné wrote: >> >> On Mon, Oct 11, 2021 at 04:20:14PM +, Oleksandr Andrushchenko wrote: >>> >>> On 11.10.21 19:12, Bertrand Marquis wrote: Hi Roger, > On 11 Oct 2021, at 11:51,

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Stefano Stabellini
On Mon, 11 Oct 2021, Jan Beulich wrote: > On 11.10.2021 15:34, Bertrand Marquis wrote: > >> On 11 Oct 2021, at 14:09, Jan Beulich wrote: > >> On 11.10.2021 14:41, Bertrand Marquis wrote: > On 7 Oct 2021, at 14:43, Jan Beulich wrote: > On 06.10.2021 19:40, Rahul Singh wrote: > > ---

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 17:43, Roger Pau Monné wrote: > > On Mon, Oct 11, 2021 at 04:20:14PM +, Oleksandr Andrushchenko wrote: >> >> >> On 11.10.21 19:12, Bertrand Marquis wrote: >>> Hi Roger, >>> On 11 Oct 2021, at 11:51, Roger Pau Monné wrote: On Wed, Oct 06,

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 04:20:14PM +, Oleksandr Andrushchenko wrote: > > > On 11.10.21 19:12, Bertrand Marquis wrote: > > Hi Roger, > > > >> On 11 Oct 2021, at 11:51, Roger Pau Monné wrote: > >> > >> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: > >>> The existing VPCI

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Oleksandr Andrushchenko
On 11.10.21 19:12, Bertrand Marquis wrote: > Hi Roger, > >> On 11 Oct 2021, at 11:51, Roger Pau Monné wrote: >> >> On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: >>> The existing VPCI support available for X86 is adapted for Arm. >>> When the device is added to XEN via the hyper

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 11:51, Roger Pau Monné wrote: > > On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: >> The existing VPCI support available for X86 is adapted for Arm. >> When the device is added to XEN via the hyper call >> “PHYSDEVOP_pci_device_add”, VPCI handler for

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Jan, > On 11 Oct 2021, at 15:10, Jan Beulich wrote: > > On 11.10.2021 15:34, Bertrand Marquis wrote: >>> On 11 Oct 2021, at 14:09, Jan Beulich wrote: >>> On 11.10.2021 14:41, Bertrand Marquis wrote: > On 7 Oct 2021, at 14:43, Jan Beulich wrote: > On 06.10.2021 19:40, Rahul Singh

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Jan Beulich
On 11.10.2021 15:34, Bertrand Marquis wrote: >> On 11 Oct 2021, at 14:09, Jan Beulich wrote: >> On 11.10.2021 14:41, Bertrand Marquis wrote: On 7 Oct 2021, at 14:43, Jan Beulich wrote: On 06.10.2021 19:40, Rahul Singh wrote: > --- /dev/null > +++ b/xen/arch/arm/vpci.c > @@

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Jan, > On 11 Oct 2021, at 14:09, Jan Beulich wrote: > > On 11.10.2021 14:41, Bertrand Marquis wrote: >>> On 7 Oct 2021, at 14:43, Jan Beulich wrote: >>> On 06.10.2021 19:40, Rahul Singh wrote: --- /dev/null +++ b/xen/arch/arm/vpci.c @@ -0,0 +1,102 @@ +/* + *

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Jan Beulich
On 11.10.2021 14:41, Bertrand Marquis wrote: >> On 7 Oct 2021, at 14:43, Jan Beulich wrote: >> On 06.10.2021 19:40, Rahul Singh wrote: >>> --- /dev/null >>> +++ b/xen/arch/arm/vpci.c >>> @@ -0,0 +1,102 @@ >>> +/* >>> + * xen/arch/arm/vpci.c >>> + * >>> + * This program is free software; you can

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Bertrand Marquis
Hi Jan, As Rahul is on leave, I will answer you and make the changes needed. > On 7 Oct 2021, at 14:43, Jan Beulich wrote: > > On 06.10.2021 19:40, Rahul Singh wrote: >> --- /dev/null >> +++ b/xen/arch/arm/vpci.c >> @@ -0,0 +1,102 @@ >> +/* >> + * xen/arch/arm/vpci.c >> + * >> + * This program

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-11 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:34PM +0100, Rahul Singh wrote: > The existing VPCI support available for X86 is adapted for Arm. > When the device is added to XEN via the hyper call > “PHYSDEVOP_pci_device_add”, VPCI handler for the config space > access is added to the Xen to emulate the PCI

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-07 Thread Jan Beulich
On 06.10.2021 19:40, Rahul Singh wrote: > --- /dev/null > +++ b/xen/arch/arm/vpci.c > @@ -0,0 +1,102 @@ > +/* > + * xen/arch/arm/vpci.c > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + *

[PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-06 Thread Rahul Singh
The existing VPCI support available for X86 is adapted for Arm. When the device is added to XEN via the hyper call “PHYSDEVOP_pci_device_add”, VPCI handler for the config space access is added to the Xen to emulate the PCI devices config space. A MMIO trap handler for the PCI ECAM space is