On 15.10.2021 11:53, Roger Pau Monné wrote:
> On Fri, Oct 15, 2021 at 07:53:38AM +, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 08:44, Roger Pau Monné wrote:
>>> On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
@@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct
Hi Roger,
> On 15 Oct 2021, at 10:53, Roger Pau Monné wrote:
>
> On Fri, Oct 15, 2021 at 07:53:38AM +, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 08:44, Roger Pau Monné wrote:
>>> On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
@@ -434,25 +420,8 @@ static int
On Fri, Oct 15, 2021 at 07:53:38AM +, Bertrand Marquis wrote:
> > On 15 Oct 2021, at 08:44, Roger Pau Monné wrote:
> > On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
> >> @@ -434,25 +420,8 @@ static int vpci_mmcfg_read(struct vcpu *v, unsigned
> >> long addr,
> >> reg
On Fri, Oct 15, 2021 at 10:13:24AM +0200, Jan Beulich wrote:
> On 15.10.2021 09:37, Bertrand Marquis wrote:
> >> On 15 Oct 2021, at 07:29, Jan Beulich wrote:
> >> On 14.10.2021 19:09, Bertrand Marquis wrote:
> On 14 Oct 2021, at 17:06, Jan Beulich wrote:
> On 14.10.2021 16:49, Bertrand
On 15.10.2021 10:20, Bertrand Marquis wrote:
> Anyway if we agree on naming scheme and bool return type I think all
> your comments here are covered ?
Probably, but I have to admit I've lost track ...
Jan
Hi Jan,
> On 15 Oct 2021, at 09:13, Jan Beulich wrote:
>
> On 15.10.2021 09:37, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 07:29, Jan Beulich wrote:
>>> On 14.10.2021 19:09, Bertrand Marquis wrote:
> On 14 Oct 2021, at 17:06, Jan Beulich wrote:
> On 14.10.2021 16:49, Bertrand
On 15.10.2021 09:37, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 07:29, Jan Beulich wrote:
>> On 14.10.2021 19:09, Bertrand Marquis wrote:
On 14 Oct 2021, at 17:06, Jan Beulich wrote:
On 14.10.2021 16:49, Bertrand Marquis wrote:
> @@ -305,7 +291,7 @@ static int
Hi Roger,
> On 15 Oct 2021, at 08:44, Roger Pau Monné wrote:
>
> On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
>> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
>> Use ECAM/ecam instead of MCFG in common code and in new functions added
>> in common
On Thu, Oct 14, 2021 at 03:49:49PM +0100, Bertrand Marquis wrote:
> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
> Use ECAM/ecam instead of MCFG in common code and in new functions added
> in common vpci code by this patch.
>
> Rename vpci_access_allowed to
Hi Jan,
> On 15 Oct 2021, at 07:29, Jan Beulich wrote:
>
> On 14.10.2021 19:09, Bertrand Marquis wrote:
>>> On 14 Oct 2021, at 17:06, Jan Beulich wrote:
>>> On 14.10.2021 16:49, Bertrand Marquis wrote:
@@ -305,7 +291,7 @@ static int vpci_portio_read(const struct
hvm_io_handler
On 14.10.2021 19:09, Bertrand Marquis wrote:
>> On 14 Oct 2021, at 17:06, Jan Beulich wrote:
>> On 14.10.2021 16:49, Bertrand Marquis wrote:
>>> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler
>>> *handler,
>>>
>>> reg = hvm_pci_decode_addr(cf8, addr, );
>>>
>>> -
On Thu, 14 Oct 2021, Bertrand Marquis wrote:
> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
> Use ECAM/ecam instead of MCFG in common code and in new functions added
> in common vpci code by this patch.
>
> Rename vpci_access_allowed to vpci_ecam_access_allowed and move
Hi Jan,
> On 14 Oct 2021, at 17:06, Jan Beulich wrote:
>
> On 14.10.2021 16:49, Bertrand Marquis wrote:
>> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler
>> *handler,
>>
>> reg = hvm_pci_decode_addr(cf8, addr, );
>>
>> -if ( !vpci_access_allowed(reg,
On 14.10.2021 16:49, Bertrand Marquis wrote:
> @@ -305,7 +291,7 @@ static int vpci_portio_read(const struct hvm_io_handler
> *handler,
>
> reg = hvm_pci_decode_addr(cf8, addr, );
>
> -if ( !vpci_access_allowed(reg, size) )
> +if ( !vpci_ecam_access_allowed(reg, size) )
>
PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
Use ECAM/ecam instead of MCFG in common code and in new functions added
in common vpci code by this patch.
Rename vpci_access_allowed to vpci_ecam_access_allowed and move it
from arch/x86/hvm/io.c to drivers/vpci/vpci.c.
15 matches
Mail list logo