Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Roger Pau Monné
On Fri, Oct 15, 2021 at 03:00:21PM +0100, Luca Fancellu wrote: > > > > On 15 Oct 2021, at 14:47, Roger Pau Monné wrote: > > > > On Fri, Oct 15, 2021 at 10:48:41AM +, Bertrand Marquis wrote: > >> Hi Jan, > >> > >>> On 15 Oct 2021, at 11:41, Jan Beulich wrote: > >>> > >>> On 15.10.2021

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Luca Fancellu
> On 15 Oct 2021, at 14:47, Roger Pau Monné wrote: > > On Fri, Oct 15, 2021 at 10:48:41AM +, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 15 Oct 2021, at 11:41, Jan Beulich wrote: >>> >>> On 15.10.2021 12:33, Bertrand Marquis wrote: > On 15 Oct 2021, at 11:24, Jan Beulich wrote:

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Roger Pau Monné
On Fri, Oct 15, 2021 at 10:48:41AM +, Bertrand Marquis wrote: > Hi Jan, > > > On 15 Oct 2021, at 11:41, Jan Beulich wrote: > > > > On 15.10.2021 12:33, Bertrand Marquis wrote: > >>> On 15 Oct 2021, at 11:24, Jan Beulich wrote: > >>> On 15.10.2021 11:52, Bertrand Marquis wrote: > > On

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
wrote: >>>>> On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote: >>>>>> On 15.10.2021 12:14, Ian Jackson wrote: >>>>>>> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the >>>>>>> existing x86 virt

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
rote: >>>>> On 15.10.2021 12:14, Ian Jackson wrote: >>>>>> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the >>>>>> existing x86 virtual PCI support for ARM."): >>>>>>>> On 15 Oct 2021, at

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
ote: >>>> On 15.10.2021 12:14, Ian Jackson wrote: >>>>> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing >>>>> x86 virtual PCI support for ARM."): >>>>>>> On 15 Oct 2021, at 09:00, Jan Beulich wrote: >>

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 15.10.2021 14:13, Bertrand Marquis wrote: > Hi Roger, > >> On 15 Oct 2021, at 12:35, Roger Pau Monné wrote: >> >> On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote: >>> On 15.10.2021 12:14, Ian Jackson wrote: >>>> Bertrand Marqui

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi Roger, > On 15 Oct 2021, at 12:35, Roger Pau Monné wrote: > > On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote: >> On 15.10.2021 12:14, Ian Jackson wrote: >>> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing >&g

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Roger Pau Monné
On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote: > On 15.10.2021 12:14, Ian Jackson wrote: > > Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing > > x86 virtual PCI support for ARM."): > >>> On 15 Oct 2021, at 09:00, Jan Beu

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi, > On 15 Oct 2021, at 11:51, Jan Beulich wrote: > > On 15.10.2021 12:48, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 15 Oct 2021, at 11:41, Jan Beulich wrote: >>> >>> On 15.10.2021 12:33, Bertrand Marquis wrote: > On 15 Oct 2021, at 11:24, Jan Beulich wrote: > On 15.10.2021

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 15.10.2021 12:48, Bertrand Marquis wrote: > Hi Jan, > >> On 15 Oct 2021, at 11:41, Jan Beulich wrote: >> >> On 15.10.2021 12:33, Bertrand Marquis wrote: On 15 Oct 2021, at 11:24, Jan Beulich wrote: On 15.10.2021 11:52, Bertrand Marquis wrote: >> On 15 Oct 2021, at 09:32, Roger

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi Jan, > On 15 Oct 2021, at 11:41, Jan Beulich wrote: > > On 15.10.2021 12:33, Bertrand Marquis wrote: >>> On 15 Oct 2021, at 11:24, Jan Beulich wrote: >>> On 15.10.2021 11:52, Bertrand Marquis wrote: > On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: > On Thu, Oct 14, 2021 at

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 15.10.2021 12:33, Bertrand Marquis wrote: >> On 15 Oct 2021, at 11:24, Jan Beulich wrote: >> On 15.10.2021 11:52, Bertrand Marquis wrote: On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: > @@ -752,6 +752,19 @@ int

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 15.10.2021 12:09, Bertrand Marquis wrote: >> On 15 Oct 2021, at 09:00, Jan Beulich wrote: >> On 14.10.2021 16:49, Bertrand Marquis wrote: >>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >>> >>> check_pdev(pdev); >>> >>> +#ifdef CONFIG_ARM >>> +/* >>> + * On

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
> On 15 Oct 2021, at 11:24, Jan Beulich wrote: > > On 15.10.2021 11:52, Bertrand Marquis wrote: >>> On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: >>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi, > On 15 Oct 2021, at 11:19, Roger Pau Monné wrote: > > On Fri, Oct 15, 2021 at 09:52:28AM +, Bertrand Marquis wrote: >> Hi Roger, >> >>> On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: >>> >>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: From: Rahul Singh

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 15.10.2021 11:52, Bertrand Marquis wrote: >> On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: >> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: >>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >>> >>> check_pdev(pdev); >>> >>> +#ifdef CONFIG_ARM >>>

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Roger Pau Monné
On Fri, Oct 15, 2021 at 09:52:28AM +, Bertrand Marquis wrote: > Hi Roger, > > > On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: > > > > On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: > >> From: Rahul Singh > >> diff --git a/xen/drivers/passthrough/pci.c

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 15.10.2021 12:14, Ian Jackson wrote: > Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 > virtual PCI support for ARM."): >>> On 15 Oct 2021, at 09:00, Jan Beulich wrote: >>> The latter is fine to be put here (i.e. FTAOD

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi Luca, > On 15 Oct 2021, at 11:13, Luca Fancellu wrote: > > > >> On 15 Oct 2021, at 10:52, Bertrand Marquis wrote: >> >> Hi Roger, >> >>> On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: >>> >>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: From: Rahul Singh

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Ian Jackson
Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM."): > > On 15 Oct 2021, at 09:00, Jan Beulich wrote: > > The latter is fine to be put here (i.e. FTAOD I'm fine with it > > staying here). For the former

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Luca Fancellu
> On 15 Oct 2021, at 10:52, Bertrand Marquis wrote: > > Hi Roger, > >> On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: >> >> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: >>> From: Rahul Singh >>> >>> The existing VPCI support available for X86 is adapted for Arm.

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi Stefano, > On 15 Oct 2021, at 00:49, Stefano Stabellini wrote: > > On Thu, 14 Oct 2021, Bertrand Marquis wrote: >> From: Rahul Singh >> >> The existing VPCI support available for X86 is adapted for Arm. >> When the device is added to XEN via the hyper call >> “PHYSDEVOP_pci_device_add”,

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi Jan, > On 15 Oct 2021, at 09:00, Jan Beulich wrote: > > On 14.10.2021 16:49, Bertrand Marquis wrote: >> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >> >> check_pdev(pdev); >> >> +#ifdef CONFIG_ARM >> +/* >> + * On ARM PCI devices discovery will be done by

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM."): > On 15.10.2021 01:49, Stefano Stabellini wrote: > > Replacing the 3 characters with 'x' solves the problem. > > https://gitlab.com/xen-project/people/sstabellini/

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Bertrand Marquis
Hi Roger, > On 15 Oct 2021, at 09:32, Roger Pau Monné wrote: > > On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: >> From: Rahul Singh >> >> The existing VPCI support available for X86 is adapted for Arm. >> When the device is added to XEN via the hyper call >>

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Michal Orzel
On 15.10.2021 10:32, Roger Pau Monné wrote: > On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: >> From: Rahul Singh >> >> The existing VPCI support available for X86 is adapted for Arm. >> When the device is added to XEN via the hyper call >> “PHYSDEVOP_pci_device_add”, VPCI

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Roger Pau Monné
On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote: > From: Rahul Singh > > The existing VPCI support available for X86 is adapted for Arm. > When the device is added to XEN via the hyper call > “PHYSDEVOP_pci_device_add”, VPCI handler for the config space > access is added to the

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 14.10.2021 16:49, Bertrand Marquis wrote: > @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, > > check_pdev(pdev); > > +#ifdef CONFIG_ARM > +/* > + * On ARM PCI devices discovery will be done by Dom0. Add vpci handler > when > + * Dom0 inform XEN to add

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-15 Thread Jan Beulich
On 15.10.2021 01:49, Stefano Stabellini wrote: > On Thu, 14 Oct 2021, Bertrand Marquis wrote: >> --- a/xen/include/public/arch-arm.h >> +++ b/xen/include/public/arch-arm.h >> @@ -418,6 +418,13 @@ typedef uint64_t xen_callback_t; >> #define GUEST_GICV3_GICR0_BASE xen_mk_ullong(0x0302) /*

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-14 Thread Stefano Stabellini
On Thu, 14 Oct 2021, Bertrand Marquis wrote: > From: Rahul Singh > > The existing VPCI support available for X86 is adapted for Arm. > When the device is added to XEN via the hyper call > “PHYSDEVOP_pci_device_add”, VPCI handler for the config space > access is added to the Xen to emulate the

[PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-14 Thread Bertrand Marquis
From: Rahul Singh The existing VPCI support available for X86 is adapted for Arm. When the device is added to XEN via the hyper call “PHYSDEVOP_pci_device_add”, VPCI handler for the config space access is added to the Xen to emulate the PCI devices config space. A MMIO trap handler for the PCI