Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"): > Long term, I would expect a similar check to be necessary to set the > vCPI flag at the domain creation. So it would be best to introduce an > internal fi

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Ian Jackson
Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"): > On 15.10.2021 13:46, Ian Jackson wrote: > > Maybe something like > > > > // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to > &g

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Julien Grall
Hi Michal, On 15/10/2021 12:53, Michal Orzel wrote: On 15.10.2021 13:46, Ian Jackson wrote: Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"): On 15.10.2021 12:02, Ian Jackson wrote: Can you leave a comment somew

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Michal Orzel
On 15.10.2021 13:46, Ian Jackson wrote: > Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree > node in libxl [and 1 more messages]"): >> On 15.10.2021 12:02, Ian Jackson wrote: >>> Can you leave a comment somewhere (near where c_info.p

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Ian Jackson
Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"): > On 15.10.2021 12:02, Ian Jackson wrote: > > Can you leave a comment somewhere (near where c_info.passthrough is > > set) pointing to this use of num_p

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Michal Orzel
On 15.10.2021 12:58, Michal Orzel wrote: > Hi, > > On 15.10.2021 12:02, Ian Jackson wrote: >> Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree >> node in libxl [and 1 more messages]"): >>> On 14/10/2021 18:54, Ian Jackson wro

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Michal Orzel
Hi, On 15.10.2021 12:02, Ian Jackson wrote: > Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree > node in libxl [and 1 more messages]"): >> On 14/10/2021 18:54, Ian Jackson wrote: > ... >>> That is, as I understand it on ARM vpci sh

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"): > On 14/10/2021 18:54, Ian Jackson wrote: ... > > That is, as I understand it on ARM vpci should be enabled if > > passthrough is enabled and not otherwise

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Julien Grall
Hi Michal, On 15/10/2021 08:41, Michal Orzel wrote: Do you agree on the following approach: 1. Modify argument of libxl__arch_domain_init_hw_description to libxl_domain_config (patch 1) 2. Modify argument of libxl__prepare_dtb to libxl_domain_config (patch 2) 3. Remove arch_arm.vpci completely

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Michal Orzel
Hi guys, On 15.10.2021 09:28, Julien Grall wrote: > Hi Ian, > > On 14/10/2021 18:54, Ian Jackson wrote: >> (Replying to both the earlier subthread on v5 and to the new v6 >> patch.) >> >> Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI >> device tree node in libxl"): >>>

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-15 Thread Julien Grall
Hi Ian, On 14/10/2021 18:54, Ian Jackson wrote: (Replying to both the earlier subthread on v5 and to the new v6 patch.) Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"): Now you suggest to add a new field arm_vpci in

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-14 Thread Stefano Stabellini
On Thu, 14 Oct 2021, Ian Jackson wrote: > (Replying to both the earlier subthread on v5 and to the new v6 > patch.) > > Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device > tree node in libxl"): > > Now you suggest to add a new field arm_vpci in

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

2021-10-14 Thread Ian Jackson
(Replying to both the earlier subthread on v5 and to the new v6 patch.) Bertrand Marquis writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"): > Now you suggest to add a new field arm_vpci in libxl__domain_create_state. Hi. I was handwaving, hence "probably" :-).