Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-28 Thread Julien Grall
Hi, Replying to myself. On 27/03/2024 13:48, Julien Grall wrote: On 27/03/2024 13:38, Jan Beulich wrote: On 27.03.2024 14:28, Julien Grall wrote: Hi Carlo, On 27/03/2024 11:10, Carlo Nonato wrote: Hi guys, Question is: How would you justify such a change? IOW I'm not convinced (yet)

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Julien Grall
On 27/03/2024 13:38, Jan Beulich wrote: On 27.03.2024 14:28, Julien Grall wrote: Hi Carlo, On 27/03/2024 11:10, Carlo Nonato wrote: Hi guys, Question is: How would you justify such a change? IOW I'm not convinced (yet) this wants doing there. You mean in this series? Looking at the

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Jan Beulich
On 27.03.2024 14:28, Julien Grall wrote: > Hi Carlo, > > On 27/03/2024 11:10, Carlo Nonato wrote: >> Hi guys, >> >>> Question is: How would you justify such a change? IOW I'm not convinced >>> (yet) this wants doing there. >> >> You mean in this series? >> >>> Looking at the code, the flag is

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Julien Grall
Hi Carlo, On 27/03/2024 11:10, Carlo Nonato wrote: Hi guys, Question is: How would you justify such a change? IOW I'm not convinced (yet) this wants doing there. You mean in this series? Looking at the code, the flag is originally set in alloc_domheap_pages(). So I guess it would make

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-27 Thread Carlo Nonato
Hi guys, > Question is: How would you justify such a change? IOW I'm not convinced > (yet) this wants doing there. You mean in this series? > Looking at the code, the flag is originally set in > alloc_domheap_pages(). So I guess it would make sense to do it in > free_domheap_pages(). We don't

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-26 Thread Julien Grall
Hi Carlo & Jan, On 26/03/2024 17:04, Jan Beulich wrote: No, we need to get to the root of the issue. Since osstest has hit it quite easily as it seems, I'm somewhat surprised you didn't hit it in your testing. In any event, as per my earlier reply, my present guess is that your change has

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-26 Thread Jan Beulich
On 26.03.2024 17:39, Carlo Nonato wrote: > On Mon, Mar 25, 2024 at 8:19 AM Jan Beulich wrote: >> On 22.03.2024 16:07, Carlo Nonato wrote: >>> On Thu, Mar 21, 2024 at 5:23 PM Jan Beulich wrote: On 21.03.2024 17:10, Julien Grall wrote: > On 21/03/2024 16:07, Julien Grall wrote: >> On

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-26 Thread Carlo Nonato
Hi Jan, On Mon, Mar 25, 2024 at 8:19 AM Jan Beulich wrote: > > On 22.03.2024 16:07, Carlo Nonato wrote: > > Hi guys, > > > > On Thu, Mar 21, 2024 at 5:23 PM Jan Beulich wrote: > >> > >> On 21.03.2024 17:10, Julien Grall wrote: > >>> On 21/03/2024 16:07, Julien Grall wrote: > On 15/03/2024

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-25 Thread Jan Beulich
On 22.03.2024 16:07, Carlo Nonato wrote: > Hi guys, > > On Thu, Mar 21, 2024 at 5:23 PM Jan Beulich wrote: >> >> On 21.03.2024 17:10, Julien Grall wrote: >>> On 21/03/2024 16:07, Julien Grall wrote: On 15/03/2024 10:58, Carlo Nonato wrote: > PGC_static and PGC_extra needs to be

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-22 Thread Carlo Nonato
Hi guys, On Thu, Mar 21, 2024 at 5:23 PM Jan Beulich wrote: > > On 21.03.2024 17:10, Julien Grall wrote: > > On 21/03/2024 16:07, Julien Grall wrote: > >> On 15/03/2024 10:58, Carlo Nonato wrote: > >>> PGC_static and PGC_extra needs to be preserved when assigning a page. > >>> Define a new macro

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-21 Thread Jan Beulich
On 21.03.2024 17:10, Julien Grall wrote: > On 21/03/2024 16:07, Julien Grall wrote: >> On 15/03/2024 10:58, Carlo Nonato wrote: >>> PGC_static and PGC_extra needs to be preserved when assigning a page. >>> Define a new macro that groups those flags and use it instead of or'ing >>> every time. >>>

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-21 Thread Julien Grall
On 21/03/2024 16:07, Julien Grall wrote: (+ Roger) Hi Carlo, On 15/03/2024 10:58, Carlo Nonato wrote: PGC_static and PGC_extra needs to be preserved when assigning a page. Define a new macro that groups those flags and use it instead of or'ing every time. To make preserved flags even more

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-21 Thread Julien Grall
(+ Roger) Hi Carlo, On 15/03/2024 10:58, Carlo Nonato wrote: PGC_static and PGC_extra needs to be preserved when assigning a page. Define a new macro that groups those flags and use it instead of or'ing every time. To make preserved flags even more meaningful, they are kept also when

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-19 Thread Jan Beulich
On 15.03.2024 11:58, Carlo Nonato wrote: > PGC_static and PGC_extra needs to be preserved when assigning a page. > Define a new macro that groups those flags and use it instead of or'ing > every time. > > To make preserved flags even more meaningful, they are kept also when > switching state in

[PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

2024-03-15 Thread Carlo Nonato
PGC_static and PGC_extra needs to be preserved when assigning a page. Define a new macro that groups those flags and use it instead of or'ing every time. To make preserved flags even more meaningful, they are kept also when switching state in mark_page_free(). Signed-off-by: Carlo Nonato ---