Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-19 Thread Jan Beulich
On 19.02.2024 21:43, Stefano Stabellini wrote: > On Mon, 19 Feb 2024, Federico Serafini wrote: >> On 15/02/24 11:32, Jan Beulich wrote: >>> The important difference is: Here we're told that there was a use of >>> __put_user_bad, which is easy to grep for, and thus see how the >>> supplied function

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-19 Thread Stefano Stabellini
On Mon, 19 Feb 2024, Federico Serafini wrote: > On 15/02/24 11:32, Jan Beulich wrote: > > The important difference is: Here we're told that there was a use of > > __put_user_bad, which is easy to grep for, and thus see how the > > supplied function / file / line(?) relate to the ultimate problem.

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-19 Thread Federico Serafini
On 15/02/24 11:32, Jan Beulich wrote: The important difference is: Here we're told that there was a use of __put_user_bad, which is easy to grep for, and thus see how the supplied function / file / line(?) relate to the ultimate problem. I'm afraid I'm meanwhile confused enough by the various

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-15 Thread Jan Beulich
On 15.02.2024 11:07, Federico Serafini wrote: > On 15/02/24 09:10, Jan Beulich wrote: >> On 14.02.2024 17:11, Federico Serafini wrote: >>> I did some tries with example programs >>> and the assembler error always points to file and line >>> of the most enclosing function that caused the failure.

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-15 Thread Federico Serafini
On 15/02/24 09:10, Jan Beulich wrote: On 14.02.2024 17:11, Federico Serafini wrote: I did some tries with example programs and the assembler error always points to file and line of the most enclosing function that caused the failure. If I am not missing something, using __FILE__ and __LINE__

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-15 Thread Jan Beulich
On 15.02.2024 01:05, Stefano Stabellini wrote: > I don't think is a good idea to add further changes to this patch. I > think we should go ahead with it as-is. I didn't suggest adding anything right here; there may want/need to be new prereq-s, though. I'd like to make sure that we don't

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-15 Thread Jan Beulich
On 14.02.2024 17:11, Federico Serafini wrote: > I did some tries with example programs > and the assembler error always points to file and line > of the most enclosing function that caused the failure. > If I am not missing something, using __FILE__ and __LINE__ does not add > any information. >

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-14 Thread Stefano Stabellini
On Wed, 14 Feb 2024, Federico Serafini wrote: > On 12/02/24 09:43, Jan Beulich wrote: > > On 09.02.2024 10:50, Federico Serafini wrote: > > > On 08/02/24 12:14, Jan Beulich wrote: > > > > On 08.02.2024 11:45, Federico Serafini wrote: > > > > > On 07/02/24 17:19, Jan Beulich wrote: > > > > > > On

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-14 Thread Federico Serafini
On 12/02/24 09:43, Jan Beulich wrote: On 09.02.2024 10:50, Federico Serafini wrote: On 08/02/24 12:14, Jan Beulich wrote: On 08.02.2024 11:45, Federico Serafini wrote: On 07/02/24 17:19, Jan Beulich wrote: On 07.02.2024 16:58, Federico Serafini wrote: On 07/02/24 16:24, Jan Beulich wrote:

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-12 Thread Jan Beulich
On 09.02.2024 10:50, Federico Serafini wrote: > On 08/02/24 12:14, Jan Beulich wrote: >> On 08.02.2024 11:45, Federico Serafini wrote: >>> On 07/02/24 17:19, Jan Beulich wrote: On 07.02.2024 16:58, Federico Serafini wrote: > On 07/02/24 16:24, Jan Beulich wrote: >> On 07.02.2024

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-09 Thread Federico Serafini
On 08/02/24 12:14, Jan Beulich wrote: On 08.02.2024 11:45, Federico Serafini wrote: On 07/02/24 17:19, Jan Beulich wrote: On 07.02.2024 16:58, Federico Serafini wrote: On 07/02/24 16:24, Jan Beulich wrote: On 07.02.2024 16:08, Federico Serafini wrote: On 07/02/24 15:16, Jan Beulich wrote:

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-08 Thread Jan Beulich
On 08.02.2024 11:45, Federico Serafini wrote: > On 07/02/24 17:19, Jan Beulich wrote: >> On 07.02.2024 16:58, Federico Serafini wrote: >>> On 07/02/24 16:24, Jan Beulich wrote: On 07.02.2024 16:08, Federico Serafini wrote: > On 07/02/24 15:16, Jan Beulich wrote: >> On 07.02.2024

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-08 Thread Federico Serafini
On 07/02/24 17:19, Jan Beulich wrote: On 07.02.2024 16:58, Federico Serafini wrote: On 07/02/24 16:24, Jan Beulich wrote: On 07.02.2024 16:08, Federico Serafini wrote: On 07/02/24 15:16, Jan Beulich wrote: On 07.02.2024 14:51, Federico Serafini wrote: On 07/02/24 08:38, Jan Beulich wrote:

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-07 Thread Jan Beulich
On 07.02.2024 16:58, Federico Serafini wrote: > On 07/02/24 16:24, Jan Beulich wrote: >> On 07.02.2024 16:08, Federico Serafini wrote: >>> On 07/02/24 15:16, Jan Beulich wrote: On 07.02.2024 14:51, Federico Serafini wrote: > On 07/02/24 08:38, Jan Beulich wrote: >> On 07.02.2024

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-07 Thread Federico Serafini
On 07/02/24 16:24, Jan Beulich wrote: On 07.02.2024 16:08, Federico Serafini wrote: On 07/02/24 15:16, Jan Beulich wrote: On 07.02.2024 14:51, Federico Serafini wrote: On 07/02/24 08:38, Jan Beulich wrote: On 07.02.2024 02:08, Stefano Stabellini wrote: On Tue, 6 Feb 2024, Jan Beulich wrote:

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-07 Thread Jan Beulich
On 07.02.2024 16:08, Federico Serafini wrote: > On 07/02/24 15:16, Jan Beulich wrote: >> On 07.02.2024 14:51, Federico Serafini wrote: >>> On 07/02/24 08:38, Jan Beulich wrote: On 07.02.2024 02:08, Stefano Stabellini wrote: > On Tue, 6 Feb 2024, Jan Beulich wrote: >> On 26.01.2024

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-07 Thread Federico Serafini
On 07/02/24 15:16, Jan Beulich wrote: On 07.02.2024 14:51, Federico Serafini wrote: On 07/02/24 08:38, Jan Beulich wrote: On 07.02.2024 02:08, Stefano Stabellini wrote: On Tue, 6 Feb 2024, Jan Beulich wrote: On 26.01.2024 11:05, Federico Serafini wrote: @@ -208,7 +205,7 @@ do {

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-07 Thread Jan Beulich
On 07.02.2024 14:51, Federico Serafini wrote: > On 07/02/24 08:38, Jan Beulich wrote: >> On 07.02.2024 02:08, Stefano Stabellini wrote: >>> On Tue, 6 Feb 2024, Jan Beulich wrote: On 26.01.2024 11:05, Federico Serafini wrote: > @@ -208,7 +205,7 @@ do {

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-07 Thread Federico Serafini
On 07/02/24 08:38, Jan Beulich wrote: On 07.02.2024 02:08, Stefano Stabellini wrote: On Tue, 6 Feb 2024, Jan Beulich wrote: On 26.01.2024 11:05, Federico Serafini wrote: @@ -208,7 +205,7 @@ do { \ case 8:

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-06 Thread Jan Beulich
On 07.02.2024 02:08, Stefano Stabellini wrote: > On Tue, 6 Feb 2024, Jan Beulich wrote: >> On 26.01.2024 11:05, Federico Serafini wrote: >>> @@ -208,7 +205,7 @@ do { >>>\ >>> case 8:

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-06 Thread Stefano Stabellini
On Tue, 6 Feb 2024, Jan Beulich wrote: > On 26.01.2024 11:05, Federico Serafini wrote: > > @@ -208,7 +205,7 @@ do { > >\ > > case 8: > > \ > >

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-06 Thread Jan Beulich
On 26.01.2024 11:05, Federico Serafini wrote: > @@ -208,7 +205,7 @@ do { > \ > case 8:\ > put_unsafe_asm(x, ptr, grd, retval, "q", "", "ir",

[XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-01-26 Thread Federico Serafini
Use STATIC_ASSERT_UNREACHABLE() to improve readability and anticipate the build failure (from a linker error to an assembler error) in case of wrong size. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/uaccess.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff