Re: [XEN PATCH v2 2/7] x86/mm: address MISRA C:2012 Rule 2.1

2023-12-19 Thread Jan Beulich
On 18.12.2023 11:17, Nicola Vetrini wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4887,8 +4887,6 @@ long arch_memory_op(unsigned long cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > default: > return subarch_memory_op(cmd, arg); > } > - > -return 0; > } When

Re: [XEN PATCH v2 2/7] x86/mm: address MISRA C:2012 Rule 2.1

2023-12-18 Thread Stefano Stabellini
On Mon, 18 Dec 2023, Nicola Vetrini wrote: > The "return 0" after the swich statement in 'xen/arch/x86/mm.c' > is unreachable because all switch clauses end with returns, and > can thus be dropped. > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini

[XEN PATCH v2 2/7] x86/mm: address MISRA C:2012 Rule 2.1

2023-12-18 Thread Nicola Vetrini
The "return 0" after the swich statement in 'xen/arch/x86/mm.c' is unreachable because all switch clauses end with returns, and can thus be dropped. No functional changes. Signed-off-by: Nicola Vetrini --- Changes in v2: - Drop the final return instead. A stripped-down version of this switch