Re: [XEN PATCH v2 3/9] x86/irq: tidy switch statement and address MISRA violation

2024-04-08 Thread Nicola Vetrini
On 2024-04-09 02:14, Stefano Stabellini wrote: On Mon, 8 Apr 2024, Jan Beulich wrote: On 05.04.2024 11:14, Nicola Vetrini wrote: > Remove unneded blank lines between switch clauses. NAK for this part again. > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -2882,7 +2882,7 @@ int

Re: [XEN PATCH v2 3/9] x86/irq: tidy switch statement and address MISRA violation

2024-04-08 Thread Stefano Stabellini
On Mon, 8 Apr 2024, Jan Beulich wrote: > On 05.04.2024 11:14, Nicola Vetrini wrote: > > Remove unneded blank lines between switch clauses. > > NAK for this part again. > > > --- a/xen/arch/x86/irq.c > > +++ b/xen/arch/x86/irq.c > > @@ -2882,7 +2882,7 @@ int allocate_and_map_gsi_pirq(struct

Re: [XEN PATCH v2 3/9] x86/irq: tidy switch statement and address MISRA violation

2024-04-08 Thread Jan Beulich
On 05.04.2024 11:14, Nicola Vetrini wrote: > Remove unneded blank lines between switch clauses. NAK for this part again. > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -2882,7 +2882,7 @@ int allocate_and_map_gsi_pirq(struct domain *d, int > index, int *pirq_p) > int

[XEN PATCH v2 3/9] x86/irq: tidy switch statement and address MISRA violation

2024-04-05 Thread Nicola Vetrini
Remove unneded blank lines between switch clauses. Refactor the clauses so that a MISRA C Rule 16.2 violation is resolved (A switch label shall only be used when the most closely-enclosing compound statement is the body of a switch statement). Note that the switch clause ending with the pseudo