Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-19 Thread Jan Beulich
On 19.03.2024 04:34, Stefano Stabellini wrote: > On Mon, 18 Mar 2024, Jan Beulich wrote: >> On 16.03.2024 01:43, Stefano Stabellini wrote: >>> On Fri, 15 Mar 2024, Jan Beulich wrote: On 14.03.2024 23:59, Stefano Stabellini wrote: > On Mon, 11 Mar 2024, Simone Ballarin wrote: >> On

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-18 Thread Stefano Stabellini
On Mon, 18 Mar 2024, Jan Beulich wrote: > On 16.03.2024 01:43, Stefano Stabellini wrote: > > On Fri, 15 Mar 2024, Jan Beulich wrote: > >> On 14.03.2024 23:59, Stefano Stabellini wrote: > >>> On Mon, 11 Mar 2024, Simone Ballarin wrote: > On 11/03/24 14:56, Jan Beulich wrote: > > On

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-18 Thread Jan Beulich
On 16.03.2024 01:43, Stefano Stabellini wrote: > On Fri, 15 Mar 2024, Jan Beulich wrote: >> On 14.03.2024 23:59, Stefano Stabellini wrote: >>> On Mon, 11 Mar 2024, Simone Ballarin wrote: On 11/03/24 14:56, Jan Beulich wrote: > On 11.03.2024 13:00, Simone Ballarin wrote: >> On 11/03/24

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-15 Thread Stefano Stabellini
On Fri, 15 Mar 2024, Jan Beulich wrote: > On 14.03.2024 23:59, Stefano Stabellini wrote: > > On Mon, 11 Mar 2024, Simone Ballarin wrote: > >> On 11/03/24 14:56, Jan Beulich wrote: > >>> On 11.03.2024 13:00, Simone Ballarin wrote: > On 11/03/24 11:08, Jan Beulich wrote: > > On 11.03.2024

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-15 Thread Jan Beulich
On 14.03.2024 23:59, Stefano Stabellini wrote: > On Mon, 11 Mar 2024, Simone Ballarin wrote: >> On 11/03/24 14:56, Jan Beulich wrote: >>> On 11.03.2024 13:00, Simone Ballarin wrote: On 11/03/24 11:08, Jan Beulich wrote: > On 11.03.2024 09:59, Simone Ballarin wrote: >> ---

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-14 Thread Stefano Stabellini
On Mon, 11 Mar 2024, Simone Ballarin wrote: > On 11/03/24 14:56, Jan Beulich wrote: > > On 11.03.2024 13:00, Simone Ballarin wrote: > > > On 11/03/24 11:08, Jan Beulich wrote: > > > > On 11.03.2024 09:59, Simone Ballarin wrote: > > > > > --- a/xen/arch/arm/include/asm/hypercall.h > > > > > +++

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Simone Ballarin
On 11/03/24 14:56, Jan Beulich wrote: On 11.03.2024 13:00, Simone Ballarin wrote: On 11/03/24 11:08, Jan Beulich wrote: On 11.03.2024 09:59, Simone Ballarin wrote: --- a/xen/arch/arm/include/asm/hypercall.h +++ b/xen/arch/arm/include/asm/hypercall.h @@ -1,3 +1,4 @@ +/* SAF-5-safe direct

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Jan Beulich
On 11.03.2024 13:00, Simone Ballarin wrote: > On 11/03/24 11:08, Jan Beulich wrote: >> On 11.03.2024 09:59, Simone Ballarin wrote: >>> --- a/xen/arch/arm/include/asm/hypercall.h >>> +++ b/xen/arch/arm/include/asm/hypercall.h >>> @@ -1,3 +1,4 @@ >>> +/* SAF-5-safe direct inclusion guard before */

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Simone Ballarin
On 11/03/24 11:08, Jan Beulich wrote: On 11.03.2024 09:59, Simone Ballarin wrote: Add deviation comments to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Jan Beulich
On 11.03.2024 09:59, Simone Ballarin wrote: > Add deviation comments to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Inclusion guards must appear at the beginning of the

[XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Simone Ballarin
Add deviation comments to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must appear at the beginning of the headers (comments are permitted anywhere). This patch