Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-28 Thread Juergen Gross
On 28/09/2018 00:03, Sander Eikelenboom wrote: > On 27/09/18 23:48, Boris Ostrovsky wrote: >> On 9/27/18 5:37 PM, Jens Axboe wrote: >>> On 9/27/18 2:33 PM, Sander Eikelenboom wrote: On 27/09/18 21:06, Boris Ostrovsky wrote: > On 9/27/18 2:56 PM, Jens Axboe wrote: >> On 9/27/18 12:52

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Sander Eikelenboom
On 27/09/18 23:48, Boris Ostrovsky wrote: > On 9/27/18 5:37 PM, Jens Axboe wrote: >> On 9/27/18 2:33 PM, Sander Eikelenboom wrote: >>> On 27/09/18 21:06, Boris Ostrovsky wrote: On 9/27/18 2:56 PM, Jens Axboe wrote: > On 9/27/18 12:52 PM, Sander Eikelenboom wrote: >> On 27/09/18 16:26,

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Boris Ostrovsky
On 9/27/18 5:37 PM, Jens Axboe wrote: > On 9/27/18 2:33 PM, Sander Eikelenboom wrote: >> On 27/09/18 21:06, Boris Ostrovsky wrote: >>> On 9/27/18 2:56 PM, Jens Axboe wrote: On 9/27/18 12:52 PM, Sander Eikelenboom wrote: > On 27/09/18 16:26, Jens Axboe wrote: >> On 9/27/18 1:12 AM,

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Jens Axboe
On 9/27/18 2:33 PM, Sander Eikelenboom wrote: > On 27/09/18 21:06, Boris Ostrovsky wrote: >> On 9/27/18 2:56 PM, Jens Axboe wrote: >>> On 9/27/18 12:52 PM, Sander Eikelenboom wrote: On 27/09/18 16:26, Jens Axboe wrote: > On 9/27/18 1:12 AM, Juergen Gross wrote: >> On 22/09/18 21:55,

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Sander Eikelenboom
On 27/09/18 21:06, Boris Ostrovsky wrote: > On 9/27/18 2:56 PM, Jens Axboe wrote: >> On 9/27/18 12:52 PM, Sander Eikelenboom wrote: >>> On 27/09/18 16:26, Jens Axboe wrote: On 9/27/18 1:12 AM, Juergen Gross wrote: > On 22/09/18 21:55, Boris Ostrovsky wrote: >> Commit a46b53672b2c

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Jens Axboe
On 9/27/18 1:06 PM, Boris Ostrovsky wrote: > On 9/27/18 2:56 PM, Jens Axboe wrote: >> On 9/27/18 12:52 PM, Sander Eikelenboom wrote: >>> On 27/09/18 16:26, Jens Axboe wrote: On 9/27/18 1:12 AM, Juergen Gross wrote: > On 22/09/18 21:55, Boris Ostrovsky wrote: >> Commit a46b53672b2c

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Boris Ostrovsky
On 9/27/18 2:56 PM, Jens Axboe wrote: > On 9/27/18 12:52 PM, Sander Eikelenboom wrote: >> On 27/09/18 16:26, Jens Axboe wrote: >>> On 9/27/18 1:12 AM, Juergen Gross wrote: On 22/09/18 21:55, Boris Ostrovsky wrote: > Commit a46b53672b2c ("xen/blkfront: cleanup stale persistent grants")

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Jens Axboe
On 9/27/18 12:52 PM, Sander Eikelenboom wrote: > On 27/09/18 16:26, Jens Axboe wrote: >> On 9/27/18 1:12 AM, Juergen Gross wrote: >>> On 22/09/18 21:55, Boris Ostrovsky wrote: Commit a46b53672b2c ("xen/blkfront: cleanup stale persistent grants") added support for purging persistent

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Sander Eikelenboom
On 27/09/18 16:26, Jens Axboe wrote: > On 9/27/18 1:12 AM, Juergen Gross wrote: >> On 22/09/18 21:55, Boris Ostrovsky wrote: >>> Commit a46b53672b2c ("xen/blkfront: cleanup stale persistent grants") >>> added support for purging persistent grants when they are not in use. As >>> part of the purge,

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Jens Axboe
On 9/27/18 1:12 AM, Juergen Gross wrote: > On 22/09/18 21:55, Boris Ostrovsky wrote: >> Commit a46b53672b2c ("xen/blkfront: cleanup stale persistent grants") >> added support for purging persistent grants when they are not in use. As >> part of the purge, the grants were removed from the grant

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Juergen Gross
On 22/09/18 21:55, Boris Ostrovsky wrote: > Commit a46b53672b2c ("xen/blkfront: cleanup stale persistent grants") > added support for purging persistent grants when they are not in use. As > part of the purge, the grants were removed from the grant buffer, This > eventually causes the buffer to

[Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-22 Thread Boris Ostrovsky
Commit a46b53672b2c ("xen/blkfront: cleanup stale persistent grants") added support for purging persistent grants when they are not in use. As part of the purge, the grants were removed from the grant buffer, This eventually causes the buffer to become empty, with BUG_ON triggered in