Re: [PATCH 1/4] x86/P2M: write_p2m_entry() is HVM-only anyway

2024-04-24 Thread Jan Beulich
On 24.04.2024 08:36, Jan Beulich wrote: > On 23.04.2024 21:29, Andrew Cooper wrote: >> On 23/04/2024 3:31 pm, Jan Beulich wrote: >>> The latest as of e2b2ff677958 ("x86/P2M: split out init/teardown >>> functions") the function is obviously unreachable for PV guests. >> >> This doesn't parse.  Do

Re: [PATCH 1/4] x86/P2M: write_p2m_entry() is HVM-only anyway

2024-04-24 Thread Jan Beulich
On 23.04.2024 21:29, Andrew Cooper wrote: > On 23/04/2024 3:31 pm, Jan Beulich wrote: >> The latest as of e2b2ff677958 ("x86/P2M: split out init/teardown >> functions") the function is obviously unreachable for PV guests. > > This doesn't parse.  Do you mean "Since e2b2ff677958 ..." ? Well. I'm

Re: [PATCH 1/4] x86/P2M: write_p2m_entry() is HVM-only anyway

2024-04-23 Thread Andrew Cooper
On 23/04/2024 3:31 pm, Jan Beulich wrote: > The latest as of e2b2ff677958 ("x86/P2M: split out init/teardown > functions") the function is obviously unreachable for PV guests. This doesn't parse.  Do you mean "Since e2b2ff677958 ..." ? > Hence > the paging_mode_enabled(d) check is pointless. >