Re: [PATCH v1] tools/ocaml: fix warnings

2024-04-25 Thread Christian Lindig
> On 27 Mar 2024, at 16:30, Edwin Török wrote: > > Do not rely on the string values of the `Failure` exception, > but use the `_opt` functions instead. > > Signed-off-by: Edwin Török > --- > tools/ocaml/xenstored/config.ml | 20 +++- > 1 file changed, 11 insertions(+), 9

Re: [PATCH v1] tools/ocaml: fix warnings

2024-03-27 Thread Andrew Cooper
On 27/03/2024 4:30 pm, Edwin Török wrote: > Do not rely on the string values of the `Failure` exception, > but use the `_opt` functions instead. > > Signed-off-by: Edwin Török FWIW, Tested-by: Andrew Cooper But I think the subject wants to say "in config.ml" and the commit message gain