Hi Julien,
>
> Rest LGTM:
> Reviewed-by: Michal Orzel
Thanks, I will send the next one shortly.
>>> I don't think there is a need to respin the whole series just for these
>>> fixes.
>>> You should wait for the committers opinion.
>> AFAICT, there are multiple
Hi,
On 22/04/2024 11:24, Julien Grall wrote:
Hi,
On 22/04/2024 10:26, Michal Orzel wrote:
On 22/04/2024 10:07, Luca Fancellu wrote:
Hi Michal,
+ for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells
+= reg_size )
+ {
+ u64 start = dt_read_number(cells, addrcells);
Hi Luca,
On 22/04/2024 11:39, Luca Fancellu wrote:
On 22 Apr 2024, at 11:24, Julien Grall wrote:
Hi,
On 22/04/2024 10:26, Michal Orzel wrote:
On 22/04/2024 10:07, Luca Fancellu wrote:
Hi Michal,
+for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += reg_size )
+{
+
> On 22 Apr 2024, at 11:24, Julien Grall wrote:
>
> Hi,
>
> On 22/04/2024 10:26, Michal Orzel wrote:
>> On 22/04/2024 10:07, Luca Fancellu wrote:
>>>
>>>
>>> Hi Michal,
>>>
> +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells +=
> reg_size )
> +{
> +
Hi,
On 22/04/2024 10:26, Michal Orzel wrote:
On 22/04/2024 10:07, Luca Fancellu wrote:
Hi Michal,
+for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += reg_size )
+{
+u64 start = dt_read_number(cells, addrcells);
We should no longer use Linux derived types
On 22/04/2024 10:07, Luca Fancellu wrote:
>
>
> Hi Michal,
>
>>> +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells +=
>>> reg_size )
>>> +{
>>> +u64 start = dt_read_number(cells, addrcells);
>> We should no longer use Linux derived types like u64. Use uint64_t.
Hi Michal,
>> +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells +=
>> reg_size )
>> +{
>> +u64 start = dt_read_number(cells, addrcells);
> We should no longer use Linux derived types like u64. Use uint64_t.
>
>> +u64 size = dt_read_number(cells + addrcells,
Hi Luca,
On 18/04/2024 09:36, Luca Fancellu wrote:
>
>
> Currently Xen is not exporting the static shared memory regions
> to the device tree as /memory node, this commit is fixing this
> issue.
>
> Given that now make_memory_node needs a parameter 'struct kernel_info'
> in order to call the