Re: [PATCH] xen/events: close evtchn after mapping cleanup

2024-02-08 Thread Maximilian Heyne
On Wed, Jan 24, 2024 at 04:31:28PM +, Maximilian Heyne wrote: > shutdown_pirq and startup_pirq are not taking the > irq_mapping_update_lock because they can't due to lock inversion. Both > are called with the irq_desc->lock being taking. The lock order, > however, is first

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-08 Thread Christian Lindig
> On 7 Feb 2024, at 22:04, Petr Beneš wrote: > > > Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the > vm.cfg configuration, correcting an oversight from its initial introduction. > > Signed-off-by: Petr Beneš Acked-by: Christian Lindig This looks correct from an

Re: [PATCH 2/7] IOMMU: rename and re-type ats_enabled

2024-02-08 Thread Roger Pau Monné
On Mon, Feb 05, 2024 at 02:55:43PM +0100, Jan Beulich wrote: > Make the variable a tristate, with (as done elsewhere) a negative value > meaning "default". Since all use sites need looking at, also rename it > to match our usual "opt_*" pattern. While touching it, also move it to >

Re: [XEN PATCH 8/9] x86/smp: make cpu_state per-CPU

2024-02-08 Thread Jan Beulich
On 14.11.2023 18:50, Krystian Hebel wrote: > This will be used for parallel AP bring-up. > > CPU_STATE_INIT changed direction. Nit: I think you mean "changes" as you describe what the patch does, not what has happened before. But ... > It was previously set by BSP and never > consumed by AP.

[PATCH v2] config: update Mini-OS commit

2024-02-08 Thread Juergen Gross
Update the Mini-OS upstream revision. Signed-off-by: Juergen Gross --- V2: - newer commit fixing a bug --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index f7d6d84847..6f6e0425ba 100644 --- a/Config.mk +++ b/Config.mk @@ -224,7 +224,7 @@

CFP for Xen Summit 2024!

2024-02-08 Thread Kelly Choi
Hi all, *A reminder that our CFP for Xen Summit 2024 closes in less than a month! * We'd love to hear from you. Submit your talk here: https://events.linuxfoundation.org/xen-project-summit/ Many thanks, Kelly Choi Community Manager Xen Project

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-08 Thread Jan Beulich
On 08.02.2024 11:45, Federico Serafini wrote: > On 07/02/24 17:19, Jan Beulich wrote: >> On 07.02.2024 16:58, Federico Serafini wrote: >>> On 07/02/24 16:24, Jan Beulich wrote: On 07.02.2024 16:08, Federico Serafini wrote: > On 07/02/24 15:16, Jan Beulich wrote: >> On 07.02.2024

Re: [PATCH 1/7] VT-d: parse ACPI "SoC Integrated Address Translation Cache Reporting Structure"s

2024-02-08 Thread Roger Pau Monné
On Mon, Feb 05, 2024 at 02:55:17PM +0100, Jan Beulich wrote: > This is a prereq to us, in particular, respecting the "ATC required" > flag. > > Signed-off-by: Jan Beulich > --- > Should we check scope entries for appropriate types? (If so, then also > for e.g. ATSR.) Hm, I guess we could do so

[xen-unstable test] 184622: tolerable FAIL - PUSHED

2024-02-08 Thread osstest service owner
flight 184622 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184622/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184617

Re: [PATCH 3/7] VT-d: respect ACPI SATC's ATC_REQUIRED flag

2024-02-08 Thread Roger Pau Monné
On Mon, Feb 05, 2024 at 02:56:14PM +0100, Jan Beulich wrote: > When the flag is set, permit Dom0 to control the device (no worse than > what we had before and in line with other "best effort" behavior we use > when it comes to Dom0), but suppress passing through to DomU-s unless > ATS can actually

Re: [PATCH v4 02/32] tools: add a new xen logging daemon

2024-02-08 Thread Jürgen Groß
On 08.02.24 01:52, Andrew Cooper wrote: On 05/02/2024 10:49 am, Juergen Gross wrote: Add "xen-9pfsd", a new logging daemon meant to support infrastructure domains (e.g. xenstore-stubdom) to access files in dom0. I was still expecting for "logging" to disappear from this. In both cases it

Re: [PATCH v4 14/32] tools/xen-9pfsd: add 9pfs read request support

2024-02-08 Thread Jürgen Groß
On 08.02.24 02:28, Jason Andryuk wrote: On Mon, Feb 5, 2024 at 5:51 AM Juergen Gross wrote: Add the read request of the 9pfs protocol. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD --- V2: - make error check more readable (Jason Andryuk) V4: - add

Re: [XEN PATCH] docs/misra: add x86_64 and arm64 asm-offset.c to exclude-list

2024-02-08 Thread Nicola Vetrini
Hi Jan, On 2024-02-08 09:05, Jan Beulich wrote: On 08.02.2024 08:55, Nicola Vetrini wrote: These two files contain several deliberate violations of MISRA C rules and they are not linked in the final Xen binary, therefore they can be exempted from MISRA compliance. No functional change.

Re: [PATCH] x86/vmx: add support for virtualize SPEC_CTRL

2024-02-08 Thread Jan Beulich
On 06.02.2024 15:25, Roger Pau Monne wrote: > @@ -2086,6 +2091,9 @@ void vmcs_dump_vcpu(struct vcpu *v) > if ( v->arch.hvm.vmx.secondary_exec_control & > SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY ) > printk("InterruptStatus = %04x\n", vmr16(GUEST_INTR_STATUS)); > +if (

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-08 Thread Tamas K Lengyel
On Thu, Feb 8, 2024 at 2:46 AM Jan Beulich wrote: > > On 08.02.2024 05:32, George Dunlap wrote: > > Er, ok, just one more comment: this could allow an altp2m to have more > > permissions than the host; for example, the host p2m entry could be > > p2m_access_r, but if the altp2m's default_access

[libvirt test] 184624: tolerable all pass - PUSHED

2024-02-08 Thread osstest service owner
flight 184624 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/184624/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184613 test-armhf-armhf-libvirt-qcow2 15

[PATCH] xen/arm: Fix UBSAN failure in start_xen()

2024-02-08 Thread Michal Orzel
When running Xen on arm32, in scenario where Xen is loaded at an address such as boot_phys_offset >= 2GB, UBSAN reports the following: (XEN) UBSAN: Undefined behaviour in arch/arm/setup.c:739:58 (XEN) pointer operation underflowed 0020 to 8680 (XEN) Xen WARN at common/ubsan/ubsan.c:172

Re: [XEN PATCH 9/9] x86/smp: start APs in parallel during boot

2024-02-08 Thread Jan Beulich
On 14.11.2023 18:50, Krystian Hebel wrote: > Multiple delays are required when sending IPIs and waiting for > responses. During boot, 4 such IPIs were sent per each AP. With this > change, only one set of broadcast IPIs is sent. This reduces boot time, > especially for platforms with large number

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-08 Thread Tamas K Lengyel
On Thu, Feb 8, 2024 at 9:00 AM Jan Beulich wrote: > > On 08.02.2024 14:45, Tamas K Lengyel wrote: > > On Thu, Feb 8, 2024 at 2:46 AM Jan Beulich wrote: > >> > >> On 08.02.2024 05:32, George Dunlap wrote: > >>> Er, ok, just one more comment: this could allow an altp2m to have more > >>>

Re: [PATCH] tools/xentop: add option to display dom0 first

2024-02-08 Thread zithro
On 07 Feb 2024 16:44, Anthony PERARD wrote: No worries, and your patch was reviewed so you didn't failed to the strict minimum ;-). Ahah, true, just felt a bit stupid ! Thanks, and also for the gdb pointers. But sorry for nooby "non-rebased/non-squashed" v2, fixed now ;) I have a "display

Re: [XEN PATCH 6/9] x86/shutdown: protect against recurrent machine_restart()

2024-02-08 Thread Jan Beulich
On 14.11.2023 18:50, Krystian Hebel wrote: > If multiple CPUs called machine_restart() before actual restart took > place, but after boot CPU declared itself not online, Can you help me please in identifying where this operation is? I can see two places where a CPU is removed from cpu_online_map,

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-08 Thread Jan Beulich
On 08.02.2024 14:45, Tamas K Lengyel wrote: > On Thu, Feb 8, 2024 at 2:46 AM Jan Beulich wrote: >> >> On 08.02.2024 05:32, George Dunlap wrote: >>> Er, ok, just one more comment: this could allow an altp2m to have more >>> permissions than the host; for example, the host p2m entry could be >>>

Re: [PATCH] xen: Swap order of actions in the FREE*() macros

2024-02-08 Thread Bertrand Marquis
Hi Andrew, > On 2 Feb 2024, at 00:39, Andrew Cooper wrote: > > Wherever possible, it is a good idea to NULL out the visible reference to an > object prior to freeing it. The FREE*() macros already collect together both > parts, making it easy to adjust. > > This has a marginal code

Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE()

2024-02-08 Thread Federico Serafini
On 07/02/24 17:19, Jan Beulich wrote: On 07.02.2024 16:58, Federico Serafini wrote: On 07/02/24 16:24, Jan Beulich wrote: On 07.02.2024 16:08, Federico Serafini wrote: On 07/02/24 15:16, Jan Beulich wrote: On 07.02.2024 14:51, Federico Serafini wrote: On 07/02/24 08:38, Jan Beulich wrote:

Re: [XEN PATCH 7/9] x86/smp: drop booting_cpu variable

2024-02-08 Thread Jan Beulich
On 14.11.2023 18:50, Krystian Hebel wrote: > CPU id is obtained as a side effect of searching for appropriate > stack for AP. It can be used as a parameter to start_secondary(). > Coincidentally this also makes further work on making AP bring-up > code parallel easier. It's not just "easier", but

[PATCH] xen/serial: Drop serial_{put,get}c

2024-02-08 Thread Michal Orzel
After removal of gdbstub by commit d182f9feae6d ("x86: Remove gdbstub"), we no longer have users of serial_{put,get}c functions, so remove them. Signed-off-by: Michal Orzel --- xen/drivers/char/serial.c | 72 --- xen/include/xen/serial.h | 10 -- 2 files

Re: [PATCH 2/7] IOMMU: rename and re-type ats_enabled

2024-02-08 Thread Jan Beulich
On 08.02.2024 12:49, Roger Pau Monné wrote: > On Mon, Feb 05, 2024 at 02:55:43PM +0100, Jan Beulich wrote: >> Make the variable a tristate, with (as done elsewhere) a negative value >> meaning "default". Since all use sites need looking at, also rename it >> to match our usual "opt_*" pattern.

[PATCH v5 15/22] tools/libs/light: add backend type for 9pfs PV devices

2024-02-08 Thread Juergen Gross
Make the backend type of 9pfs PV devices configurable. The default is "qemu" with the related Xenstore backend-side directory being "9pfs". Add another type "xen_9pfsd" with the related Xenstore backend-side directory "xen_9pfs". As additional security features it is possible to specify: -

[PATCH v5 13/22] tools/9pfsd: add 9pfs write request support

2024-02-08 Thread Juergen Gross
Add the write request of the 9pfs protocol. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD --- tools/9pfsd/io.c | 54 1 file changed, 54 insertions(+) diff --git a/tools/9pfsd/io.c b/tools/9pfsd/io.c index

[PATCH v5 11/22] tools/9pfsd: add 9pfs create request support

2024-02-08 Thread Juergen Gross
Add the create request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V2: - set permissions correctly (Jason Andryuk) V3: - use opendirat() etc. (Jason Andryuk) - rework error handling a little bit --- tools/9pfsd/io.c | 151

Re: Xen 4.19 release status tracking list

2024-02-08 Thread Julien Grall
Hi Oleksii, On 05/02/2024 19:23, Oleksii Kurochko wrote: Hello everyone, I would like to share with you a list for status tracking based on Xen ML: Arm: * [PATCH v5 00/13] Arm cache coloring [ https://lore.kernel.org/xen-devel/20240102095138.17933-1-carlo.non...@minervasys.tech/ ] *

[PATCH v5 16/22] tools/xl: support new 9pfs backend xen_9pfsd

2024-02-08 Thread Juergen Gross
Add support for the new 9pfs backend "xen_9pfsd". For this backend type the tag defaults to "Xen" and the host side path to "/var/log/xen/guests/". Do most of the default settings in libxl. Unfortunately the default path can't easily be set in libxl, as the domain name isn't available in the

[PATCH v5 09/22] tools/9pfsd: add 9pfs open request support

2024-02-08 Thread Juergen Gross
Add the open request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V2: - don't allow to open symbolic link V3: - use openat() (Jason Andryuk) - use common error handling in p9_open() --- tools/9pfsd/io.c| 137

Re: [PATCH v6 3/7] VMX: convert entry point annotations

2024-02-08 Thread Jan Beulich
On 07.02.2024 15:25, Jan Beulich wrote: > On 07.02.2024 14:55, Andrew Cooper wrote: >> On 07/02/2024 1:37 pm, Jan Beulich wrote: >>> Use the generic framework from xen/linkage.h. >>> >>> Signed-off-by: Jan Beulich >>> --- >>> v6: New. >>> >>> --- a/xen/arch/x86/hvm/vmx/entry.S >>> +++

[PATCH v5 12/22] tools/9pfsd: add 9pfs stat request support

2024-02-08 Thread Juergen Gross
Add the stat request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V3: - use fstatat() (Jason Andryuk) V4: - add "s" format to fill_buffer() as a preparation for reading dirs --- tools/9pfsd/io.c | 102

[PATCH v5 10/22] tools/9pfsd: add 9pfs clunk request support

2024-02-08 Thread Juergen Gross
Add the clunk request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V3: - use unlinkat() (Jason Andryuk) --- tools/9pfsd/io.c | 43 +++ 1 file changed, 43 insertions(+) diff --git

[PATCH v5 21/22] tools/xenstored: support complete log capabilities in stubdom

2024-02-08 Thread Juergen Gross
With 9pfs being fully available in Xenstore-stubdom now, there is no reason to not fully support all logging capabilities in stubdom. Open the logfile on stubdom only after the 9pfs file system has been mounted. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall

[PATCH v5 20/22] tools/xenstored: add helpers for filename handling

2024-02-08 Thread Juergen Gross
Add some helpers for handling filenames which might need different implementations between stubdom and daemon environments: - expansion of relative filenames (those are not really defined today, just expand them to be relative to /var/lib/xen/xenstore) - expansion of xenstore_daemon_rundir()

[linux-linus test] 184625: FAIL

2024-02-08 Thread osstest service owner
flight 184625 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184625/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu broken in 184620 Tests

Re: [PATCH] xen/arm: Fix UBSAN failure in start_xen()

2024-02-08 Thread Julien Grall
Hi Michal, On 08/02/2024 10:43, Michal Orzel wrote: When running Xen on arm32, in scenario where Xen is loaded at an address such as boot_phys_offset >= 2GB, UBSAN reports the following: (XEN) UBSAN: Undefined behaviour in arch/arm/setup.c:739:58 (XEN) pointer operation underflowed 0020 to

[PATCH v5 07/22] tools/9pfsd: add 9pfs attach request support

2024-02-08 Thread Juergen Gross
Add the attach request of the 9pfs protocol. This introduces the "fid" scheme of the 9pfs protocol. As this will be needed later, use a dedicated memory allocation function in alloc_fid() and prepare a fid reference count. For filling the qid data take the approach from the qemu 9pfs backend

[PATCH v5 06/22] tools/9pfsd: add 9pfs version request support

2024-02-08 Thread Juergen Gross
Add the version request of the 9pfs protocol. For the version use the "9P2000.u" variant, as it is supported by Mini-OS and Linux. For the request parsing add all format items needed even in future in order to avoid code churn for those additions later. Signed-off-by: Juergen Gross Acked-by:

[PATCH v5 08/22] tools/9pfsd: add 9pfs walk request support

2024-02-08 Thread Juergen Gross
Add the walk request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V2: - don't allow walking across symbolic links --- tools/9pfsd/io.c| 171 tools/9pfsd/xen-9pfsd.h | 1 + 2 files

[PATCH v5 14/22] tools/9pfsd: add 9pfs read request support

2024-02-08 Thread Juergen Gross
Add the read request of the 9pfs protocol. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD --- V2: - make error check more readable (Jason Andryuk) V4: - add directory read support V5: - rewinddir() if reading a directory and offset is 0 (Jason Andryuk) ---

[PATCH v5 19/22] tools/xenstored: mount 9pfs device in stubdom

2024-02-08 Thread Juergen Gross
Mount the 9pfs device in stubdom enabling it to use files. This has to happen in a worker thread in order to allow the main thread handling the required Xenstore accesses in parallel. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall --- V3: - add logging in

[PATCH v5 22/22] tools/xenstored: have a single do_control_memreport()

2024-02-08 Thread Juergen Gross
With 9pfs now available in Xenstore-stubdom, there is no reason to have distinct do_control_memreport() variants for the daemon and the stubdom implementations. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- tools/xenstored/control.c | 27 +++ 1 file

Re: [PATCH] x86/HVM: tidy state on hvmemul_map_linear_addr()'s error path

2024-02-08 Thread Jan Beulich
On 06.02.2024 13:06, Jan Beulich wrote: > While in the vast majority of cases failure of the function will not > be followed by re-invocation with the same emulation context, a few > very specific insns - involving multiple independent writes, e.g. ENTER > and PUSHA - exist where this can happen.

Re: [XEN PATCH v2] docs/misra: add asm-offset.c to exclude-list

2024-02-08 Thread Nicola Vetrini
On 2024-02-08 16:56, Jan Beulich wrote: On 08.02.2024 16:50, Nicola Vetrini wrote: These files contain several deliberate violations of MISRA C rules and they are not linked in the final Xen binary, therefore they can be exempted from MISRA compliance. No functional change. Signed-off-by:

Re: [PATCH] x86/HVM: tidy state on hvmemul_map_linear_addr()'s error path

2024-02-08 Thread Jan Beulich
On 08.02.2024 17:11, Paul Durrant wrote: > On 08/02/2024 15:59, Jan Beulich wrote: >> On 06.02.2024 13:06, Jan Beulich wrote: >>> While in the vast majority of cases failure of the function will not >>> be followed by re-invocation with the same emulation context, a few >>> very specific insns -

[PATCH] docs: add a best practices coding guide

2024-02-08 Thread Juergen Gross
Today the CODING_STYLE contains a section "Handling unexpected conditions" specific to the hypervisor. This section is kind of misplaced for a coding style. It should rather be part of a "Coding best practices" guide. Add such a guide as docs/process/coding-best-practices.pandoc and move the

Re: [PATCH] docs: add a best practices coding guide

2024-02-08 Thread Julien Grall
Hi Juergen, On 08/02/2024 16:05, Juergen Gross wrote: Today the CODING_STYLE contains a section "Handling unexpected conditions" specific to the hypervisor. This section is kind of misplaced for a coding style. It should rather be part of a "Coding best practices" guide. Add such a guide as

[PATCH v5 03/22] tools/9pfsd: connect to frontend

2024-02-08 Thread Juergen Gross
Add the code for connecting to frontends to xenlogd. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V2: - support multiple rings per device (Jason Andryuk) - don't set .revents initially (Jason Andryuk) - call poll() with infinite timeout (Jason Andryuk) -

[PATCH v5 02/22] tools: add a new xen 9pfs daemon

2024-02-08 Thread Juergen Gross
Add "xen-9pfsd", a new 9pfs daemon meant to support infrastructure domains (e.g. xenstore-stubdom) to access files in dom0. For now only add the code needed for starting the daemon and registering it with Xenstore via a new "libxl/xen-9pfs/state" node by writing the "running" state to it.

[PATCH v5 00/22] tools: enable xenstore-stubdom to use 9pfs

2024-02-08 Thread Juergen Gross
This series is adding 9pfs support to Xenstore-stubdom, enabling it to do logging to a dom0 directory. This is a prerequisite for the final goal to add live update support to Xenstore-stubdom, as it enables the stubdom to store its state in a dom0 file. The 9pfs backend is a new daemon written

[PATCH v5 04/22] tools/9pfsd: add transport layer

2024-02-08 Thread Juergen Gross
Add the transport layer of 9pfs. This is basically the infrastructure to receive requests from the frontend and to send the related answers via the rings. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD --- V2: - rename put_request_bytes() (Jason Andryuk) -

[PATCH v5 05/22] tools/9pfsd: add 9pfs response generation support

2024-02-08 Thread Juergen Gross
Add support for generation a 9pfs protocol response via a format based approach. Strings are stored in a per device string buffer and they are referenced via their offset in this buffer. This allows to avoid having to dynamically allocate memory for each single string. As a first user of the

[PATCH v5 01/22] tools: add access macros for unaligned data

2024-02-08 Thread Juergen Gross
Add the basic access macros for unaligned data to common-macros.h. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper --- V3: - new patch --- tools/include/xen-tools/common-macros.h | 17 + 1 file changed, 17 insertions(+) diff --git a/tools/include/xen-tools/common-macros.h

Re: [PATCH] xen/arm: Fix UBSAN failure in start_xen()

2024-02-08 Thread Luca Fancellu
> On 8 Feb 2024, at 10:43, Michal Orzel wrote: > > When running Xen on arm32, in scenario where Xen is loaded at an address > such as boot_phys_offset >= 2GB, UBSAN reports the following: > > (XEN) UBSAN: Undefined behaviour in arch/arm/setup.c:739:58 > (XEN) pointer operation underflowed

Re: [XEN PATCH v2] docs/misra: add asm-offset.c to exclude-list

2024-02-08 Thread Jan Beulich
On 08.02.2024 16:50, Nicola Vetrini wrote: > These files contain several deliberate violations of MISRA C rules and > they are not linked in the final Xen binary, therefore they can be exempted > from MISRA compliance. > > No functional change. > > Signed-off-by: Nicola Vetrini Acked-by: Jan

[PATCH v5 17/22] stubdom: extend xenstore stubdom configs

2024-02-08 Thread Juergen Gross
Extend the config files of the Xenstore stubdoms to include XENBUS and 9PFRONT items in order to support file based logging. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- stubdom/xenstore-minios.cfg| 2 +- stubdom/xenstorepvh-minios.cfg | 2 +- 2 files changed, 2

Re: [PATCH] xen: move BUG_ON(), WARN_ON(), ASSERT(), ASSERT_UNREACHABLE() to xen/bug.h

2024-02-08 Thread Jan Beulich
On 02.02.2024 19:03, Oleksii Kurochko wrote: > Move the macros mentioned in the commit subject to their appropriate > locations. > Additionally, eliminate the dependency of xen/lib.h from xen/bug.h and > include "xen/bug.h" in files where xen/bug.h macros are utilized. > > Most of the changes

Re: [PATCH 4/7] VT-d: replace find_ats_dev_drhd()

2024-02-08 Thread Roger Pau Monné
On Mon, Feb 05, 2024 at 02:56:36PM +0100, Jan Beulich wrote: > All callers only care about boolean outcome. For this there's no point > in allocating a duplicate of the respective DRHD structure; a simple > boolean suffices (which eventually may wantg to become a count, such

[xen-unstable-smoke test] 184627: tolerable all pass - PUSHED

2024-02-08 Thread osstest service owner
flight 184627 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184627/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v2] config: update Mini-OS commit

2024-02-08 Thread Jan Beulich
On 08.02.2024 15:28, Juergen Gross wrote: > Update the Mini-OS upstream revision. > > Signed-off-by: Juergen Gross Acked-by: Jan Beulich

Re: [PATCH 1/7] VT-d: parse ACPI "SoC Integrated Address Translation Cache Reporting Structure"s

2024-02-08 Thread Jan Beulich
On 08.02.2024 10:17, Roger Pau Monné wrote: > On Mon, Feb 05, 2024 at 02:55:17PM +0100, Jan Beulich wrote: >> This is a prereq to us, in particular, respecting the "ATC required" >> flag. >> >> Signed-off-by: Jan Beulich >> --- >> Should we check scope entries for appropriate types? (If so, then

[XEN PATCH v2] docs/misra: add asm-offset.c to exclude-list

2024-02-08 Thread Nicola Vetrini
These files contain several deliberate violations of MISRA C rules and they are not linked in the final Xen binary, therefore they can be exempted from MISRA compliance. No functional change. Signed-off-by: Nicola Vetrini --- Changes in v2: - use a glob to exclude this file for all

Re: [PATCH] x86/HVM: tidy state on hvmemul_map_linear_addr()'s error path

2024-02-08 Thread Paul Durrant
On 08/02/2024 15:59, Jan Beulich wrote: On 06.02.2024 13:06, Jan Beulich wrote: While in the vast majority of cases failure of the function will not be followed by re-invocation with the same emulation context, a few very specific insns - involving multiple independent writes, e.g. ENTER and

[PATCH v5 18/22] tools: add 9pfs device to xenstore-stubdom

2024-02-08 Thread Juergen Gross
Add a 9pfs device to Xenstore stubdom in order to allow it to do e.g. logging into a dom0 file. Use the following parameters for the new device: - tag = "Xen" - type = "xen_9pfsd" - path = "/var/lib/xen/xenstore" - security-model = "none" For now don't limit allowed file space or number of

Re: [PATCH v3 8/8] consolidate do_bug_frame() / bug_fn_t

2024-02-08 Thread Julien Grall
Hi Jan, On 05/02/2024 13:32, Jan Beulich wrote: The type not being used in do_bug_frame() is suspicious. Apparently that's solely because the type uses a pointer-to-const parameter, when so far run_in_exception_handler() wanted functions taking pointer- to-non-const. Expand use of const, in

Re: [PATCH v3 2/8] keyhandler: drop regs parameter from handle_keyregs()

2024-02-08 Thread Julien Grall
Hi Jan, On 05/02/2024 13:28, Jan Beulich wrote: In preparation for further removal of regs parameters, drop it here. In the two places where it's actually needed, retrieve IRQ context if available, or else guest context. Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich --- As an

Re: [PATCH] xen: move BUG_ON(), WARN_ON(), ASSERT(), ASSERT_UNREACHABLE() to xen/bug.h

2024-02-08 Thread Julien Grall
Hi Oleksii, On 02/02/2024 18:03, Oleksii Kurochko wrote: Move the macros mentioned in the commit subject to their appropriate locations. Additionally, eliminate the dependency of xen/lib.h from xen/bug.h and include "xen/bug.h" in files where xen/bug.h macros are utilized. Most of the changes

[ovmf test] 184629: all pass - PUSHED

2024-02-08 Thread osstest service owner
flight 184629 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184629/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e32b58ab5a12d37c82327f28376e7d128b3a baseline version: ovmf

[xen-unstable test] 184626: tolerable FAIL

2024-02-08 Thread osstest service owner
flight 184626 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184626/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 184622

[linux-linus test] 184628: tolerable FAIL - PUSHED

2024-02-08 Thread osstest service owner
flight 184628 linux-linus real [real] flight 184631 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184628/ http://logs.test-lab.xenproject.org/osstest/logs/184631/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-08 Thread Petr Beneš
> On Thu, Feb 8, 2024 at 10:14 AM Christian Lindig > wrote: > > > On 7 Feb 2024, at 22:04, Petr Beneš wrote: > > > > > > Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the > > vm.cfg configuration, correcting an oversight from its initial introduction. > > > >

Re: [PATCH v5 14/22] tools/9pfsd: add 9pfs read request support

2024-02-08 Thread Jason Andryuk
On Thu, Feb 8, 2024 at 11:57 AM Juergen Gross wrote: > > Add the read request of the 9pfs protocol. > > Signed-off-by: Juergen Gross > Reviewed-by: Jason Andryuk > Acked-by: Anthony PERARD > --- > V2: > - make error check more readable (Jason Andryuk) > V4: > - add directory read support > V5:

Re: [XEN PATCH] docs/misra: add x86_64 and arm64 asm-offset.c to exclude-list

2024-02-08 Thread Julien Grall
Hi Nicola, On 08/02/2024 07:55, Nicola Vetrini wrote: These two files contain several deliberate violations of MISRA C rules and they are not linked in the final Xen binary, therefore they can be exempted from MISRA compliance. I am curious, what are the violations you are talking about?

Re: [PATCH v3 1/8] serial: fake IRQ-regs context in poll handlers

2024-02-08 Thread Julien Grall
Hi Jan, On 05/02/2024 13:27, Jan Beulich wrote: In preparation of dropping the register parameters from serial_[rt]x_interrupt() and in turn from IRQ handler functions, register state needs making available another way for the few key handlers which need it. Fake IRQ-like state. Signed-off-by:

Re: [PATCH] xen/serial: Drop serial_{put,get}c

2024-02-08 Thread Stefano Stabellini
On Thu, 8 Feb 2024, Michal Orzel wrote: > After removal of gdbstub by commit d182f9feae6d ("x86: Remove gdbstub"), > we no longer have users of serial_{put,get}c functions, so remove them. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > xen/drivers/char/serial.c | 72

[PATCH] x86/hvm: Fix fast singlestep state persistence

2024-02-08 Thread Petr Beneš
From: Petr Beneš This patch addresses an issue where the fast singlestep setting would persist despite xc_domain_debug_control being called with XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_OFF. Specifically, if fast singlestep was enabled in a VMI session and that session stopped before the MTF trap

Re: [PATCH v5 18/22] tools: add 9pfs device to xenstore-stubdom

2024-02-08 Thread Jason Andryuk
On Thu, Feb 8, 2024 at 12:10 PM Juergen Gross wrote: > > Add a 9pfs device to Xenstore stubdom in order to allow it to do e.g. > logging into a dom0 file. > > Use the following parameters for the new device: > > - tag = "Xen" > - type = "xen_9pfsd" > - path = "/var/lib/xen/xenstore" > -

Re: [PATCH 4/7] VT-d: replace find_ats_dev_drhd()

2024-02-08 Thread Jan Beulich
On 08.02.2024 18:31, Roger Pau Monné wrote: > On Mon, Feb 05, 2024 at 02:56:36PM +0100, Jan Beulich wrote: >> All callers only care about boolean outcome. For this there's no point >> in allocating a duplicate of the respective DRHD structure; a simple >> boolean suffices (which eventually may

Re: [XEN PATCH] docs/misra: add x86_64 and arm64 asm-offset.c to exclude-list

2024-02-08 Thread Nicola Vetrini
Hi Julien, On 2024-02-08 22:33, Julien Grall wrote: Hi Nicola, On 08/02/2024 07:55, Nicola Vetrini wrote: These two files contain several deliberate violations of MISRA C rules and they are not linked in the final Xen binary, therefore they can be exempted from MISRA compliance. I am

Re: [PATCH v2 1/2] x86/p2m: make p2m_get_page_from_gfn() handle grant case correctly

2024-02-08 Thread Jan Beulich
On 08.02.2024 07:32, George Dunlap wrote: > On Thu, Jun 23, 2022 at 7:54 PM Jan Beulich wrote: > >> Grant P2M entries, which are covered by p2m_is_any_ram(), wouldn't pass >> the get_page() unless the grant was a local one. These need to take the >> same path as foreign entries. Just the

Re: [XEN PATCH] docs/misra: add x86_64 and arm64 asm-offset.c to exclude-list

2024-02-08 Thread Jan Beulich
On 08.02.2024 08:55, Nicola Vetrini wrote: > These two files contain several deliberate violations of MISRA C rules and > they are not linked in the final Xen binary, therefore they can be exempted > from MISRA compliance. > > No functional change. > > Signed-off-by: Nicola Vetrini > --- >

Re: [PATCH v2 1/2] x86/p2m: make p2m_get_page_from_gfn() handle grant case correctly

2024-02-08 Thread George Dunlap
On Thu, Feb 8, 2024 at 4:02 PM Jan Beulich wrote: > > On 08.02.2024 07:32, George Dunlap wrote: > > On Thu, Jun 23, 2022 at 7:54 PM Jan Beulich wrote: > > > >> Grant P2M entries, which are covered by p2m_is_any_ram(), wouldn't pass > >> the get_page() unless the grant was a local one. These need