Re: [PATCH] x86+Arm: drop (rename) __virt_to_maddr() / __maddr_to_virt()

2024-03-06 Thread Julien Grall
Hi Jan, On 06/03/2024 09:59, Jan Beulich wrote: On 06.03.2024 10:44, Julien Grall wrote: On 06/03/2024 07:22, Jan Beulich wrote: On 05.03.2024 20:24, Julien Grall wrote: The title is quite confusing. I would have expected the macro... On 05/03/2024 08:33, Jan Beulich wrote: There's no use

Re: [PATCH 1/2] x86/EFI: correct compiler probing

2024-03-06 Thread Jan Beulich
On 06.03.2024 15:57, Anthony PERARD wrote: > On Thu, Dec 07, 2023 at 11:48:12AM +0100, Jan Beulich wrote: >> Passing in $(CFLAGS) means also requesting inclusion of certain headers >> (via -include command line options). That's particularly xen/config.h, >> which in turn requires

Re: [PATCH 2/2] Kbuild: simplify as-insn a little

2024-03-06 Thread Anthony PERARD
On Thu, Dec 07, 2023 at 11:49:04AM +0100, Jan Beulich wrote: > As of 732571959f17 ("xen/build: use new $(c_flags) and $(a_flags) > instead of $(CFLAGS)") -M options aren't part of CFLAGS anymore, and > c_flags isn't supposed to be passed to this macro. Drop the now dead > part of filtering. > >

Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Andrew Cooper
On 06/03/2024 10:49 am, Jan Beulich wrote: > On 06.03.2024 11:33, Andrew Cooper wrote: >> On 05/03/2024 2:04 pm, Jan Beulich wrote: >>> --- a/xen/arch/x86/x86_64/entry.S >>> +++ b/xen/arch/x86/x86_64/entry.S >>> @@ -52,7 +52,7 @@ UNLIKELY_END(syscall_no_callback) >>> movq

[PATCH] x86/asm: add commas to further macros definitions/invocations

2024-03-06 Thread Jan Beulich
In light of recent observations with how macros are handled by gas, let's play by what we informally set for ourselves as a guideline: Use commas to separate parameters/arguments. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- In INDIRECT_{CALL,JMP} adding commas to the arguments

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Christoph Hellwig
I'd still prefer to hide the vm_area, but for now: Reviewed-by: Christoph Hellwig

Re: [PATCH] MAINTAINERS: add an entry for tools/9pfsd

2024-03-06 Thread Jan Beulich
On 06.03.2024 12:16, Juergen Gross wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -206,6 +206,12 @@ Maintainers List (try to look for most precise areas > first) > > --- > > +9PFSD > +M: Juergen Gross > +M: Anthony PERARD > +S:

[xen-unstable-smoke test] 184918: tolerable all pass - PUSHED

2024-03-06 Thread osstest service owner
flight 184918 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184918/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v2 1/2] xen/arm: Add imx8q{m,x} platform glue

2024-03-06 Thread John Ernberg
Hi Michal, On 2/15/24 14:53, John Ernberg wrote: > Hi Michal, > > On 2/15/24 10:02, Michal Orzel wrote: >> Hi, >> >> On 14/02/2024 17:06, John Ernberg wrote: >>> >>> >>> When using Linux for dom0 there are a bunch of drivers that need to >>> do SMC >>> SIP calls into the firmware to enable

[PATCH] CHANGELOG: add an entry for 9pfsd

2024-03-06 Thread Juergen Gross
Add an entry to CHANGELOG.md regarding the new xen-9pfsd daemon. Signed-off-by: Juergen Gross --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f9874f9bb0..93fda73c00 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ The format

[PATCH] MAINTAINERS: add an entry for tools/9pfsd

2024-03-06 Thread Juergen Gross
Add me as the maintainer for the tools/9pfsd directory. Signed-off-by: Juergen Gross --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 076cf1e141..28fb35582b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -206,6 +206,12 @@ Maintainers List

Re: [PATCH] MAINTAINERS: add an entry for tools/9pfsd

2024-03-06 Thread Jürgen Groß
On 06.03.24 12:23, Jan Beulich wrote: On 06.03.2024 12:16, Juergen Gross wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -206,6 +206,12 @@ Maintainers List (try to look for most precise areas first) --- +9PFSD +M: Juergen Gross +M: Anthony

Re: [PATCH 1/2] xen/arm: Add imx8q{m,x} platform glue

2024-03-06 Thread John Ernberg
Hi Julien, On 2/9/24 14:14, John Ernberg wrote: > Hi Julien, > > Apologies for the delay, I was pulled away for a bit. > > On 2/5/24 11:13, Julien Grall wrote: >> Hi, >> >> On 04/02/2024 09:40, Peng Fan wrote: >>> >>> -Original Message- From: Julien Grall Sent: 2024年2月2日

Re: [PATCH v5 11/23] xen/riscv: introduce cmpxchg.h

2024-03-06 Thread Jan Beulich
On 26.02.2024 18:38, Oleksii Kurochko wrote: > The header was taken from Linux kernl 6.4.0-rc1. > > Addionally, were updated: > * add emulation of {cmp}xchg for 1/2 byte types using 32-bit atomic > access. > * replace tabs with spaces > * replace __* variale with *__ > * introduce generic

[linux-linus test] 184917: regressions - FAIL

2024-03-06 Thread osstest service owner
flight 184917 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184917/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-buildfail REGR. vs. 184912 Tests which did

Re: [PATCH v5 13/23] xen/riscv: introduce atomic.h

2024-03-06 Thread Jan Beulich
On 26.02.2024 18:38, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/atomic.h > @@ -0,0 +1,296 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Taken and modified from Linux. > + * > + * The following changes were done: > + * - *

Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Andrew Cooper
On 05/03/2024 2:04 pm, Jan Beulich wrote: > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -52,7 +52,7 @@ UNLIKELY_END(syscall_no_callback) > movq %rax,TRAPBOUNCE_eip(%rdx) > movb %cl,TRAPBOUNCE_flags(%rdx) > call create_bounce_frame > -

[PATCH] SUPPORT.md: add xen-9pfsd

2024-03-06 Thread Juergen Gross
Add a support statement for the new xen-9pfsd backend. Set it to "Experimental", as some functionality for Linux guests is missing (only tested to work with Xenstore-stubdom). Signed-off-by: Juergen Gross --- SUPPORT.md | 1 + 1 file changed, 1 insertion(+) diff --git a/SUPPORT.md b/SUPPORT.md

Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Jan Beulich
On 06.03.2024 12:14, Andrew Cooper wrote: > On 06/03/2024 10:49 am, Jan Beulich wrote: >> On 06.03.2024 11:33, Andrew Cooper wrote: >>> On 05/03/2024 2:04 pm, Jan Beulich wrote: --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -52,7 +52,7 @@

Re: [PATCH 1/2] x86/EFI: correct compiler probing

2024-03-06 Thread Anthony PERARD
On Thu, Dec 07, 2023 at 11:48:12AM +0100, Jan Beulich wrote: > Passing in $(CFLAGS) means also requesting inclusion of certain headers > (via -include command line options). That's particularly xen/config.h, > which in turn requires generated/autoconf.h. This has not caused any > problems so far

Re: [PATCH] x86+Arm: drop (rename) __virt_to_maddr() / __maddr_to_virt()

2024-03-06 Thread Jan Beulich
On 06.03.2024 11:24, Julien Grall wrote: > On 06/03/2024 09:59, Jan Beulich wrote: >> On 06.03.2024 10:44, Julien Grall wrote: >>> On 06/03/2024 07:22, Jan Beulich wrote: On 05.03.2024 20:24, Julien Grall wrote: > The title is quite confusing. I would have expected the macro... >

Re: [PATCH] x86/asm: add commas to further macros definitions/invocations

2024-03-06 Thread Andrew Cooper
On 06/03/2024 11:25 am, Jan Beulich wrote: > In light of recent observations with how macros are handled by gas, > let's play by what we informally set for ourselves as a guideline: Use > commas to separate parameters/arguments. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich > ---

Re: [PATCH] 9pfsd: allow building with old glibc

2024-03-06 Thread Anthony PERARD
On Tue, Mar 05, 2024 at 04:23:23PM +0100, Jürgen Groß wrote: > On 05.03.24 15:33, Jan Beulich wrote: > > Neither pread() / pwrite() nor O_DIRECTORY are available from glibc > > 2.11.3 headers without defining (e.g.) _GNU_SOURCE. Supplying the > > definition unconditionally shouldn't be a problem,

[xen-unstable test] 184914: tolerable FAIL

2024-03-06 Thread osstest service owner
flight 184914 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184914/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 184907 pass in 184914

[PATCH] x86/entry: re-order exception entry points

2024-03-06 Thread Jan Beulich
Arrange for Disp8 JMPs to be usable. On top of the MOVL->MOVB conversion this further reduces entry point size, such that in particular INT3 (for guarding against straight line speculation) would then also still fit within the same 16-byte block, irrespective of CET-IBT being enabled. Of course

Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Jan Beulich
On 06.03.2024 11:33, Andrew Cooper wrote: > On 05/03/2024 2:04 pm, Jan Beulich wrote: >> --- a/xen/arch/x86/x86_64/entry.S >> +++ b/xen/arch/x86/x86_64/entry.S >> @@ -52,7 +52,7 @@ UNLIKELY_END(syscall_no_callback) >> movq %rax,TRAPBOUNCE_eip(%rdx) >> movb

Re: [PATCH] SUPPORT.md: add xen-9pfsd

2024-03-06 Thread Jan Beulich
On 06.03.2024 12:27, Juergen Gross wrote: > Add a support statement for the new xen-9pfsd backend. Set it to > "Experimental", as some functionality for Linux guests is missing > (only tested to work with Xenstore-stubdom). > > Signed-off-by: Juergen Gross Acked-by: Jan Beulich

Re: [PATCH] x86/asm: add commas to BUILD_BUG_ON

2024-03-06 Thread Andrew Cooper
On 06/03/2024 7:34 am, Jan Beulich wrote: > In light of recent observations with how macros are handled by gas, > let's play by what we informally set for ourselves as a guideline: Use > commas to separate parameters/arguments. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper However,

Re: [PATCH v3] tools/xentop: Add VBD3 support to xentop

2024-03-06 Thread Anthony PERARD
On Wed, Feb 28, 2024 at 11:39:47AM +, Fouad Hilly wrote: > From: Pritha Srivastava > > xl now knows how to drive tapdisk, so modify libxenstat to > understand vbd3 statistics. > > Signed-off-by: Pritha Srivastava > Signed-off-by: Jorge Martin > Signed-off-by: Fouad Hilly Reviewed-by:

[PATCH v2] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Jan Beulich
Much like was recently done for setting entry vector, and along the lines of what we already had in handle_exception_saved, avoid 32-bit immediates where 8-bit ones do. Reduces .text.entry size by 16 bytes in my non-CET reference build, while in my CET reference build section size doesn't change

Re: [PATCH v5 12/23] xen/riscv: introduce io.h

2024-03-06 Thread Jan Beulich
On 26.02.2024 18:38, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/io.h > @@ -0,0 +1,157 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * The header taken form Linux 6.4.0-rc1 and is based on > + * arch/riscv/include/asm/mmio.h with the following

[OSSTEST PATCH] ap-common: Switch to Linux 6.1 by default on x86 + drop dom0 i386

2024-03-06 Thread Anthony PERARD
linux-4.19 branch in xenbits is outdated, it haven't been updated and tested since 2020 as it has been disabled in osstest. Also, this 4.19 branch doesn't build on Bookworm. So we will start to use a newer version of Linux. We switch to 6.1 for the Arm* tests recently, so will use that same

[PATCH] x86/entry: don't clear DF when raising #UD for lack of syscall handler

2024-03-06 Thread Jan Beulich
While doing so is intentional when invoking the actual callback, to mimic a hard-coded SYCALL_MASK / FMASK MSR, the same should not be done when no handler is available and hence #UD is raised. Fixes: ca6fcf4321b3 ("x86/pv: Inject #UD for missing SYSCALL callbacks") Reported-by: Andrew Cooper

Re: [PATCH] docs/man: add shutdown reasons to xl (list) man page

2024-03-06 Thread Anthony PERARD
On Tue, Mar 05, 2024 at 11:45:13PM +0100, zithro / Cyril Rébert wrote: > Add the shutdown reasons to the paragraph of "xl list" concerning the > shutdown status. > I have copy/pasted the explanations from the source code : > > - tools/xl/xl_info.c (L379) Instead of a line number, how about the

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Mario Limonciello
On 3/6/2024 12:05, Sébastien Chaumat wrote: Le mer. 6 mars 2024 à 18:33, Mario Limonciello mailto:mario.limoncie...@amd.com>> a écrit : On 3/6/2024 11:28, Sébastien Chaumat wrote: > > > > >     Reasoning backward  (using a  kernel without the pinctrl_amd

Re: [PATCH] docs/man: add shutdown reasons to xl (list) man page

2024-03-06 Thread Roger Pau Monné
On Tue, Mar 05, 2024 at 11:45:13PM +0100, zithro / Cyril Rébert wrote: > Add the shutdown reasons to the paragraph of "xl list" concerning the > shutdown status. > I have copy/pasted the explanations from the source code : > > - tools/xl/xl_info.c (L379) > - xen/include/public/sched.h (starting

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Sébastien Chaumat
Le mer. 6 mars 2024 à 19:08, Mario Limonciello a écrit : > On 3/6/2024 12:05, Sébastien Chaumat wrote: > > > > > > Le mer. 6 mars 2024 à 18:33, Mario Limonciello > > mailto:mario.limoncie...@amd.com>> a écrit : > > > > On 3/6/2024 11:28, Sébastien Chaumat wrote: > > > > > > > >

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Mario Limonciello
On 3/6/2024 12:49, Sébastien Chaumat wrote: Le mer. 6 mars 2024 à 19:08, Mario Limonciello mailto:mario.limoncie...@amd.com>> a écrit : On 3/6/2024 12:05, Sébastien Chaumat wrote: > > > Le mer. 6 mars 2024 à 18:33, Mario Limonciello >

[ANNOUNCE] Call for agenda items for Community Call - 7th March 2024

2024-03-06 Thread Kelly Choi
Hi all, Please add your proposed agenda items below. https://cryptpad.fr/pad/#/2/pad/edit/VlIkjPmILf0abDG3j1Wn0091/ If any action items are missing or have been resolved, please add/remove them from the sheet. *CALL LINK: https://meet.jit.si/XenProjectCommunityCall

Re: [PATCH] CHANGELOG: add an entry for 9pfsd

2024-03-06 Thread Oleksii
Hi Juergen, Looks good to me: Acked-by: Oleksii Kurochko ~ Oleksii On Wed, 2024-03-06 at 12:17 +0100, Juergen Gross wrote: > Add an entry to CHANGELOG.md regarding the new xen-9pfsd daemon. > > Signed-off-by: Juergen Gross > --- >  CHANGELOG.md | 2 ++ >  1 file changed, 2 insertions(+) > >

Re: [PATCH 2/3] xen/virtual-region: Include rodata pointers

2024-03-06 Thread Andrew Cooper
On 06/03/2024 5:09 pm, Ross Lagerwall wrote: > On Tue, Mar 5, 2024 at 2:17 PM Jan Beulich wrote: >> On 05.03.2024 13:11, Andrew Cooper wrote: >>> --- a/xen/include/xen/virtual_region.h >>> +++ b/xen/include/xen/virtual_region.h >>> @@ -16,6 +16,9 @@ struct virtual_region >>> const void

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Sébastien Chaumat
Reasoning backward (using a kernel without the pinctrl_amd driver to > ensure xen only is at stake) : > checking the diff in IOAPIC between bare metal and xen (IRQ7 is on > pin07 on APIC ) > > using kernel argument : apic=debug > > bare metal : > [0.715330] fedora kernel: ... APIC

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Alexei Starovoitov
On Wed, Mar 6, 2024 at 6:19 AM Christoph Hellwig wrote: > > I'd still prefer to hide the vm_area, but for now: > > Reviewed-by: Christoph Hellwig Thank you. I will think of a way to move get_vm_area() to mm/internal.h and propose a plan by lsf/mm/bpf in May.

Re: [RFC PATCH-for-9.0 0/9] hw/xen: Have ARM targets use common xen_memory_listener

2024-03-06 Thread Philippe Mathieu-Daudé
ping ^ 2 On 13/12/23 18:00, Philippe Mathieu-Daudé wrote: ping? On 14/11/23 17:31, Philippe Mathieu-Daudé wrote: Hi, While looking at Xen target-specific code, I noticed some generic code used by x86 which is not implemented for ARM. Maybe ARM machines don't need it, I don't know. But I

Re: [PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable as 'xen_memory'

2024-03-06 Thread Philippe Mathieu-Daudé
On 14/11/23 16:49, David Woodhouse wrote: On 14 November 2023 09:38:06 GMT-05:00, "Philippe Mathieu-Daudé" wrote: To avoid a potential global variable shadow in hw/i386/pc_piix.c::pc_init1(), rename Xen's "ram_memory" as "xen_memory". Signed-off-by: Philippe Mathieu-Daudé Well OK, but

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Sébastien Chaumat
Le mer. 6 mars 2024 à 18:33, Mario Limonciello a écrit : > On 3/6/2024 11:28, Sébastien Chaumat wrote: > > > > > > > > > > Reasoning backward (using a kernel without the pinctrl_amd driver > > to ensure xen only is at stake) : > > checking the diff in IOAPIC between bare metal

Re: [PATCH v4 bpf-next 0/2] mm: Enforce ioremap address space and introduce sparse vm_area

2024-03-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Mon, 4 Mar 2024 19:05:14 -0800 you wrote: > From: Alexei Starovoitov > > v3 -> v4 > - dropped VM_XEN patch for now. It will be in the follow up. > - fixed constant as pointed out by Mike > > v2 -> v3 > -

[LINUX PATCH] RFC: x86/pvh: Make Xen PVH entrypoint PIC

2024-03-06 Thread Jason Andryuk
The Xen PVH entrypoint is 32bit non-PIC code running at a default load address of 0x100 (16MB) (CONFIG_PHYSICAL_START). Xen loads the kernel at that physical address inside the PVH container. When running a PVH Dom0, the system reserved addresses are mapped 1-1 into the PVH container. There

Re: [PATCH 2/3] xen/virtual-region: Include rodata pointers

2024-03-06 Thread Ross Lagerwall
On Tue, Mar 5, 2024 at 2:17 PM Jan Beulich wrote: > > On 05.03.2024 13:11, Andrew Cooper wrote: > > --- a/xen/include/xen/virtual_region.h > > +++ b/xen/include/xen/virtual_region.h > > @@ -16,6 +16,9 @@ struct virtual_region > > const void *text_start;/* .text virtual

[xen-unstable-smoke test] 184920: tolerable all pass - PUSHED

2024-03-06 Thread osstest service owner
flight 184920 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184920/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH 2/3] xen/x86: bzImage parse kernel_alignment

2024-03-06 Thread Jason Andryuk
Expand bzimage_parse() to return kernel_alignment from the setup_header. This will be needed if loading a PVH kernel at a physical offset to compensate for a reserved E820 region. Signed-off-by: Jason Andryuk --- xen/arch/x86/bzimage.c | 4 +++- xen/arch/x86/hvm/dom0_build.c |

[PATCH 0/3] x86/pvh: Support relocating dom0 kernel

2024-03-06 Thread Jason Andryuk
Xen tries to load a PVH dom0 kernel at the fixed guest physical address from the elf headers. For Linux, this defaults to 0x100 (16MB), but it can be configured. Unfortunately there exist firmwares that have reserved regions at this address, so Xen fails to load the dom0 kernel since it's

[PATCH 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-06 Thread Jason Andryuk
Xen tries to load a PVH dom0 kernel at the fixed guest physical address from the elf headers. For Linux, this defaults to 0x100 (16MB), but it can be configured. Unfortunately there exist firmwares that have reserved regions at this address, so Xen fails to load the dom0 kernel since it's

[PATCH 1/3] features.h: Replace hard tabs

2024-03-06 Thread Jason Andryuk
Replace hard tabs to match the rest of the file. Fixes: 48a3fd1432 ("domain: expose newly introduced hypercalls as XENFEAT") Signed-off-by: Jason Andryuk --- xen/include/public/features.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/public/features.h

[RFC PATCH] tools/libxl: force running dm when device_model_args set

2024-03-06 Thread Alex Bennée
When device_model_args is set we almost certainly want to spawn the device model. This is most useful when debugging with QEMU and you want to specify a new device type for testing without teaching libxl about the device itself. Signed-off-by: Alex Bennée --- This is very much an RFC, it's

[RFC PATCH v2] xen/arm: improve handling of load/store instruction decoding

2024-03-06 Thread Alex Bennée
While debugging VirtIO on Arm we ran into a warning due to memory being memcpy'd across MMIO space. While the bug was in the mappings the warning was a little confusing: (XEN) d47v2 Rn should not be equal to Rt except for r31 (XEN) d47v2 unhandled Arm instruction 0x3d80 (XEN) d47v2

Re: [RFC PATCH-for-9.0 v2 13/19] hw/xen: Remove use of 'target_ulong' in handle_ioreq()

2024-03-06 Thread Philippe Mathieu-Daudé
Cc'ing Anton. On 14/11/23 15:38, Philippe Mathieu-Daudé wrote: Per commit f17068c1c7 ("xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common"), handle_ioreq() is expected to be target-agnostic. However it uses 'target_ulong', which is a target specific definition. Per

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Mario Limonciello
On 3/6/2024 11:28, Sébastien Chaumat wrote: Reasoning backward  (using a  kernel without the pinctrl_amd driver to ensure xen only is at stake) :  checking the diff in IOAPIC  between bare metal and xen  (IRQ7 is on pin07 on APIC ) using kernel argument : apic=debug

Re: [PATCH v2 1/1] x86/fred: Fix init_task thread stack pointer initialization

2024-03-06 Thread Xin Li
On 3/4/2024 12:33 AM, Xin Li (Intel) wrote: As TOP_OF_KERNEL_STACK_PADDING is defined as 0 on x86_64, no one noticed it's missing in the calculation of the .sp field in INIT_THREAD until it is defined to 16 with CONFIG_X86_FRED=y. Subtract TOP_OF_KERNEL_STACK_PADDING from the .sp field of

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Alexei Starovoitov
On Wed, Mar 6, 2024 at 1:04 PM Pasha Tatashin wrote: > > On Mon, Mar 4, 2024 at 10:05 PM Alexei Starovoitov > wrote: > > > > From: Alexei Starovoitov > > > > vmap/vmalloc APIs are used to map a set of pages into contiguous kernel > > virtual space. > > > > get_vm_area() with appropriate flag is

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Pasha Tatashin
On Mon, Mar 4, 2024 at 10:05 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > vmap/vmalloc APIs are used to map a set of pages into contiguous kernel > virtual space. > > get_vm_area() with appropriate flag is used to request an area of kernel > address range. It's used for vmalloc,

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Alexei Starovoitov
On Wed, Mar 6, 2024 at 2:57 PM Pasha Tatashin wrote: > > On Wed, Mar 6, 2024 at 5:13 PM Alexei Starovoitov > wrote: > > > > On Wed, Mar 6, 2024 at 1:46 PM Pasha Tatashin > > wrote: > > > > > > > > This interface and in general VM_SPARSE would be useful for > > > > > dynamically grown kernel

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Sébastien Chaumat
Le mer. 6 mars 2024 à 19:51, Mario Limonciello a écrit : > On 3/6/2024 12:49, Sébastien Chaumat wrote: > > > > > > Le mer. 6 mars 2024 à 19:08, Mario Limonciello > > mailto:mario.limoncie...@amd.com>> a écrit : > > > > On 3/6/2024 12:05, Sébastien Chaumat wrote: > > > > > > > >

[xen-unstable test] 184919: tolerable FAIL - PUSHED

2024-03-06 Thread osstest service owner
flight 184919 xen-unstable real [real] flight 184926 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184919/ http://logs.test-lab.xenproject.org/osstest/logs/184926/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH 1/3] features.h: Replace hard tabs

2024-03-06 Thread Stefano Stabellini
On Wed, 6 Mar 2024, Jason Andryuk wrote: > Replace hard tabs to match the rest of the file. > > Fixes: 48a3fd1432 ("domain: expose newly introduced hypercalls as XENFEAT") > Signed-off-by: Jason Andryuk Reviewed-by: Stefano Stabellini

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Pasha Tatashin
> > This interface and in general VM_SPARSE would be useful for > > dynamically grown kernel stacks [1]. However, the might_sleep() here > > would be a problem. We would need to be able to handle > > vm_area_map_pages() from interrupt disabled context therefore no > > sleeping. The caller would

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Pasha Tatashin
On Wed, Mar 6, 2024 at 5:13 PM Alexei Starovoitov wrote: > > On Wed, Mar 6, 2024 at 1:46 PM Pasha Tatashin > wrote: > > > > > > This interface and in general VM_SPARSE would be useful for > > > > dynamically grown kernel stacks [1]. However, the might_sleep() here > > > > would be a problem. We

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Mario Limonciello
On 3/6/2024 14:34, Sébastien Chaumat wrote: Le mer. 6 mars 2024 à 19:51, Mario Limonciello mailto:mario.limoncie...@amd.com>> a écrit : On 3/6/2024 12:49, Sébastien Chaumat wrote: > > > Le mer. 6 mars 2024 à 19:08, Mario Limonciello >

Re: [PATCH v2 1/1] x86/fred: Fix init_task thread stack pointer initialization

2024-03-06 Thread H. Peter Anvin
On March 6, 2024 10:28:25 AM PST, Xin Li wrote: >On 3/4/2024 12:33 AM, Xin Li (Intel) wrote: >> As TOP_OF_KERNEL_STACK_PADDING is defined as 0 on x86_64, no one noticed >> it's missing in the calculation of the .sp field in INIT_THREAD until it >> is defined to 16 with CONFIG_X86_FRED=y. >> >>

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Alexei Starovoitov
On Wed, Mar 6, 2024 at 1:46 PM Pasha Tatashin wrote: > > > > This interface and in general VM_SPARSE would be useful for > > > dynamically grown kernel stacks [1]. However, the might_sleep() here > > > would be a problem. We would need to be able to handle > > > vm_area_map_pages() from interrupt

Re: [PATCH 1/2] xen/arm: Add imx8q{m,x} platform glue

2024-03-06 Thread Julien Grall
Hi John, > Ping on the watchdog discussion bits. Sorry for the late reply. On 06/03/2024 13:13, John Ernberg wrote: On 2/9/24 14:14, John Ernberg wrote:    * IMX_SIP_TIMER_*:  This seems to be related to the watchdog. Shouldn't dom0 rely on the watchdog provided by Xen instead? So those

Re: [PATCH v2] Argo: don't obtain excess page references

2024-03-06 Thread Christopher Clark
On Sun, Feb 18, 2024 at 10:01 AM Julien Grall wrote: > > Hi Jan, > > On 14/02/2024 10:12, Jan Beulich wrote: > > find_ring_mfn() already holds a page reference when trying to obtain a > > writable type reference. We shouldn't make assumptions on the general > > reference count limit being

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Marek Marczykowski-Górecki
On Wed, Mar 06, 2024 at 02:37:20PM -0600, Mario Limonciello wrote: > On 3/6/2024 14:34, Sébastien Chaumat wrote: > > > > > > Le mer. 6 mars 2024 à 19:51, Mario Limonciello > > mailto:mario.limoncie...@amd.com>> a écrit : > > > > On 3/6/2024 12:49, Sébastien Chaumat wrote: > > > > >

Re: Xen 4.18rc/ARM64 on Raspberry Pi 4B: Traffic in DomU crashing Dom0 when using VLANs

2024-03-06 Thread Paul Leiber
Hi Julien Am 04.03.2024 um 23:15 schrieb Julien Grall: Hi Paul, On 01/03/2024 19:37, Paul Leiber wrote: Stopping xen-watchdog prevents the reboot. However, when triggering traffic on the VLAN, Dom0 and DomU become completely unresponsive. No error or kernel message is printed in the serial

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-03-06 Thread Mario Limonciello
On 3/6/2024 15:31, Marek Marczykowski-Górecki wrote: On Wed, Mar 06, 2024 at 02:37:20PM -0600, Mario Limonciello wrote: On 3/6/2024 14:34, Sébastien Chaumat wrote: Le mer. 6 mars 2024 à 19:51, Mario Limonciello mailto:mario.limoncie...@amd.com>> a écrit : On 3/6/2024 12:49, Sébastien

Re: Ping: [PATCH v2] Argo: don't obtain excess page references

2024-03-06 Thread Christopher Clark
On Wed, Feb 28, 2024 at 6:52 AM Jan Beulich wrote: > > On 18.02.2024 19:01, Julien Grall wrote: > > On 14/02/2024 10:12, Jan Beulich wrote: > >> find_ring_mfn() already holds a page reference when trying to obtain a > >> writable type reference. We shouldn't make assumptions on the general > >>

Re: [PATCH v4 bpf-next 2/2] mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages().

2024-03-06 Thread Pasha Tatashin
On Mon, Mar 4, 2024 at 10:05 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > vmap/vmalloc APIs are used to map a set of pages into contiguous kernel > virtual space. > > get_vm_area() with appropriate flag is used to request an area of kernel > address range. It's used for vmalloc,

Re: [XEN PATCH 10/10] xen/keyhandler: address violations of MISRA C Rule 20.7

2024-03-06 Thread Stefano Stabellini
On Tue, 5 Mar 2024, Jan Beulich wrote: > On 05.03.2024 03:03, Stefano Stabellini wrote: > > On Mon, 4 Mar 2024, Jan Beulich wrote: > >> On 02.03.2024 02:37, Stefano Stabellini wrote: > >>> On Fri, 1 Mar 2024, Jan Beulich wrote: > On 29.02.2024 23:57, Stefano Stabellini wrote: > > On Thu,

Re: [PATCH 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-06 Thread Stefano Stabellini
On Wed, 6 Mar 2024, Jason Andryuk wrote: > Xen tries to load a PVH dom0 kernel at the fixed guest physical address > from the elf headers. For Linux, this defaults to 0x100 (16MB), but > it can be configured. > > Unfortunately there exist firmwares that have reserved regions at this >

Re: [PATCH 2/3] xen/x86: bzImage parse kernel_alignment

2024-03-06 Thread Stefano Stabellini
On Wed, 6 Mar 2024, Jason Andryuk wrote: > Expand bzimage_parse() to return kernel_alignment from the setup_header. > This will be needed if loading a PVH kernel at a physical offset to > compensate for a reserved E820 region. > > Signed-off-by: Jason Andryuk Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 06/10] arm/smmu: address some violations of MISRA C Rule 20.7

2024-03-06 Thread Stefano Stabellini
On Thu, 29 Feb 2024, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

[PATCH] tools/9pfsd: Fix build error caused by strerror_r

2024-03-06 Thread Henry Wang
Below error can be seen when doing Yocto build of the toolstack: | io.c: In function 'p9_error': | io.c:684:5: error: ignoring return value of 'strerror_r' declared with attribute 'warn_unused_result' [-Werror=unused-result] | 684 | strerror_r(err, ring->buffer, ring->ring_size); |

Re: [PATCH] tools/9pfsd: Fix build error caused by strerror_r

2024-03-06 Thread Jan Beulich
On 07.03.2024 06:54, Henry Wang wrote: > Below error can be seen when doing Yocto build of the toolstack: > > | io.c: In function 'p9_error': > | io.c:684:5: error: ignoring return value of 'strerror_r' declared > with attribute 'warn_unused_result' [-Werror=unused-result] > | 684 |

Re: [PATCH RFC] x86/xen: attempt to inflate the memory balloon on PVH

2024-03-06 Thread Stefano Stabellini
On Tue, 5 Mar 2024, Roger Pau Monné wrote: > On Thu, Feb 22, 2024 at 05:16:09PM -0800, Stefano Stabellini wrote: > > On Tue, 20 Feb 2024, Roger Pau Monne wrote: > > > When running as PVH or HVM Linux will use holes in the memory map as > > > scratch > > > space to map grants, foreign domain pages

[linux-5.4 test] 184921: tolerable FAIL - PUSHED

2024-03-06 Thread osstest service owner
flight 184921 linux-5.4 real [real] flight 184928 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184921/ http://logs.test-lab.xenproject.org/osstest/logs/184928/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [XEN PATCH 10/10] xen/keyhandler: address violations of MISRA C Rule 20.7

2024-03-06 Thread Jan Beulich
On 07.03.2024 02:39, Stefano Stabellini wrote: > On Tue, 5 Mar 2024, Jan Beulich wrote: >> On 05.03.2024 03:03, Stefano Stabellini wrote: >>> On Mon, 4 Mar 2024, Jan Beulich wrote: On 02.03.2024 02:37, Stefano Stabellini wrote: > On Fri, 1 Mar 2024, Jan Beulich wrote: >> On 29.02.2024

Re: [PATCH 2/3] xen/virtual-region: Include rodata pointers

2024-03-06 Thread Jan Beulich
On 06.03.2024 18:21, Andrew Cooper wrote: > On 06/03/2024 5:09 pm, Ross Lagerwall wrote: >> On Tue, Mar 5, 2024 at 2:17 PM Jan Beulich wrote: >>> On 05.03.2024 13:11, Andrew Cooper wrote: --- a/xen/include/xen/virtual_region.h +++ b/xen/include/xen/virtual_region.h @@ -16,6 +16,9

[linux-linus test] 184912: tolerable FAIL - PUSHED

2024-03-06 Thread osstest service owner
flight 184912 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184912/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 184886 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH] xen/blkback: use kmap_local_page()

2024-03-06 Thread Roger Pau Monné
On Wed, Mar 06, 2024 at 01:15:48PM +0800, flyingpeng...@gmail.com wrote: > From: Peng Hao > > From: Peng Hao > > Use kmap_local_page() instead of kmap_atomic() which has been > deprecated. > > Signed-off-by: Peng Hao > --- > drivers/block/xen-blkback/blkback.c | 4 ++-- > 1 file changed, 2

Re: [PATCH] SUPPORT.md: clarify support of booting 32-bit Xen on ARMv8

2024-03-06 Thread Julien Grall
On 29/02/2024 21:07, Stefano Stabellini wrote: On Thu, 29 Feb 2024, Michal Orzel wrote: On 29/02/2024 13:40, Julien Grall wrote: On 29/02/2024 12:37, Michal Orzel wrote: Hi Julien, Hi Michal, On 29/02/2024 13:35, Julien Grall wrote: On 29/02/2024 12:13, Michal Orzel wrote: Since

Re: [PATCH] x86+Arm: drop (rename) __virt_to_maddr() / __maddr_to_virt()

2024-03-06 Thread Julien Grall
Hi Jan, On 06/03/2024 07:22, Jan Beulich wrote: On 05.03.2024 20:24, Julien Grall wrote: Hi Jan, The title is quite confusing. I would have expected the macro... On 05/03/2024 08:33, Jan Beulich wrote: There's no use of them anymore except in the definitions of the non- underscore-prefixed

Re: [PATCH] x86+Arm: drop (rename) __virt_to_maddr() / __maddr_to_virt()

2024-03-06 Thread Jan Beulich
On 06.03.2024 10:44, Julien Grall wrote: > On 06/03/2024 07:22, Jan Beulich wrote: >> On 05.03.2024 20:24, Julien Grall wrote: >>> The title is quite confusing. I would have expected the macro... >>> >>> On 05/03/2024 08:33, Jan Beulich wrote: There's no use of them anymore except in the

Re: Xen 4.19 release status tracking list [ March ]

2024-03-06 Thread Ayan Kumar Halder
On 01/03/2024 17:21, Oleksii wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Hello everyone, Hi Oleksii, Greetings I would like to share with you a list