Re: [XEN PATCH v2 5/5] xen/arm: ffa: support notification

2024-04-24 Thread Bertrand Marquis
Hi Jens, > On 23 Apr 2024, at 17:26, Jens Wiklander wrote: > > Hi Julien, > > On Mon, Apr 22, 2024 at 1:40 PM Julien Grall wrote: >> >> Hi Jens, >> >> This is not a full review of the code. I will let Bertrand doing it. >> >> On 22/04/2024 08:37, Jens Wiklander wrote: >>> +void

Re: [PATCH 6/6] x86/spec-ctrl: Introduce and use DO_COND_BHB_SEQ

2024-04-24 Thread Jan Beulich
On 22.04.2024 20:14, Andrew Cooper wrote: > --- a/xen/arch/x86/hvm/vmx/entry.S > +++ b/xen/arch/x86/hvm/vmx/entry.S > @@ -62,12 +62,12 @@ ENTRY(vmx_asm_vmexit_handler) > * Clear the BHB to mitigate BHI. Used on eIBRS parts, and uses RETs > * itself so must be after we've

Re: [XEN PATCH 02/10] xen/page-defs: address violation of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 05/10] xen/spinlock: address violations of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 06/10] x86/pci: address violation of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 07/10] x86/acpi: power: address violations of MISRA Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 10/10] x86/mm: address violations of MISRA C Rule 20.7

2024-04-24 Thread Jan Beulich
On 23.04.2024 17:12, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Jan Beulich
On 24.04.2024 09:37, Federico Serafini wrote: > On 23/04/24 18:06, Jan Beulich wrote: >> On 23.04.2024 17:52, Federico Serafini wrote: >>> On 23/04/24 12:26, Jan Beulich wrote: On 23.04.2024 12:02, Federico Serafini wrote: > + > + * - R16.4 > + - A switch statement with a

[XEN PATCH v2] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Federico Serafini
Update ECLAIR configuration to take into account the deviations agreed during MISRA meetings for Rule 16.4. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 docs/misra/deviations.rst| 13 + 2 files changed,

Re: [XEN PATCH v2] automation/eclair: add deviations for MISRA C:2012 Rule 16.4

2024-04-24 Thread Jan Beulich
On 24.04.2024 10:25, Federico Serafini wrote: > Update ECLAIR configuration to take into account the deviations > agreed during MISRA meetings for Rule 16.4. > > Signed-off-by: Federico Serafini > --- > automation/eclair_analysis/ECLAIR/deviations.ecl | 8 > docs/misra/deviations.rst

<    1   2