[xen-unstable-smoke test] 184260: tolerable all pass - PUSHED

2024-01-05 Thread osstest service owner
flight 184260 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184260/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

xen | Successful pipeline for staging | 5a3ace21

2024-01-05 Thread GitLab
Pipeline #1128952078 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 5a3ace21 ( https://gitlab.com/xen-project/xen/-/commit/5a3ace21f3d779b291a2d305824b2820d88de7f1 ) Commit Message: xen/arm:

[linux-linus test] 184258: trouble: broken/fail/pass

2024-01-05 Thread osstest service owner
flight 184258 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184258/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: > > Some type of domain don't have PIRQ, like PVH, current > > implementation is not suitable for those domain. > > > > When passthrough a device to guest on PVH dom0, this > >

Re: [RFC XEN PATCH v4 5/5] libxl: Use gsi instead of irq for mapping pirq

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Jiqian Chen wrote: > In PVH dom0, it uses the linux local interrupt mechanism, > when it allocs irq for a gsi, it is dynamic, and follow > the principle of applying first, distributing first. And > the irq number is alloced from small to large, but the > applying gsi number is

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Jiqian Chen wrote: > Some type of domain don't have PIRQ, like PVH, current > implementation is not suitable for those domain. > > When passthrough a device to guest on PVH dom0, this > pci_add_dm_done->XEN_DOMCTL_irq_permission will failed > at domain_pirq_to_irq. > > So,

Re: [RFC XEN PATCH v4 3/5] x86/pvh: Add PHYSDEVOP_setup_gsi for PVH dom0

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Jiqian Chen wrote: > On PVH dom0, the gsis don't get registered, but > the gsi of a passthrough device must be configured for it to > be able to be mapped into a hvm domU. > On Linux kernel side, it calles PHYSDEVOP_setup_gsi for > passthrough devices to register gsi when dom0

Re: [RFC XEN PATCH v4 2/5] x86/pvh: Allow (un)map_pirq when caller isn't DOMID_SELF

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Jiqian Chen wrote: > If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > a passthrough device by using gsi, see > xen_pt_realize->xc_physdev_map_pirq and > pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq > will call into Xen, but in hvm_physdev_op,

[ovmf test] 184259: all pass - PUSHED

2024-01-05 Thread osstest service owner
flight 184259 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184259/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9cf1d03ebe076b3e3825dfebbc19fd6b52b5f336 baseline version: ovmf

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Federico Serafini wrote: > Hello everyone, > > On 21/12/23 13:41, Jan Beulich wrote: > > On 21.12.2023 13:01, Nicola Vetrini wrote: > > > Hi Andrew, > > > > > > On 2023-12-21 12:03, Andrew Cooper wrote: > > > > On 21/12/2023 10:58 am, Jan Beulich wrote: > > > > > On

Re: [PATCH] x86/mwait-idle: fix ubsan warning

2024-01-05 Thread Andrew Cooper
On 05/01/2024 4:09 pm, Tamas K Lengyel wrote: > On Fri, Jan 5, 2024 at 2:34 AM Jan Beulich wrote: >> On 04.01.2024 18:13, Tamas K Lengyel wrote: >>> Fix warning: >>> (XEN) UBSAN: Undefined behaviour in arch/x86/cpu/mwait-idle.c:1300:44 >>> (XEN) left shift of 15 by 28 places cannot be represented

Re: [PATCH v6 8/9] xen/asm-generic: ifdef inclusion of

2024-01-05 Thread Shawn Anastasio
Hi Oleksii, On 12/20/23 8:08 AM, Oleksii Kurochko wrote: > ifdefing inclusion of in > allows to avoid generation of empty header > for the case when !CONFIG_MEM_ACCESS. > > For Arm it was explicitly added inclusion of for p2m.c > and traps.c because they require some functions from which >

Re: [PATCH v5 13/13] xen/arm: add cache coloring support for Xen

2024-01-05 Thread Julien Grall
Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: This commit adds the cache coloring support for Xen own physical space. It extends the implementation of setup_pagetables() to make use of Xen cache coloring configuration. Page tables construction is essentially the same except for the fact

Re: [PATCH v6 7/9] xen: ifdef inclusion of in

2024-01-05 Thread Shawn Anastasio
Hi Oleksii, On 12/20/23 8:08 AM, Oleksii Kurochko wrote: > Ifdef-ing inclusion of allows to avoid > generation of empty for cases when > CONFIG_GRANT_TABLE is not enabled. > > The following changes were done for Arm: > should be included directly because it contains > gnttab_dom0_frames()

Re: [PATCH v3 07/34] xen/asm-generic: introdure nospec.h

2024-01-05 Thread Shawn Anastasio
Hi Oleksii, On 12/22/23 9:12 AM, Oleksii Kurochko wrote: > The header is similar between Arm, PPC, and RISC-V, > so it has been moved to asm-generic. > > Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v5 11/13] Revert "xen/arm: Remove unused BOOT_RELOC_VIRT_START"

2024-01-05 Thread Julien Grall
Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: This reverts commit 0c18fb76323bfb13615b6f13c98767face2d8097 (not clean). This is not a clean revert since the rework of the memory layout, but it is sufficiently similar to a clean one. The only difference is that the BOOT_RELOC_VIRT_START

Re: [PATCH v5 12/13] xen/arm: add Xen cache colors command line parameter

2024-01-05 Thread Julien Grall
Hi, On 02/01/2024 09:51, Carlo Nonato wrote: From: Luca Miccio This commit adds a new command line parameter to configure Xen cache colors. These colors can be dumped with the cache coloring info debug-key. By default, Xen uses the first color. Benchmarking the VM interrupt response time

Re: [PATCH v5 10/13] xen/arm: use domain memory to allocate p2m page tables

2024-01-05 Thread Julien Grall
Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: Cache colored domains can benefit from having p2m page tables allocated with the same coloring schema so that isolation can be achieved also for those kind of memory accesses. In order to do that, the domain struct is passed to the allocator

Re: [PATCH v5 03/13] xen/arm: add Dom0 cache coloring support

2024-01-05 Thread Julien Grall
On 05/01/2024 16:52, Carlo Nonato wrote: Hi Julien, On Thu, Jan 4, 2024 at 8:54 PM Julien Grall wrote: Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: This commit allows the user to set the cache coloring configuration for Dom0 via a command line parameter. Since cache coloring and

Re: [PATCH v5 02/13] xen/arm: add cache coloring initialization

2024-01-05 Thread Julien Grall
Hi Carlo, On 05/01/2024 16:34, Carlo Nonato wrote: On Thu, Jan 4, 2024 at 8:25 PM Julien Grall wrote: Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: This commit implements functions declared in the LLC coloring common header for arm64 and adds documentation. It also adds two command

Re: [PATCH v5 06/13] xen/arm: add support for cache coloring configuration via device-tree

2024-01-05 Thread Julien Grall
Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: This commit adds the "llc-colors" Device Tree attribute that can be used for DomUs and Dom0less color configurations. The syntax is the same used for every color config. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato

Re: [PATCH v5 04/13] xen: extend domctl interface for cache coloring

2024-01-05 Thread Julien Grall
Hi Carlo, On 02/01/2024 09:51, Carlo Nonato wrote: This commit updates the domctl interface to allow the user to set cache coloring configurations from the toolstack. It also implements the functionality for arm64. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato

Re: [PATCH v5 03/13] xen/arm: add Dom0 cache coloring support

2024-01-05 Thread Carlo Nonato
Hi Julien, On Thu, Jan 4, 2024 at 8:54 PM Julien Grall wrote: > > Hi Carlo, > > On 02/01/2024 09:51, Carlo Nonato wrote: > > This commit allows the user to set the cache coloring configuration for > > Dom0 via a command line parameter. > > Since cache coloring and static memory are incompatible,

Re: [PATCH v5 02/13] xen/arm: add cache coloring initialization

2024-01-05 Thread Carlo Nonato
Hi Julien, On Thu, Jan 4, 2024 at 8:25 PM Julien Grall wrote: > > Hi Carlo, > > On 02/01/2024 09:51, Carlo Nonato wrote: > > This commit implements functions declared in the LLC coloring common header > > for arm64 and adds documentation. It also adds two command line options: a > > runtime

Re: [PATCH v5 01/13] xen/common: add cache coloring common code

2024-01-05 Thread Carlo Nonato
Hi Stefano, Julien, On Thu, Jan 4, 2024 at 10:43 PM Stefano Stabellini wrote: > > On Thu, 4 Jan 2024, Julien Grall wrote: > > Hi, > > > > On 02/01/2024 09:51, Carlo Nonato wrote: > > > This commit adds the Last Level Cache (LLC) coloring common header, > > > Kconfig > > > options and functions.

[linux-linus test] 184256: tolerable FAIL - PUSHED

2024-01-05 Thread osstest service owner
flight 184256 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184256/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 184252 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [XEN RFC] x86/uaccess: remove __{put,get}_user_bad()

2024-01-05 Thread Federico Serafini
Hello everyone, On 21/12/23 13:41, Jan Beulich wrote: On 21.12.2023 13:01, Nicola Vetrini wrote: Hi Andrew, On 2023-12-21 12:03, Andrew Cooper wrote: On 21/12/2023 10:58 am, Jan Beulich wrote: On 21.12.2023 11:53, Federico Serafini wrote: Remove declarations of __put_user_bad() and

Re: [PATCH v6 02/11] virtio-gpu: Configure new feature flag context_create_with_flags for virglrenderer

2024-01-05 Thread Alex Bennée
Huang Rui writes: > Configure a new feature flag (context_create_with_flags) for > virglrenderer. > > Originally-by: Antonio Caggiano > Signed-off-by: Huang Rui Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] x86/mwait-idle: fix ubsan warning

2024-01-05 Thread Tamas K Lengyel
On Fri, Jan 5, 2024 at 2:34 AM Jan Beulich wrote: > > On 04.01.2024 18:13, Tamas K Lengyel wrote: > > Fix warning: > > (XEN) UBSAN: Undefined behaviour in arch/x86/cpu/mwait-idle.c:1300:44 > > (XEN) left shift of 15 by 28 places cannot be represented in type 'int' > > > > Signed-off-by: Tamas K

Re: [PATCH v6 11/11] virtio-gpu: make blob scanout use dmabuf fd

2024-01-05 Thread Alex Bennée
Alex Bennée writes: > Huang Rui writes: > >> From: Robert Beckett >> >> This relies on a virglrenderer change to include the dmabuf fd when >> returning resource info. >> > >> +static void virgl_cmd_set_scanout_blob(VirtIOGPU *g, >> + struct

Re: [PATCH v3 03/33] tools: add a new xen logging daemon

2024-01-05 Thread Andrew Cooper
Subject s/logging/9pfs/ On 04/01/2024 9:00 am, Juergen Gross wrote: > diff --git a/tools/xen-9pfsd/xen-9pfsd.c b/tools/xen-9pfsd/xen-9pfsd.c > new file mode 100644 > index 00..22cfff0c4e > --- /dev/null > +++ b/tools/xen-9pfsd/xen-9pfsd.c > @@ -0,0 +1,145 @@ > +/* SPDX-License-Identifier:

Re: [PATCH] xen/livepatch: Make check_for_livepatch_work() faster in the common case

2024-01-05 Thread Ross Lagerwall
On Fri, Dec 22, 2023 at 10:01 PM Andrew Cooper wrote: > > When livepatching is enabled, this function is used all the time. Really do > check the fastpath first, and annotate it likely() as this is the right answer > 100% of the time (to many significant figures). > > This cuts out 3 pointer

Re: [PATCH v3 01/33] tools: add access macros for unaligned data

2024-01-05 Thread Andrew Cooper
On 04/01/2024 9:00 am, Juergen Gross wrote: > Add the basic access macros for unaligned data to common-macros.h. > > Signed-off-by: Juergen Gross Acked-by: Andrew Cooper

Re: [PATCH v3 00/33] tools: enable xenstore-stubdom to use 9pfs

2024-01-05 Thread Andrew Cooper
On 04/01/2024 9:00 am, Juergen Gross wrote: > tools: add a new xen logging daemon > tools/xenlogd: connect to frontend > tools/xenlogd: add transport layer > tools/xenlogd: add 9pfs response generation support > tools/xenlogd: add 9pfs version request support > tools/xenlogd: add 9pfs

Re: [XEN PATCH 7/7] xen/arm: smmu-v3: address violations of MISRA C:2012 Rule 16.3

2024-01-05 Thread Bertrand Marquis
Hi Frederico, Sorry to have missed that one. > On 20 Dec 2023, at 12:03, Federico Serafini > wrote: > > Add a break statement at the end of the switch-clauses to address > violations of MISRA C:2012 Rule 16.3 ("An unconditional `break' > statement shall terminate every switch-clause"). > No

Re: [XEN PATCH 7/7] xen/arm: smmu-v3: address violations of MISRA C:2012 Rule 16.3

2024-01-05 Thread Julien Grall
Hi, On 05/01/2024 15:04, Federico Serafini wrote: On 20/12/23 12:49, Julien Grall wrote: Hi Federico, On 20/12/2023 11:03, Federico Serafini wrote: Add a break statement at the end of the switch-clauses to address violations of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement

Re: [PATCH v3 07/33] tools/xenlogd: add 9pfs version request support

2024-01-05 Thread Jason Andryuk
On Thu, Jan 4, 2024 at 4:01 AM Juergen Gross wrote: > > Add the version request of the 9pfs protocol. For the version use the > "9P2000.u" variant, as it is supported by Mini-OS and Linux. > > For the request parsing add all format items needed even in future in > order to avoid code churn for

Re: [PATCH v3 06/33] tools/xenlogd: add 9pfs response generation support

2024-01-05 Thread Jason Andryuk
On Thu, Jan 4, 2024 at 4:01 AM Juergen Gross wrote: > > Add support for generation a 9pfs protocol response via a format based > approach. > > Strings are stored in a per device string buffer and they are > referenced via their offset in this buffer. This allows to avoid > having to dynamically

Re: [PATCH v3 04/33] tools/xenlogd: connect to frontend

2024-01-05 Thread Jason Andryuk
On Thu, Jan 4, 2024 at 5:12 AM Juergen Gross wrote: > > Add the code for connecting to frontends to xenlogd. > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk

Re: [XEN PATCH 7/7] xen/arm: smmu-v3: address violations of MISRA C:2012 Rule 16.3

2024-01-05 Thread Federico Serafini
Hi Julien, On 20/12/23 12:49, Julien Grall wrote: Hi Federico, On 20/12/2023 11:03, Federico Serafini wrote: Add a break statement at the end of the switch-clauses to address violations of MISRA C:2012 Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No

Re: [PATCH v6 11/11] virtio-gpu: make blob scanout use dmabuf fd

2024-01-05 Thread Alex Bennée
Huang Rui writes: > From: Robert Beckett > > This relies on a virglrenderer change to include the dmabuf fd when > returning resource info. > > +static void virgl_cmd_set_scanout_blob(VirtIOGPU *g, > + struct virtio_gpu_ctrl_command *cmd) > +{ > +

Re: [PATCH] xen: Use -Wuninitialized and -Winit-self

2024-01-05 Thread Roberto Bagnara
On 2024-01-05 07:56, Jan Beulich wrote: On 04.01.2024 21:43, Roberto Bagnara wrote: On 2024-01-04 15:33, Andrew Cooper wrote: On 04/01/2024 1:41 pm, Jan Beulich wrote: On 28.12.2023 20:39, Andrew Cooper wrote: The use of uninitialised data is undefined behaviour. At -O2 with trivial

[libvirt test] 184255: tolerable all pass - PUSHED

2024-01-05 Thread osstest service owner
flight 184255 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/184255/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184250 test-armhf-armhf-libvirt-qcow2 15

[XEN v3 2/3] xen/arm: arm64: Add emulation of Debug Data Transfer Registers

2024-01-05 Thread Ayan Kumar Halder
From: Michal Orzel Currently if user enables HVC_DCC config option in Linux, it invokes access to debug data transfer registers (ie DBGDTRTX_EL0 on arm64, DBGDTRTXINT on arm32). As these registers are not emulated, Xen injects an undefined exception to the VM and Linux (running as VM) crashes.

[XEN v3 3/3] xen/arm: arm32: Add emulation of Debug Data Transfer Registers

2024-01-05 Thread Ayan Kumar Halder
DBGOSLSR is emulated in the same way as its AArch64 variant (ie OSLSR_EL1). This is to ensure that DBGOSLSR.OSLK is 0, thus MDSCR_EL1.TXfull is treated as UNK/SBZP. Thus only MDCCSR_EL0 can be emulated (which is DBGDSCRINT on arm32). DBGDSCRINT can be accessed at EL0 as DBGDSCREXT is emulated as

[XEN v3 0/3] xen/arm: Add emulation of Debug Data Transfer Registers

2024-01-05 Thread Ayan Kumar Halder
Hi, Refer https://lore.kernel.org/all/alpine.DEB.2.22.394.2312071341540.1265976@ubuntu-linux-20-04-desktop/T/ for the previous discussion on this issue. Also, the linux earlycon hvc driver has been fixed. See

[XEN v3 1/3] xen/arm: Introduce CONFIG_PARTIAL_EMULATION and "partial-emulation" cmd option

2024-01-05 Thread Ayan Kumar Halder
There can be situations when the registers cannot be emulated to their full functionality. This can be due to the complexity involved. In such cases, one can emulate those registers as RAZ/WI. We call them as partial emulation. A suitable example of this (as seen in subsequent patches) is

[xen-unstable test] 184253: tolerable FAIL

2024-01-05 Thread osstest service owner
flight 184253 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184253/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 184249 pass in 184253

Re: [PATCH v3 16/33] tools/libs/light: add backend type for 9pfs PV devices

2024-01-05 Thread George Dunlap
On Thu, Jan 4, 2024 at 9:02 AM Juergen Gross wrote: > > Make the backend type of 9pfs PV devices configurable. The default is > "qemu" with the related Xenstore backend-side directory being "9pfs". > > Add another type "xen-9pfsd" with the related Xenstore backend-side > directory "xen_9pfs". > >

Re: [PATCH RFC v3 for-6.8/block 04/17] mtd: block2mtd: use bdev apis

2024-01-05 Thread Yu Kuai
Hi, 在 2024/01/05 14:10, Christoph Hellwig 写道: On Thu, Jan 04, 2024 at 12:28:55PM +0100, Jan Kara wrote: What do you think? Because when we are working with the folios it is rather natural to use their mapping for dirty balancing? The real problem is that block2mtd pokes way to deep into

RE: Xen and Qemu virtio question

2024-01-05 Thread Peng Fan
Hi Vikram, > Subject: Re: Xen and Qemu virtio question > > Hi Peng, > Please see my comments below. > On Wed, Jan 03, 2024 at 05:38:07AM +, Peng Fan wrote: > > Hi Vikram, Oleksii > > > > I follow the slide virtio for Xen on ARM[1], but I met some issues, > > and stuck for about two days. > >

[ovmf test] 184257: all pass - PUSHED

2024-01-05 Thread osstest service owner
flight 184257 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184257/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e8166a852e63ee0c7c37291c1f88b19cc4692514 baseline version: ovmf

Re: XSA-446 relevance on Intel

2024-01-05 Thread James Dingwall
On Tue, Dec 12, 2023 at 10:56:48AM +, Andrew Cooper wrote: > On 12/12/2023 9:43 am, James Dingwall wrote: > > Hi, > > > > We were experiencing a crash during PV domU boot on several different models > > of hardware but all with Intel CPUs. The Xen version was based on > > stable-4.15 > > at

Re: [PATCH] xen/gntdev: Fix the abuse of underlying struct page in DMA-buf import

2024-01-05 Thread Christian König
Am 04.01.24 um 19:53 schrieb Oleksandr Tyshchenko: From: Oleksandr Tyshchenko DO NOT access the underlying struct page of an sg table exported by DMA-buf in dmabuf_imp_to_refs(), this is not allowed. Please see drivers/dma-buf/dma-buf.c:mangle_sg_table() for details. Fortunately, here (for

Re: AMD EPYC VM to VM performance investigation

2024-01-05 Thread David Morel
On Thu, Jan 04, 2024 at 16:39:46PM, Stefano Stabellini wrote: > On Thu, 4 Jan 2024, David Morel wrote: > > Hello, > > > > We have a customer and multiple users on our forum having performances that > > seems quite low related to the general performance of the machines on AMD > > EPYC > > Zen

Re: [RFC XEN PATCH v4 5/5] libxl: Use gsi instead of irq for mapping pirq

2024-01-05 Thread Chen, Jiqian
On 2024/1/5 15:36, Jan Beulich wrote: > On 05.01.2024 08:09, Jiqian Chen wrote: >> --- a/tools/libs/light/libxl_pci.c >> +++ b/tools/libs/light/libxl_pci.c >> @@ -1479,8 +1479,14 @@ static void pci_add_dm_done(libxl__egc *egc, >> fclose(f); >> if (!pci_supp_legacy_irq()) >> goto