Re: Detecting whether dom0 is in a VM

2024-04-22 Thread Jürgen Groß
On 22.04.24 09:12, Jan Beulich wrote: On 19.04.2024 17:29, George Dunlap wrote: On Fri, Jul 7, 2023 at 3:56 PM George Dunlap wrote: Xen's public interface offers access to the featuresets known / found / used by the hypervisor. See XEN_SYSCTL_get_cpu_featureset, accessible via

[xen-unstable test] 185762: tolerable FAIL - PUSHED

2024-04-22 Thread osstest service owner
flight 185762 xen-unstable real [real] flight 185766 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185762/ http://logs.test-lab.xenproject.org/osstest/logs/185766/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH v2 1/3] hotplug: Update block-tap

2024-04-22 Thread Jason Andryuk
On Mon, Apr 22, 2024 at 11:11 AM Anthony PERARD wrote: > > On Sun, Apr 07, 2024 at 04:49:51PM -0400, Jason Andryuk wrote: > > diff --git a/tools/hotplug/Linux/block-tap b/tools/hotplug/Linux/block-tap > > index 89247921b9..126e472786 100755 > > --- a/tools/hotplug/Linux/block-tap > > +++

Re: (subset) [PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking

2024-04-22 Thread Jens Axboe
On Fri, 19 Apr 2024 12:08:38 +0100, Pavel Begunkov wrote: > Please, don't take directly, conflicts with io_uring. > > To have per request buffer notifications each zerocopy io_uring send > request allocates a new ubuf_info. However, as an skb can carry only > one uarg, it may force the stack to

[ovmf test] 185764: all pass - PUSHED

2024-04-22 Thread osstest service owner
flight 185764 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185764/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 86c8d69146310f24069701053a27153ae536ebba baseline version: ovmf

Re: [PATCH] x86/MTRR: avoid several indirect calls

2024-04-22 Thread Marek Marczykowski-Górecki
On Wed, Jan 17, 2024 at 10:32:53AM +0100, Jan Beulich wrote: > --- a/xen/arch/x86/cpu/mtrr/main.c > +++ b/xen/arch/x86/cpu/mtrr/main.c > @@ -328,7 +316,7 @@ int mtrr_add_page(unsigned long base, un > } > > /* If the type is WC, check that this processor supports it */ > - if

Re: [PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking

2024-04-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 19 Apr 2024 12:08:38 +0100 you wrote: > Please, don't take directly, conflicts with io_uring. > > To have per request buffer notifications each zerocopy io_uring send > request allocates a new ubuf_info.

Re: Detecting whether dom0 is in a VM

2024-04-22 Thread Stefano Stabellini
On Mon, 22 Apr 2024, Jan Beulich wrote: > On 19.04.2024 17:29, George Dunlap wrote: > > On Fri, Jul 7, 2023 at 3:56 PM George Dunlap > > wrote: > >> Xen's public interface offers access to the featuresets known / found / > >> used by the hypervisor. See XEN_SYSCTL_get_cpu_featureset,

[linux-5.4 test] 185761: regressions - trouble: broken/fail/pass

2024-04-22 Thread osstest service owner
flight 185761 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/185761/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken build-arm64-pvops

[linux-linus test] 185758: regressions - FAIL

2024-04-22 Thread osstest service owner
flight 185758 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/185758/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 185750

Re: [PATCH 3/6] x86/alternative: Intend the relocation logic

2024-04-22 Thread Andrew Cooper
This of course intended to say indent... ~Andrew

[PATCH 2/6] x86/alternative: Walk all replacements in debug builds

2024-04-22 Thread Andrew Cooper
In debug builds, walk all alternative replacements with x86_decode_lite(). This checks that we can decode all instructions, and also lets us check that disp8's don't leave the replacement block. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné ---

[PATCH 5/6] x86/alternative: Relocate all insn-relative fields

2024-04-22 Thread Andrew Cooper
Right now, relocation of displacements is restricted to finding 0xe8/e9 as the first byte of the replacement, but this is overly restrictive. Use x86_decode_lite() to find and adjust all insn-relative fields. As with disp8's not leaving the replacemnet block, some disp32's don't either. e.g. the

[PATCH 1/6] x86: Introduce x86_decode_lite()

2024-04-22 Thread Andrew Cooper
In order to relocate all IP-relative fields in an alternative replacement block, we need to decode the instructions enough to obtain their length and any relative fields. Full x86_decode() is far too heavyweight, so introduce a minimal form which can make several simplifying assumptions. This

[PATCH 6/6] x86/spec-ctrl: Introduce and use DO_COND_BHB_SEQ

2024-04-22 Thread Andrew Cooper
Now that alternatives can fix up call displacements even when they're not the first instruction of the replacement, move the SCF_entry_bhb conditional inside the replacement block. This removes a conditional branch from the fastpaths of BHI-unaffected hardware. Signed-off-by: Andrew Cooper ---

[PATCH 3/6] x86/alternative: Intend the relocation logic

2024-04-22 Thread Andrew Cooper
... to make subsequent patches legible. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné --- xen/arch/x86/alternative.c | 126 +++-- 1 file changed, 64 insertions(+), 62 deletions(-) diff --git

[PATCH 0/6] x86/alternatives: Adjust all insn-relative fields

2024-04-22 Thread Andrew Cooper
Alternatives have had a reasonably severe restriction since their introduction. This has been the source of several bugs, and several inefficiencies particularly in the speculative safety paths, and I've finally gotten bored enough to fixing it. Introduce the new infrastructure, and adjust the

[PATCH 4/6] x86/alternative: Replace a continue with a goto

2024-04-22 Thread Andrew Cooper
A subsequent patch is going to insert a loop, which interferes with the continue in the devirtualisation logic. Replace it with a goto, and a paragraph explaining why we intentionally avoid setting a->priv = 1. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger

Re: [PATCH v2 5/5] x86: Add --force option to xen-ucode to override microcode version check

2024-04-22 Thread Anthony PERARD
On Tue, Apr 16, 2024 at 10:15:46AM +0100, Fouad Hilly wrote: > Introduce --force option to xen-ucode to force skipping microcode version > check, which allows the user to update x86 microcode even if both versions > are the same. > > [v2] > 1- Changed data type from uint32_t to unsigned int. > 2-

Re: [PATCH v2 4/5] x86: Use getopt to handle command line args

2024-04-22 Thread Anthony PERARD
On Tue, Apr 16, 2024 at 10:15:45AM +0100, Fouad Hilly wrote: > diff --git a/tools/misc/xen-ucode.c b/tools/misc/xen-ucode.c > index 0c0b2337b4ea..e3c1943e3633 100644 > --- a/tools/misc/xen-ucode.c > +++ b/tools/misc/xen-ucode.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include

Re: [PATCH v2 3/5] x86: Add usage() to print out usage message

2024-04-22 Thread Anthony PERARD
On Tue, Apr 16, 2024 at 10:15:44AM +0100, Fouad Hilly wrote: > Refactor xen-ucode tool by adding usage() to handle usage\help messages > As we add more command options this will keep help\usage messages in common > block > > [v2] > 1- Improved message description. > 2- Fixed formatting and

Re: [PATCH v3 4/4] docs/man: Add xenwatchdog manual page

2024-04-22 Thread Anthony PERARD
On Thu, Apr 11, 2024 at 07:20:23PM +0100, le...@solinno.co.uk wrote: > From: Leigh Brown > > Add a manual page for xenwatchdogd. > > Signed-off-by: Leigh Brown Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH v3 2/4] tools/misc: xenwatchdogd enhancements

2024-04-22 Thread Anthony PERARD
On Thu, Apr 11, 2024 at 07:20:21PM +0100, le...@solinno.co.uk wrote: > From: Leigh Brown > > Add usage() function, the ability to run in the foreground, and > the ability to disarm the watchdog timer when exiting. > > Add enhanced parameter parsing and validation, making use of > getopt_long().

Re: [PATCH v3 3/4] tools/misc: Add xenwatchdogd.c copyright notice

2024-04-22 Thread Anthony PERARD
On Thu, Apr 11, 2024 at 07:20:22PM +0100, le...@solinno.co.uk wrote: > From: Leigh Brown > > Add copyright notice and description of the program. > > Signed-off-by: Leigh Brown > > --- > tools/misc/xenwatchdogd.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH v3 1/4] tools/misc: xenwatchdogd: add parse_secs()

2024-04-22 Thread Anthony PERARD
On Thu, Apr 11, 2024 at 07:20:20PM +0100, le...@solinno.co.uk wrote: > From: Leigh Brown > > Create a new parse_secs() function to parse the timeout and sleep > parameters. This ensures that non-numeric parameters are not > accidentally treated as numbers. > > Signed-off-by: Leigh Brown

Re: [RFC PATCH v2 2/2] libs/light: expand device model start timeout use

2024-04-22 Thread Anthony PERARD
On Thu, Apr 11, 2024 at 03:28:20PM +0300, Manos Pitsidianakis wrote: > Various timeout values that depend on the device model should also > respect the device model start timeout setting. This commit adds the > __libxl_device_model_start_timeout() value to those time outs without > changing their

[xen-unstable-smoke test] 185760: tolerable all pass - PUSHED

2024-04-22 Thread osstest service owner
flight 185760 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185760/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [RFC PATCH v2 1/2] libs/light: add device model start timeout env var

2024-04-22 Thread Anthony PERARD
On Thu, Apr 11, 2024 at 03:28:19PM +0300, Manos Pitsidianakis wrote: > diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in > index bed8393473..c159877094 100644 > --- a/docs/man/xl.1.pod.in > +++ b/docs/man/xl.1.pod.in > @@ -1993,6 +1993,17 @@ Otherwise the build time default in >

Re: [PATCH] x86/rtc: Avoid UIP flag being set for longer than expected

2024-04-22 Thread Ross Lagerwall
On Thu, Apr 18, 2024 at 2:24 PM Jan Beulich wrote: > > On 08.04.2024 18:26, Ross Lagerwall wrote: > > In a test, OVMF reported an error initializing the RTC without > > indicating the precise nature of the error. The only plausible > > explanation I can find is as follows: > > > > As part of the

Re: [RFC PATCH v3 1/3] xen/memory : Add a stats_table resource type

2024-04-22 Thread Jan Beulich
On 31.10.2023 17:21, Matias Ezequiel Vara Larsen wrote: > This commit proposes a new mechanism to query the RUNSTATE_running counter for > a given vcpu from a dom0 userspace application. This commit proposes to expose > that counter by using the acquire_resource interface. For this purpose, the >

Re: [PATCH v3] xen/riscv: check whether the assembler has Zbb extension support

2024-04-22 Thread Oleksii
On Mon, 2024-04-22 at 11:43 +0200, Jan Beulich wrote: > On 19.04.2024 16:23, Oleksii Kurochko wrote: > > Update the argument of the as-insn for the Zbb case to verify that > > Zbb is supported not only by a compiler, but also by an assembler. > > > > Also, check-extenstion(ext_name, "insn")

Re: [RFC,FUTURE 1/3] domctl/pci: add ability to provide/request a virtual SBDF

2024-04-22 Thread Jan Beulich
On 14.12.2023 00:44, Volodymyr Babchuk wrote: > With CONFIG_HAS_VPCI_GUEST_SUPPORT enabled, hypervisor will assign a > passed-through PCI device to a guest using virtual/guest SBDF > number. Right now hypervisor automatically allocates next free > SBDF. But there are cases mentioned in [1] when

Re: [PATCH] x86/cpuid-policy: Add AMD SVM CPUID leaf to featureset

2024-04-22 Thread Jan Beulich
On 22.04.2024 17:09, Jan Beulich wrote: > On 17.04.2024 15:22, George Dunlap wrote: >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -477,6 +477,8 @@ static void generic_identify(struct cpuinfo_x86 *c) >> c->x86_capability[FEATURESET_e7d] =

Re: [PATCH v2 1/3] hotplug: Update block-tap

2024-04-22 Thread Anthony PERARD
On Sun, Apr 07, 2024 at 04:49:51PM -0400, Jason Andryuk wrote: > diff --git a/tools/hotplug/Linux/block-tap b/tools/hotplug/Linux/block-tap > index 89247921b9..126e472786 100755 > --- a/tools/hotplug/Linux/block-tap > +++ b/tools/hotplug/Linux/block-tap > @@ -18,11 +18,11 @@ > # > # Usage: > #

Re: [PATCH] public: xen: Define missing guest handle for int32_t

2024-04-22 Thread Julien Grall
Hi Stefano, On 17/04/2024 19:49, Stefano Stabellini wrote: On Wed, 17 Apr 2024, Julien Grall wrote: Hi Michal, On 17/04/2024 13:14, Michal Orzel wrote: Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t in XEN_GUEST_HANDLE() in memory.h but there is no guest handle

Re: [PATCH] x86/cpuid-policy: Add AMD SVM CPUID leaf to featureset

2024-04-22 Thread Jan Beulich
On 17.04.2024 15:22, George Dunlap wrote: > Currently, the CPUID leaf for SVM features (extd 0xa.edx) is manually > twiddled: > > - hvm_max_policy takes host_policy and clamps it to supported >features (with some features unilaterally enabled because they're >always emulated > > -

[ovmf test] 185759: all pass - PUSHED

2024-04-22 Thread osstest service owner
flight 185759 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185759/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7dd7b890582b4d696ca5fd436dbc5fb4bc30e385 baseline version: ovmf

[linux-5.4 test] 185755: regressions - FAIL

2024-04-22 Thread osstest service owner
flight 185755 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/185755/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt broken in 185433 build-arm64-pvops

Re: [PATCH v2 2/5] x86: Refactor microcode_update() hypercall with flags

2024-04-22 Thread Jan Beulich
On 16.04.2024 11:15, Fouad Hilly wrote: > Refactor microcode_update() hypercall by adding flags field. > Introduce XENPF_microcode_update2 hypercall to handle flags field. > struct xenpf_microcode_update updated to have uint32_t flags at > the end of the sturcture. > > [v2] > 1- Update message

Re: [PATCH v2 1/5] x86: Update x86 low level version check of microcode

2024-04-22 Thread Jan Beulich
On 16.04.2024 11:15, Fouad Hilly wrote: > Update microcode version check at Intel and AMD Level by: > Preventing the low level code from sending errors if the microcode > version provided is not a newer version. And why is this change (a) wanted and (b) correct? > Other errors will be sent like

Re: [PATCH v2 2/2] x86/spec: adjust logic to logic that elides lfence

2024-04-22 Thread Jan Beulich
On 22.04.2024 15:35, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at 08:25:00AM +0200, Jan Beulich wrote: >> On 18.04.2024 17:52, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/include/asm/cpufeature.h >>> +++ b/xen/arch/x86/include/asm/cpufeature.h >>> @@ -235,9 +235,6 @@ static inline bool

Re: [PATCH v2 2/2] x86/spec: adjust logic to logic that elides lfence

2024-04-22 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 08:25:00AM +0200, Jan Beulich wrote: > On 18.04.2024 17:52, Roger Pau Monne wrote: > > It's currently too restrictive by just checking whether there's a BHB > > clearing > > sequence selected. It should instead check whether BHB clearing is used on > > entry from PV or

4.19 Release schedule - Reminder

2024-04-22 Thread Kelly Choi
Hello all, *Please find below our 4.19 Release Schedule* *(Original thread from Release Manager ) * ** Proposed option: Wed Jul 10, 2024 ** (+9 months from Xen 4.18 release) - Last posting date

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Jan Beulich
On 22.04.2024 13:34, Roger Pau Monné wrote: > On Mon, Apr 22, 2024 at 12:57:55PM +0200, Jan Beulich wrote: >> On 22.04.2024 12:49, Roger Pau Monné wrote: >>> On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: On 22.04.2024 09:54, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at

Re: [XEN PATCH v2 5/5] xen/arm: ffa: support notification

2024-04-22 Thread Julien Grall
Hi Jens, This is not a full review of the code. I will let Bertrand doing it. On 22/04/2024 08:37, Jens Wiklander wrote: +void ffa_notif_init(void) +{ +const struct arm_smccc_1_2_regs arg = { +.a0 = FFA_FEATURES, +.a1 = FFA_FEATURE_SCHEDULE_RECV_INTR, +}; +struct

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Roger Pau Monné
On Mon, Apr 22, 2024 at 12:57:55PM +0200, Jan Beulich wrote: > On 22.04.2024 12:49, Roger Pau Monné wrote: > > On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: > >> On 22.04.2024 09:54, Roger Pau Monné wrote: > >>> On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: > On

[PATCH v3.2 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Luca Fancellu
Currently Xen is not exporting the static shared memory regions to the device tree as /memory node, this commit is fixing this issue. Given that now make_memory_node needs a parameter 'struct kernel_info' in order to call the new function shm_mem_node_fill_reg_range, take the occasion to remove

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Jan Beulich
On 22.04.2024 12:49, Roger Pau Monné wrote: > On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: >> On 22.04.2024 09:54, Roger Pau Monné wrote: >>> On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: On 19.04.2024 12:50, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at

Re: [XEN PATCH v2 4/5] xen/arm: allow dynamically assigned SGI handlers

2024-04-22 Thread Julien Grall
Hi Jens, On 22/04/2024 08:37, Jens Wiklander wrote: Updates so request_irq() can be used with a dynamically assigned SGI irq as input. This prepares for a later patch where an FF-A schedule receiver interrupt handler is installed for an SGI generated by the secure world. I would like to

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Roger Pau Monné
On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: > On 22.04.2024 09:54, Roger Pau Monné wrote: > > On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: > >> On 19.04.2024 12:50, Roger Pau Monné wrote: > >>> On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: > On

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Julien Grall
Hi Luca, On 22/04/2024 11:39, Luca Fancellu wrote: On 22 Apr 2024, at 11:24, Julien Grall wrote: Hi, On 22/04/2024 10:26, Michal Orzel wrote: On 22/04/2024 10:07, Luca Fancellu wrote: Hi Michal, +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += reg_size ) +{ +

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Luca Fancellu
> On 22 Apr 2024, at 11:24, Julien Grall wrote: > > Hi, > > On 22/04/2024 10:26, Michal Orzel wrote: >> On 22/04/2024 10:07, Luca Fancellu wrote: >>> >>> >>> Hi Michal, >>> > +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += > reg_size ) > +{ > +

Re: [PATCH v2 2/2] x86/pvh: zero VGA information

2024-04-22 Thread Jan Beulich
On 22.04.2024 11:52, Roger Pau Monne wrote: > PVH guests skip real mode VGA detection, and never have a VGA available, hence > the default VGA selection is not applicable, and at worse can cause confusion > when parsing Xen boot log. > > Zero the boot_vid_info structure when Xen is booted from

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Julien Grall
Hi, On 22/04/2024 10:26, Michal Orzel wrote: On 22/04/2024 10:07, Luca Fancellu wrote: Hi Michal, +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += reg_size ) +{ +u64 start = dt_read_number(cells, addrcells); We should no longer use Linux derived types

[PATCH v2 1/2] x86/video: add boot_video_info offset generation to asm-offsets

2024-04-22 Thread Roger Pau Monne
Currently the offsets into the boot_video_info struct are manually encoded in video.S, which is fragile. Generate them in asm-offsets.c and switch the current code to use those instead. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper --- Changes since

[PATCH v2 0/2] x86/pvh: fix VGA reporting when booted as a PVH guest

2024-04-22 Thread Roger Pau Monne
Hello, Following patches are kind of unconnected after v1, but patch 1/2 is still a helpful improvement. Patch 2 fixes the (wrong) reporting of VGA information when Xen is booted as a PVH guest. Thanks, Roger. Roger Pau Monne (2): x86/video: add boot_video_info offset generation to

[PATCH v2 2/2] x86/pvh: zero VGA information

2024-04-22 Thread Roger Pau Monne
PVH guests skip real mode VGA detection, and never have a VGA available, hence the default VGA selection is not applicable, and at worse can cause confusion when parsing Xen boot log. Zero the boot_vid_info structure when Xen is booted from the PVH entry point. This fixes Xen incorrectly

Re: [PATCH v3] xen/riscv: check whether the assembler has Zbb extension support

2024-04-22 Thread Jan Beulich
On 19.04.2024 16:23, Oleksii Kurochko wrote: > Update the argument of the as-insn for the Zbb case to verify that > Zbb is supported not only by a compiler, but also by an assembler. > > Also, check-extenstion(ext_name, "insn") helper macro is introduced > to check whether extension is supported

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Michal Orzel
On 22/04/2024 10:07, Luca Fancellu wrote: > > > Hi Michal, > >>> +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += >>> reg_size ) >>> +{ >>> +u64 start = dt_read_number(cells, addrcells); >> We should no longer use Linux derived types like u64. Use uint64_t.

[xen-unstable test] 185754: tolerable FAIL

2024-04-22 Thread osstest service owner
flight 185754 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185754/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl 13 debian-fixup fail pass in 185748 Tests which did not succeed,

[ovmf test] 185756: all pass - PUSHED

2024-04-22 Thread osstest service owner
flight 185756 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185756/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf be92e09206c2e4bb388e7c9127f048689841dd01 baseline version: ovmf

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Jan Beulich
On 22.04.2024 09:54, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: >> On 19.04.2024 12:50, Roger Pau Monné wrote: >>> On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: On 19.04.2024 12:02, Roger Pau Monne wrote: > Livepatch payloads

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Luca Fancellu
Hi Michal, >> +for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells += >> reg_size ) >> +{ >> +u64 start = dt_read_number(cells, addrcells); > We should no longer use Linux derived types like u64. Use uint64_t. > >> +u64 size = dt_read_number(cells + addrcells,

Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes

2024-04-22 Thread Michal Orzel
Hi Luca, On 18/04/2024 09:36, Luca Fancellu wrote: > > > Currently Xen is not exporting the static shared memory regions > to the device tree as /memory node, this commit is fixing this > issue. > > Given that now make_memory_node needs a parameter 'struct kernel_info' > in order to call the

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: > On 19.04.2024 12:50, Roger Pau Monné wrote: > > On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: > >> On 19.04.2024 12:02, Roger Pau Monne wrote: > >>> Livepatch payloads containing symbols that belong to init sections can

[linux-linus test] 185753: regressions - FAIL

2024-04-22 Thread osstest service owner
flight 185753 linux-linus real [real] flight 185757 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185753/ http://logs.test-lab.xenproject.org/osstest/logs/185757/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[XEN PATCH v2 4/5] xen/arm: allow dynamically assigned SGI handlers

2024-04-22 Thread Jens Wiklander
Updates so request_irq() can be used with a dynamically assigned SGI irq as input. This prepares for a later patch where an FF-A schedule receiver interrupt handler is installed for an SGI generated by the secure world. gic_route_irq_to_xen() don't gic_set_irq_type() for SGIs since they are

[XEN PATCH v2 5/5] xen/arm: ffa: support notification

2024-04-22 Thread Jens Wiklander
Add support for FF-A notifications, currently limited to an SP (Secure Partition) sending an asynchronous notification to a guest. Guests and Xen itself are made aware of pending notifications with an interrupt. The interrupt handler retrieves the notifications using the FF-A ABI and deliver them

[XEN PATCH v2 2/5] xen/arm: ffa: use ACCESS_ONCE()

2024-04-22 Thread Jens Wiklander
Replace read_atomic() with ACCESS_ONCE() to match the intended use, that is, to prevent the compiler from (via optimization) reading shared memory more than once. Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- xen/arch/arm/tee/ffa_shm.c | 15 --- 1 file changed, 8

[XEN PATCH v2 0/5] FF-A notifications

2024-04-22 Thread Jens Wiklander
Hi, This patch set adds support for FF-A notifications. We only support global notifications, per vCPU notifications remain unsupported. The first three patches are further cleanup and can be merged before the rest if desired. A physical SGI is used to make Xen aware of pending FF-A

[XEN PATCH v2 3/5] xen/arm: ffa: simplify ffa_handle_mem_share()

2024-04-22 Thread Jens Wiklander
Simplify ffa_handle_mem_share() by removing the start_page_idx and last_page_idx parameters from get_shm_pages() and check that the number of pages matches expectations at the end of get_shm_pages(). Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- xen/arch/arm/tee/ffa_shm.c |

[XEN PATCH v2 1/5] xen/arm: ffa: refactor ffa_handle_call()

2024-04-22 Thread Jens Wiklander
Refactors the large switch block in ffa_handle_call() to use common code for the simple case where it's either an error code or success with no further parameters. Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis --- xen/arch/arm/tee/ffa.c | 30 ++ 1 file

Re: Detecting whether dom0 is in a VM

2024-04-22 Thread Jan Beulich
On 19.04.2024 17:29, George Dunlap wrote: > On Fri, Jul 7, 2023 at 3:56 PM George Dunlap wrote: >> Xen's public interface offers access to the featuresets known / found / >> used by the hypervisor. See XEN_SYSCTL_get_cpu_featureset, accessible >> via xc_get_cpu_featureset(). >>

Re: Detecting whether dom0 is in a VM

2024-04-22 Thread Jan Beulich
On 19.04.2024 17:51, George Dunlap wrote: > On Fri, Apr 19, 2024 at 4:29 PM George Dunlap wrote: >> >> On Fri, Jul 7, 2023 at 3:56 PM George Dunlap wrote: >>> Xen's public interface offers access to the featuresets known / found / >>> used by the hypervisor. See