Re: [PATCH v3 7/8] gzip: move bitbuffer into gunzip state

2024-04-25 Thread Jan Beulich
On 26.04.2024 07:55, Jan Beulich wrote: > On 25.04.2024 21:23, Andrew Cooper wrote: >> On 24/04/2024 5:34 pm, Daniel P. Smith wrote: >>> --- a/xen/common/gzip/inflate.c >>> +++ b/xen/common/gzip/inflate.c >>> @@ -1017,8 +1014,8 @@ static int __init inflate(struct gunzip_state *s) >>> /* Undo

Re: [PATCH v3 7/8] gzip: move bitbuffer into gunzip state

2024-04-25 Thread Jan Beulich
On 25.04.2024 21:23, Andrew Cooper wrote: > On 24/04/2024 5:34 pm, Daniel P. Smith wrote: >> --- a/xen/common/gzip/inflate.c >> +++ b/xen/common/gzip/inflate.c >> @@ -1017,8 +1014,8 @@ static int __init inflate(struct gunzip_state *s) >> /* Undo too much lookahead. The next read will be byte

Re: [PATCH v4 0/5] DOMCTL-based guest magic region allocation for 11 domUs

2024-04-25 Thread Henry Wang
Hi Stefano, Daniel, On 4/26/2024 6:18 AM, Stefano Stabellini wrote: On Thu, 18 Apr 2024, Daniel P. Smith wrote: On 4/9/24 00:53, Henry Wang wrote: An error message can seen from the init-dom0less application on direct-mapped 1:1 domains: ``` Allocating magic pages memory.c:238:d0v0 mfn

[ovmf test] 185803: all pass - PUSHED

2024-04-25 Thread osstest service owner
flight 185803 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185803/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c0dfe3ec1f364dbdaf6b241e01343e560b21dd03 baseline version: ovmf

[PATCH 2/3] xen/arm, tools: Add a new HVM_PARAM_MAGIC_BASE_PFN key in HVMOP

2024-04-25 Thread Henry Wang
For use cases such as Dom0less PV drivers, a mechanism to communicate Dom0less DomU's static data with the runtime control plane (Dom0) is needed. Since on Arm HVMOP is already the existing approach to address such use cases (for example the allocation of HVM_PARAM_CALLBACK_IRQ), add a new HVMOP

[PATCH 0/3] Guest magic region allocation for 11 Dom0less domUs - Take two

2024-04-25 Thread Henry Wang
Hi all, This series is trying to fix the reported guest magic region allocation issue for 11 Dom0less domUs, an error message can seen from the init-dom0less application on 1:1 direct-mapped Dom0less DomUs: ``` Allocating magic pages memory.c:238:d0v0 mfn 0x39000 doesn't belong to d1 Error on

[PATCH 3/3] tools/init-dom0less: Avoid hardcoding GUEST_MAGIC_BASE

2024-04-25 Thread Henry Wang
Currently the GUEST_MAGIC_BASE in the init-dom0less application is hardcoded, which will lead to failures for 1:1 direct-mapped Dom0less DomUs. Since the guest magic region is now allocated from the hypervisor, instead of hardcoding the guest magic pages region, use xc_hvm_param_get() to get the

[PATCH 1/3] xen/arm/dom0less-build: Alloc magic pages for Dom0less DomUs from hypervisor

2024-04-25 Thread Henry Wang
There are use cases (for example using the PV driver) in Dom0less setup that require Dom0less DomUs start immediately with Dom0, but initialize XenStore later after Dom0's successful boot and call to the init-dom0less application. An error message can seen from the init-dom0less application on

[xen-unstable-smoke test] 185801: tolerable all pass - PUSHED

2024-04-25 Thread osstest service owner
flight 185801 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185801/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH v1.1] xen/commom/dt-overlay: Fix missing lock when remove the device

2024-04-25 Thread Henry Wang
If CONFIG_DEBUG=y, below assertion will be triggered: (XEN) Assertion 'rw_is_locked(_host_lock)' failed at drivers/passthrough/device_tree.c:146 (XEN) [ Xen-4.19-unstable  arm64  debug=y  Not tainted ] (XEN) CPU:    0 (XEN) PC: 0a257418 iommu_remove_dt_device+0x8c/0xd4 (XEN)

Re: [PATCH 11/15] tools/helpers: Add get_overlay

2024-04-25 Thread Henry Wang
Hi Stewart, On 4/26/2024 9:45 AM, Stewart Hildebrand wrote: On 4/24/24 20:43, Henry Wang wrote: Hi Jan, On 4/24/2024 2:08 PM, Jan Beulich wrote: On 24.04.2024 05:34, Henry Wang wrote: From: Vikram Garhwal This user level application copies the overlay dtbo shared by dom0 while doing

Re: [PATCH 11/15] tools/helpers: Add get_overlay

2024-04-25 Thread Stewart Hildebrand
On 4/24/24 20:43, Henry Wang wrote: > Hi Jan, > > On 4/24/2024 2:08 PM, Jan Beulich wrote: >> On 24.04.2024 05:34, Henry Wang wrote: >>> From: Vikram Garhwal >>> >>> This user level application copies the overlay dtbo shared by dom0 while >>> doing >>> overlay node assignment operation. It uses

[linux-linus test] 185798: regressions - FAIL

2024-04-25 Thread osstest service owner
flight 185798 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/185798/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 185768

Re: [PATCH 1/7] x86/p2m: Add braces for better code clarity

2024-04-25 Thread Stefano Stabellini
On Wed, 24 Apr 2024, Petr Beneš wrote: > From: Petr Beneš > > No functional change. > > Signed-off-by: Petr Beneš Reviewed-by: Stefano Stabellini

[PATCH v2] docs/misra: add R21.6 R21.9 R21.10 R21.14 R21.15 R21.16

2024-04-25 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- Changes in v2: - remove trailing whitespaces - add rules 21.9 and 21.10 - remove deviations.rst deviations (to be done separately if required) - add a note explaning that Xen has no standard library --- docs/misra/rules.rst | 60

Re: [PATCH v2 1/1] xen/arm64: entry: Add missing code symbol annotations

2024-04-25 Thread Stefano Stabellini
On Tue, 16 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use the generic xen/linkage.h macros when and add missing ^ when what? > code symbol annotations. > > Signed-off-by: Edgar E. Iglesias I am looking at the implementation of

Re: [PATCH] xen: Use -Wuninitialized and -Winit-self

2024-04-25 Thread Stefano Stabellini
On Thu, 28 Dec 2023, Andrew Cooper wrote: > The use of uninitialised data is undefined behaviour. At -O2 with trivial > examples, both Clang and GCC delete the variable, and in the case of a > function return, the caller gets whatever was stale in %rax prior to the call. > > Clang includes

Re: [PATCH] public: xen: Define missing guest handle for int32_t

2024-04-25 Thread Stefano Stabellini
On Mon, 22 Apr 2024, Julien Grall wrote: > Hi Stefano, > > On 17/04/2024 19:49, Stefano Stabellini wrote: > > On Wed, 17 Apr 2024, Julien Grall wrote: > > > Hi Michal, > > > > > > On 17/04/2024 13:14, Michal Orzel wrote: > > > > Commit afab29d0882f ("public: s/int/int32_t") replaced int with

Re: [XEN PATCH v1 13/15] x86: wire cpu_has_{svm/vmx}_* to false when svm/vmx not enabled

2024-04-25 Thread Stefano Stabellini
On Thu, 18 Apr 2024, Sergiy Kibrik wrote: > 16.04.24 16:26, Andrew Cooper: > > I'm afraid this is going in an unhelpful direction.  We want to move > > both of these files to be local to arch/x86/hvm/{vmx,svm}/. > > > > cpu_has_svm_* isn't actually used outside of svm/; only the plain > >

Re: [PATCH v4 0/5] DOMCTL-based guest magic region allocation for 11 domUs

2024-04-25 Thread Stefano Stabellini
On Thu, 18 Apr 2024, Daniel P. Smith wrote: > On 4/9/24 00:53, Henry Wang wrote: > > An error message can seen from the init-dom0less application on > > direct-mapped 1:1 domains: > > ``` > > Allocating magic pages > > memory.c:238:d0v0 mfn 0x39000 doesn't belong to d1 > > Error on alloc magic

[xen-unstable-smoke test] 185799: tolerable all pass - PUSHED

2024-04-25 Thread osstest service owner
flight 185799 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185799/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH] xen/spinlock: use correct pointer

2024-04-25 Thread Stewart Hildebrand
The ->profile member is at different offsets in struct rspinlock and struct spinlock. When initializing the profiling bits of an rspinlock, an unrelated member in struct rspinlock was being overwritten, leading to mild havoc. Use the correct pointer. Fixes: b053075d1a7b ("xen/spinlock: make

Re: [XEN PATCH] automation/eclair: reorganize pipelines

2024-04-25 Thread Stefano Stabellini
On Thu, 25 Apr 2024, Federico Serafini wrote: > On 25/04/24 02:06, Stefano Stabellini wrote: > > On Tue, 23 Apr 2024, Federico Serafini wrote: > > > From: Simone Ballarin > > > > > > Introduce accepted_guidelines.sh: a script to autogenerate the > > > configuration file accepted.ecl from

[xen-unstable test] 185794: tolerable FAIL - PUSHED

2024-04-25 Thread osstest service owner
flight 185794 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185794/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185786

Re: [PATCH v3 7/8] gzip: move bitbuffer into gunzip state

2024-04-25 Thread Andrew Cooper
On 24/04/2024 5:34 pm, Daniel P. Smith wrote: > Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper > diff --git a/xen/common/gzip/inflate.c b/xen/common/gzip/inflate.c > index bec8801df487..8da14880cfbe 100644 > --- a/xen/common/gzip/inflate.c > +++ b/xen/common/gzip/inflate.c > @@ -1017,8

Re: [PATCH v3 8/8] gzip: move crc state into gunzip state

2024-04-25 Thread Andrew Cooper
On 24/04/2024 5:34 pm, Daniel P. Smith wrote: > Move the crc and its state into struct gunzip_state. In the process, expand > the > only use of CRC_VALUE as it is hides what is being compared. "All variables here should be uint32_t rather than unsigned long, which halves the storage space

Re: [PATCH v3 1/8] gzip: clean up comments and fix code alignment

2024-04-25 Thread Andrew Cooper
On 24/04/2024 5:34 pm, Daniel P. Smith wrote: > This commit cleans up the comments and fixes the code alignment using Xen > coding style. This is done to make the code more legible before refactoring. > > Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper

Re: [PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd

2024-04-25 Thread Andrew Cooper
On 25/04/2024 7:06 pm, Anthony PERARD wrote: > On Thu, Apr 25, 2024 at 06:32:15PM +0100, Andrew Cooper wrote: >> libsystemd is a giant dependency for one single function, but in the wake of >> the xz backdoor, it turns out that even systemd leadership recommend against >> linking against

Re: [PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd

2024-04-25 Thread Anthony PERARD
On Thu, Apr 25, 2024 at 06:32:15PM +0100, Andrew Cooper wrote: > libsystemd is a giant dependency for one single function, but in the wake of > the xz backdoor, it turns out that even systemd leadership recommend against > linking against libsystemd for sd_notify(). > > Since commit 7b61011e1450

Re: [PATCH] CI: Drop glibc-i386 from the build containers

2024-04-25 Thread Stefano Stabellini
On Thu, 24 Apr 2024, Andrew Cooper wrote: > Xen 4.14 no longer runs in Gitlab CI. Drop the dependency to shrink the build > containers a little. > > Signed-off-by: Andrew Cooper Acked-by: Stefano Stabellini > --- > CC: Anthony PERARD > CC: Stefano Stabellini > CC: Michal Orzel > CC: Doug

[PATCH] CI: Drop glibc-i386 from the build containers

2024-04-25 Thread Andrew Cooper
Xen 4.14 no longer runs in Gitlab CI. Drop the dependency to shrink the build containers a little. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Stefano Stabellini CC: Michal Orzel CC: Doug Goldstein CC: Roger Pau Monné --- automation/build/archlinux/current.dockerfile|

[PATCH 2/2] tools: Drop libsystemd as a dependency

2024-04-25 Thread Andrew Cooper
There are no more users, and we want to disuade people from introducing new users just for sd_notify() and friends. Drop the dependency. We still want the overall --with{,out}-systemd to gate the generation of the service/unit/mount/etc files. Rerun autogen.sh, and mark the dependency as

[PATCH 0/2] Drop libsystemd

2024-04-25 Thread Andrew Cooper
On advise from the systemd leadership. See patch 1 for details. Andrew Cooper (2): tools/{c,o}xenstored: Don't link against libsystemd tools: Drop libsystemd as a dependency automation/build/archlinux/current.dockerfile | 1 + .../build/suse/opensuse-leap.dockerfile | 1 +

[PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd

2024-04-25 Thread Andrew Cooper
libsystemd is a giant dependency for one single function, but in the wake of the xz backdoor, it turns out that even systemd leadership recommend against linking against libsystemd for sd_notify(). Since commit 7b61011e1450 ("tools: make xenstore domain easy configurable") in Xen 4.8, the

[xen-unstable-smoke test] 185797: tolerable all pass - PUSHED

2024-04-25 Thread osstest service owner
flight 185797 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185797/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH] svm: Fix MISRA 8.2 violation

2024-04-25 Thread Andrew Cooper
On 25/04/2024 10:12 am, George Dunlap wrote: > Misra 8.2 requires named parameters in prototypes. Use the name from > the implementaiton. > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). Nit.  We treat Fixes: as a tag. Also you might want to include the Reported-by's.

Re: [PATCH v8 05/17] xen/riscv: introduce bitops.h

2024-04-25 Thread Jan Beulich
On 17.04.2024 12:04, Oleksii Kurochko wrote: > Taken from Linux-6.4.0-rc1 > > Xen's bitops.h consists of several Linux's headers: > * linux/arch/include/asm/bitops.h: > * The following function were removed as they aren't used in Xen: > * test_and_set_bit_lock > *

Re: [PATCH v8 04/17] xen/bitops: put __ffs() into linux compatible header

2024-04-25 Thread Jan Beulich
On 17.04.2024 12:04, Oleksii Kurochko wrote: > --- a/xen/include/xen/linux-compat.h > +++ b/xen/include/xen/linux-compat.h > @@ -19,4 +19,6 @@ typedef int64_t __s64; > > typedef paddr_t phys_addr_t; > > +#define __ffs(x) (ffsl(x) - 1) See my v7 reply. Jan

Re: [PATCH v8 03/17] xen/bitops: implement fls{l}() in common logic

2024-04-25 Thread Jan Beulich
On 17.04.2024 12:04, Oleksii Kurochko wrote: > Return type was left 'int' because of the following compilation error: > > ./include/xen/kernel.h:18:21: error: comparison of distinct pointer types > lacks a cast [-Werror] >18 | (void) (&_x == &_y);\ > |

Re: [PATCH v3] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-04-25 Thread Andrew Cooper
On 25/04/2024 3:26 pm, Jan Beulich wrote: > Much like was recently done for setting entry vector, and along the > lines of what we already had in handle_exception_saved, avoid 32-bit > immediates where 8-bit ones do. Reduces .text.entry size by 16 bytes in > my non-CET reference build, while in my

Re: [PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

2024-04-25 Thread Jan Beulich
On 17.04.2024 12:04, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/page.h > +++ b/xen/arch/ppc/include/asm/page.h > @@ -4,7 +4,7 @@ > > #include > > -#include > +#include > #include This wants to move up into the xen/*.h group then, like you have done ... > ---

Re: [PATCH net] xen-netfront: Add missing skb_mark_for_recycle

2024-04-25 Thread Greg KH
On Thu, Apr 25, 2024 at 02:39:38PM +0100, George Dunlap wrote: > Greg, > > We're issuing an XSA for this; can you issue a CVE? To ask for a cve, please contact c...@kernel.org as per our documentation. Please provide the git id of the commit you wish to have the cve assigned to. thanks, greg

[libvirt test] 185793: tolerable all pass - PUSHED

2024-04-25 Thread osstest service owner
flight 185793 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/185793/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185783 test-amd64-amd64-libvirt 15

Re: [PATCH v4 1/4] xen-livepatch: fix parameter name parsing

2024-04-25 Thread Ross Lagerwall
On Wed, Apr 24, 2024 at 9:20 AM Roger Pau Monne wrote: > > It's incorrect to restrict strncmp to the length of the command line input > parameter, as then a user passing a rune like: > > % xen-livepatch up foo.livepatch > > Would match against the "upload" command, because the string comparison

Re: [PATCH 02/15] xen/arm/gic: Enable interrupt assignment to running VM

2024-04-25 Thread Julien Grall
Hi, On 25/04/2024 08:06, Henry Wang wrote: Hi Julien, On 4/24/2024 8:58 PM, Julien Grall wrote: Hi Henry, On 24/04/2024 04:34, Henry Wang wrote: From: Vikram Garhwal Enable interrupt assign/remove for running VMs in CONFIG_OVERLAY_DTB. Currently, irq_route and mapping is only allowed at

[PATCH v3] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-04-25 Thread Jan Beulich
Much like was recently done for setting entry vector, and along the lines of what we already had in handle_exception_saved, avoid 32-bit immediates where 8-bit ones do. Reduces .text.entry size by 16 bytes in my non-CET reference build, while in my CET reference build section size doesn't change

Re: [PATCH net] xen-netfront: Add missing skb_mark_for_recycle

2024-04-25 Thread George Dunlap
Greg, We're issuing an XSA for this; can you issue a CVE? Thanks, -George Dunlap On Tue, Apr 2, 2024 at 9:25 PM Arthur Borsboom wrote: > After having a better look, I have found the patch in linux-next > > >

Re: [XEN PATCH] automation/eclair: reorganize pipelines

2024-04-25 Thread Nicola Vetrini
On 2024-04-25 11:40, Federico Serafini wrote: On 25/04/24 02:06, Stefano Stabellini wrote: On Tue, 23 Apr 2024, Federico Serafini wrote: From: Simone Ballarin Introduce accepted_guidelines.sh: a script to autogenerate the configuration file accepted.ecl from docs/misra/rules.rst which

Re: [PATCH] VMX: no open-coding in vmx_get_cpl()

2024-04-25 Thread Andrew Cooper
On 25/04/2024 2:27 pm, Jan Beulich wrote: > Neither X86_SEG_AR_DPL nor MASK_EXTR() should really be avoided here, > using literal number instead. > > No difference in generated code (with gcc13 at least). > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooepr

Re: [PATCH v2 2/2] x86/spec: adjust logic to logic that elides lfence

2024-04-25 Thread Andrew Cooper
On 18/04/2024 4:52 pm, Roger Pau Monne wrote: > It's currently too restrictive by just checking whether there's a BHB clearing > sequence selected. It should instead check whether BHB clearing is used on > entry from PV or HVM specifically. > > Switch to use opt_bhb_entry_{pv,hvm} instead, and

[PATCH] VMX: no open-coding in vmx_get_cpl()

2024-04-25 Thread Jan Beulich
Neither X86_SEG_AR_DPL nor MASK_EXTR() should really be avoided here, using literal number instead. No difference in generated code (with gcc13 at least). Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1192,7 +1192,7 @@ unsigned int

[linux-linus test] 185791: regressions - FAIL

2024-04-25 Thread osstest service owner
flight 185791 linux-linus real [real] flight 185796 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185791/ http://logs.test-lab.xenproject.org/osstest/logs/185796/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[RFC PATCH 2/2] xen/arm: Rework dt_unreserved_regions to avoid recursion

2024-04-25 Thread Luca Fancellu
The function dt_unreserved_regions is currently using recursion to compute the non overlapping ranges of a passed region against the reserved memory banks, in the spirit of removing the recursion to improve safety and also improve the scalability of the function, rework its code to use an

[RFC PATCH 0/2] xen/arm: Remove recursion from dt_unreserved_regions

2024-04-25 Thread Luca Fancellu
Hi, this is an RFC that is exploiting the new 'struct membank' interface introduced here 2209c1e35b479dff8ed3d3161001ffdefa0a704e ("xen/arm: Introduce a generic way to access memory bank structures") to start removing recursion from some function, in this serie the dt_unreserved_regions is

[RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem

2024-04-25 Thread Luca Fancellu
Currently the code is listing device tree reserve map regions as reserved memory for Xen, but they are not added into bootinfo.reserved_mem and they are fetched in multiple places using the same code sequence, causing duplication. Fix this by adding them to the bootinfo.reserved_mem at early

Re: [PATCH v2 1/2] x86/spec: fix reporting of BHB clearing usage from guest entry points

2024-04-25 Thread Andrew Cooper
On 18/04/2024 4:52 pm, Roger Pau Monne wrote: > Reporting whether the BHB clearing on entry is done for the different domains > types based on cpu_has_bhb_seq is incorrect, as that variable signals whether I'd prefer s/incorrect/unhelpful/ here. As pointed out, it's currently like IBPB-entry in

Re: [PATCH v4 3/4] livepatch: refuse to resolve symbols that belong to init sections

2024-04-25 Thread Roger Pau Monné
On Wed, Apr 24, 2024 at 10:19:56AM +0200, Roger Pau Monne wrote: > Livepatch payloads containing symbols that belong to init sections can only > lead to page faults later on, as by the time the livepatch is loaded init > sections have already been freed. > > Refuse to resolve such symbols and

Re: [PATCH v5 2/7] x86/msi: Extend per-domain/device warning mechanism

2024-04-25 Thread Jan Beulich
On 13.03.2024 16:16, Marek Marczykowski-Górecki wrote: > The arch_msix struct had a single "warned" field with a domid for which > warning was issued. Upcoming patch will need similar mechanism for few > more warnings, so change it to save a bit field of issued warnings. > > Signed-off-by: Marek

Re: [PATCH v5 3/7] x86/hvm: Allow access to registers on the same page as MSI-X table

2024-04-25 Thread Jan Beulich
On 13.03.2024 16:16, Marek Marczykowski-Górecki wrote: > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > on the same page as MSI-X table. Device model (especially one in > stubdomain) cannot really handle those, as direct writes to that page is > refused (page is on the

[xen-unstable-smoke test] 185795: tolerable all pass - PUSHED

2024-04-25 Thread osstest service owner
flight 185795 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185795/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v5 1/7] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2024-04-25 Thread Jan Beulich
On 13.03.2024 16:16, Marek Marczykowski-Górecki wrote: > QEMU needs to know whether clearing maskbit of a vector is really > clearing, or was already cleared before. Currently Xen sends only > clearing that bit to the device model, but not setting it, so QEMU > cannot detect it. Because of that,

[XEN PATCH] MAINTAINERS: Update my email address

2024-04-25 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d1850c134d..6ba7d2765f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -208,7 +208,7 @@ Maintainers List (try to look for most precise areas

Re: [PATCH v1] tools/ocaml: fix warnings

2024-04-25 Thread Christian Lindig
> On 27 Mar 2024, at 16:30, Edwin Török wrote: > > Do not rely on the string values of the `Failure` exception, > but use the `_opt` functions instead. > > Signed-off-by: Edwin Török > --- > tools/ocaml/xenstored/config.ml | 20 +++- > 1 file changed, 11 insertions(+), 9

Re: [PATCH 3/7] tools/xl: Add max_altp2m parameter

2024-04-25 Thread Jan Beulich
On 25.04.2024 10:51, Petr Beneš wrote: > On Thu, Apr 25, 2024 at 8:19 AM Jan Beulich wrote: >> >> On 24.04.2024 22:42, Petr Beneš wrote: >>> Introduce a new max_altp2m parameter to control the maximum number of altp2m >>> views a domain can use. By default, if max_altp2m is unspecified and altp2m

Re: [PATCH] svm: Fix MISRA 8.2 violation

2024-04-25 Thread Jan Beulich
On 25.04.2024 11:12, George Dunlap wrote: > Misra 8.2 requires named parameters in prototypes. Use the name from > the implementaiton. > > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). > > Signed-off-by: George Dunlap Acked-by: Jan Beulich

Re: [XEN PATCH] automation/eclair: reorganize pipelines

2024-04-25 Thread Federico Serafini
On 25/04/24 02:06, Stefano Stabellini wrote: On Tue, 23 Apr 2024, Federico Serafini wrote: From: Simone Ballarin Introduce accepted_guidelines.sh: a script to autogenerate the configuration file accepted.ecl from docs/misra/rules.rst which enables all accepted guidelines. Introduce

[PATCH] svm: Fix MISRA 8.2 violation

2024-04-25 Thread George Dunlap
Misra 8.2 requires named parameters in prototypes. Use the name from the implementaiton. Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit"). Signed-off-by: George Dunlap --- CC: Andrew Cooper CC: Jan Beulich CC: Roger Pau Monne CC: Nicola Vetrini ---

[ANNOUNCE] Call for agenda items - May 2024 Community Call

2024-04-25 Thread Kelly Choi
Hi all, Please add your proposed agenda items below. https://cryptpad.fr/pad/#/2/pad/edit/FluG1Qk1UTGr3CdvJBXTk6AF/ If any action items are missing or have been resolved, please add/remove them from the sheet. *CALL LINK: https://meet.jit.si/XenProjectCommunityCall

Re: [PATCH 4/7] tools/ocaml: Add max_altp2m parameter

2024-04-25 Thread Christian Lindig
> On 24 Apr 2024, at 21:42, Petr Beneš wrote: > > From: Petr Beneš > > Allow developers using the OCaml bindings to set the max_altp2m parameter. > > Signed-off-by: Petr Beneš > --- > tools/ocaml/libs/xc/xenctrl.ml | 1 + > tools/ocaml/libs/xc/xenctrl.mli | 1 + >

Re: [PATCH 3/7] tools/xl: Add max_altp2m parameter

2024-04-25 Thread Petr Beneš
On Thu, Apr 25, 2024 at 8:19 AM Jan Beulich wrote: > > On 24.04.2024 22:42, Petr Beneš wrote: > > Introduce a new max_altp2m parameter to control the maximum number of altp2m > > views a domain can use. By default, if max_altp2m is unspecified and altp2m > > is > > enabled, the value is set to

Re: [PATCH 1/7] x86/p2m: Add braces for better code clarity

2024-04-25 Thread Petr Beneš
On Thu, Apr 25, 2024 at 8:21 AM Jan Beulich wrote: > > On 24.04.2024 22:41, Petr Beneš wrote: > > From: Petr Beneš > > > > No functional change. > > > > Signed-off-by: Petr Beneš > > Hmm. I don't really mind the extra braces, but I also don't really see a need. > IOW this is not an objection,

Re: [PATCH] arm/vpci: make prefetchable mem 64 bit

2024-04-25 Thread Rahul Singh
Hi Stewart, > On 24 Apr 2024, at 5:27 PM, Stewart Hildebrand > wrote: > > The vPCI prefetchable memory range is >= 4GB, so the memory space flags > should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of > the field. > > [1]

Re: [PATCH v3] xen/x86/pvh: handle ACPI RSDT table in PVH Dom0 build

2024-04-25 Thread Roger Pau Monné
On Thu, Apr 25, 2024 at 09:26:59AM +0200, Jan Beulich wrote: > On 25.04.2024 09:10, Roger Pau Monné wrote: > > On Thu, Apr 25, 2024 at 08:12:09AM +0200, Jan Beulich wrote: > >> On 24.04.2024 21:18, Daniel P. Smith wrote: > >>> @@ -1089,6 +1098,9 @@ static int __init pvh_setup_acpi_xsdt(struct

Re: [PATCH v3] xen/x86/pvh: handle ACPI RSDT table in PVH Dom0 build

2024-04-25 Thread Jan Beulich
On 25.04.2024 09:10, Roger Pau Monné wrote: > On Thu, Apr 25, 2024 at 08:12:09AM +0200, Jan Beulich wrote: >> On 24.04.2024 21:18, Daniel P. Smith wrote: >>> @@ -1089,6 +1098,9 @@ static int __init pvh_setup_acpi_xsdt(struct domain >>> *d, paddr_t madt_addr, >>> xsdt->header = *table; >>>

Re: [PATCH v3] xen/x86/pvh: handle ACPI RSDT table in PVH Dom0 build

2024-04-25 Thread Roger Pau Monné
On Thu, Apr 25, 2024 at 08:12:09AM +0200, Jan Beulich wrote: > On 24.04.2024 21:18, Daniel P. Smith wrote: > > @@ -1089,6 +1098,9 @@ static int __init pvh_setup_acpi_xsdt(struct domain > > *d, paddr_t madt_addr, > > xsdt->header = *table; > > acpi_os_unmap_memory(table, sizeof(*table));

Re: [PATCH v3] xen/x86/pvh: handle ACPI RSDT table in PVH Dom0 build

2024-04-25 Thread Roger Pau Monné
On Wed, Apr 24, 2024 at 03:18:26PM -0400, Daniel P. Smith wrote: > From: Stefano Stabellini > > Xen always generates as XSDT table even if the firmware provided an RSDT > table. ^ only As providing an RSDT doesn't exclude from a XSDT

Re: [PATCH 02/15] xen/arm/gic: Enable interrupt assignment to running VM

2024-04-25 Thread Henry Wang
Hi Julien, On 4/24/2024 8:58 PM, Julien Grall wrote: Hi Henry, On 24/04/2024 04:34, Henry Wang wrote: From: Vikram Garhwal Enable interrupt assign/remove for running VMs in CONFIG_OVERLAY_DTB. Currently, irq_route and mapping is only allowed at the domain creation. Adding exception for

Re: [PATCH 14/15] add a domU script to fetch overlays and applying them to linux

2024-04-25 Thread Henry Wang
Hi Jan, On 4/25/2024 2:46 PM, Jan Beulich wrote: On 25.04.2024 02:54, Henry Wang wrote: On 4/24/2024 2:16 PM, Jan Beulich wrote: On 24.04.2024 05:34, Henry Wang wrote: From: Vikram Garhwal Introduce a shell script that runs in the background and calls get_overlay to retrive overlays and

Re: [PATCH 14/15] add a domU script to fetch overlays and applying them to linux

2024-04-25 Thread Jan Beulich
On 25.04.2024 02:54, Henry Wang wrote: > On 4/24/2024 2:16 PM, Jan Beulich wrote: >> On 24.04.2024 05:34, Henry Wang wrote: >>> From: Vikram Garhwal >>> >>> Introduce a shell script that runs in the background and calls >>> get_overlay to retrive overlays and add them (or remove them) to Linux

Re: [linux-linus test] 185785: regressions - FAIL

2024-04-25 Thread Jan Beulich
On 25.04.2024 03:38, osstest service owner wrote: > flight 185785 linux-linus real [real] > http://logs.test-lab.xenproject.org/osstest/logs/185785/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-armhf-armhf-xl-raw 8

Re: [PATCH 2/7] x86/hap: Refactor boolean field assignments

2024-04-25 Thread Jan Beulich
On 24.04.2024 22:42, Petr Beneš wrote: > From: Petr Beneš > > No functional change. > > Signed-off-by: Petr Beneš Acked-by: Jan Beulich

Re: [PATCH 1/7] x86/p2m: Add braces for better code clarity

2024-04-25 Thread Jan Beulich
On 24.04.2024 22:41, Petr Beneš wrote: > From: Petr Beneš > > No functional change. > > Signed-off-by: Petr Beneš Hmm. I don't really mind the extra braces, but I also don't really see a need. IOW this is not an objection, but it'll want to be someone else (if anyone) to ack this. Jan > ---

Re: [PATCH 3/7] tools/xl: Add max_altp2m parameter

2024-04-25 Thread Jan Beulich
On 24.04.2024 22:42, Petr Beneš wrote: > Introduce a new max_altp2m parameter to control the maximum number of altp2m > views a domain can use. By default, if max_altp2m is unspecified and altp2m is > enabled, the value is set to 10, reflecting the legacy behavior. Apart from the public header

Re: [PATCH] arm/vpci: make prefetchable mem 64 bit

2024-04-25 Thread Michal Orzel
Hi Stewart, On 24/04/2024 18:27, Stewart Hildebrand wrote: > The vPCI prefetchable memory range is >= 4GB, so the memory space flags > should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of NIT: would be beneficial to provide chapter (in this case 2.2.1.1) > the field. > > [1]

Re: [PATCH v3] xen/x86/pvh: handle ACPI RSDT table in PVH Dom0 build

2024-04-25 Thread Jan Beulich
On 24.04.2024 21:18, Daniel P. Smith wrote: > From: Stefano Stabellini > > Xen always generates as XSDT table even if the firmware provided an RSDT > table. > Copy the RSDT header from the firmware table, adjusting the signature, for the > XSDT table when not provided by the firmware. > >