Make declarations consistent, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/io.h b/xen/arch/x86/include/asm/io.h
index 92b784a861..8c8a15bd06 100644
--- a/xen
Make function delcaration consistent with the corresponding definition.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/genapic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/genapic.h
b/xen/arch/x86/include
This serie addresses some violations of MISRA C:2012 Rules 8.2 and 8.3
for x86-64.
Federico Serafini (4):
x86/genapic: address a violation of MISRA C:2012 Rule 8.3
x86/io: address violations of MISRA C:2012 Rule 8.3
x86/io_apic: address violations of MISRA C:2012 Rules 8.2 and 8.3
xen
Add missing parameter names and make function declarations and
definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/io_apic.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/include/asm/io_apic.h
b/xen
Make function declarations and definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/hap.h | 2 +-
xen/include/xen/vpci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/include/asm/hap.h b/xen
Add missing parameter names and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini
---
xen/include/xen/pci.h | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/xen/include/xen/pci.h b/xen
On 11/09/23 10:42, Jan Beulich wrote:
On 11.09.2023 10:15, Federico Serafini wrote:
Add missing parameter names and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini
Since formally correct:
Acked-by: Jan Beulich
Nevertheless
On 13/09/23 15:14, Julien Grall wrote:
Hi,
On 13/09/2023 13:41, Federico Serafini wrote:
On 13/09/23 14:29, Federico Serafini wrote:
Add missing parameter names and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini
Add missing parameter names and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini
---
xen/drivers/passthrough/amd/iommu.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/drivers/passthrough/amd/iommu.h
b
Add missing parameter names and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini
---
xen/include/xen/libelf.h | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/xen/include/xen
On 13/09/23 14:29, Federico Serafini wrote:
Add missing parameter names and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini
There is a typo in the patch title (RUles), please correct on commit.
Reviewed-by: Federico Serafini
Make function declarations consistent with the corresponding
definitions to address violations of MISRA C:2012 Rule 8.3.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/hap.h| 2 +-
xen/arch/x86/include/asm/shadow.h | 2 +-
2 files changed, 2 insertions
Make function declaration consistent with the corresponding definition.
No functional change.
Signed-off-by: Federico Serafini
---
xen/include/xen/vpci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 0b8a2a3c74
On 16/10/23 10:53, Julien Grall wrote:
Hi,
On 13/10/2023 16:24, Federico Serafini wrote:
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/include/asm/gic.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Make function definition and declaration consistent and emphasize that
the formal parameter is deliberately not used.
No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- improved code format.
---
xen/drivers/passthrough/amd/iommu_init.c | 5 -
1 file changed, 4
On 27/10/23 09:07, Jan Beulich wrote:
On 27.10.2023 01:00, Stefano Stabellini wrote:
On Thu, 26 Oct 2023, Federico Serafini wrote:
@@ -675,16 +673,16 @@ static int __init cpufreq_cmdline_parse(const char *s,
const char *e)
static int cf_check cpu_callback(
struct notifier_block
On 27/10/23 15:57, Jan Beulich wrote:
On 26.10.2023 14:09, Federico Serafini wrote:
--- a/xen/drivers/cpufreq/cpufreq.c
+++ b/xen/drivers/cpufreq/cpufreq.c
@@ -457,14 +457,14 @@ static void print_PPC(unsigned int platform_limit)
printk("\t_PPC: %d\n", platform_limit);
On 30/10/23 16:01, Jan Beulich wrote:
On 25.10.2023 15:01, Federico Serafini wrote:
Make function definition and declaration consistent and emphasize that
the formal parameter is deliberately not used.
Coming back to my earlier objection: Did you consider alternatives? Best
would of course
Remove the generic implementation of memcpy(), memmove() and
memset() from the x86 build since a version written in asm is present.
This addesses violations of MISRA C:2012 Rule 8.6 ("An identifier with
external linkage shall have exactly one external definition").
Signed-off-by
Add missing parameter names and make function declarations and
definitions consistent.
Mismatches between parameter names "count" and "n" are resolved
in favor of "n", being the same name used by the C standard.
No functional change.
Signed-off-by: Federi
Make function definitions and declarations consistent.
No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- removed unwanted changes to cpu_callback();
- improved code style.
---
xen/arch/x86/x86_64/cpu_idle.c | 5 +--
xen/arch/x86/x86_64/cpufreq.c | 6 ++--
xen
Make function defintions and declarations consistent.
No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- use 'ptr' do denote a const void * parameter.
---
xen/arch/arm/domain_page.c| 10 +-
xen/include/xen/domain_page.h | 12 ++--
2 files changed, 11
Signed-off-by: Federico Serafini
---
Changes in v2:
- removed set_px_pminfo() from the scope of the deviation;
- fixed tag of the commit.
---
automation/eclair_analysis/ECLAIR/deviations.ecl | 4
docs/misra/deviations.rst| 6 ++
2 files changed, 10 insertions(+)
Make function definitions and declarations consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/x86_64/cpu_idle.c | 5 ++--
xen/arch/x86/x86_64/cpufreq.c | 6 ++--
xen/drivers/cpufreq/cpufreq.c | 52 --
xen/include/xen/pmstat.h
On 26/10/23 12:25, Julien Grall wrote:
Hi,
On 26/10/2023 11:04, Federico Serafini wrote:
Update ECLAIR configuration to deviate Rule 8.3 ("All declarations of
an object or function shall use the same names and type qualifiers")
for the following functions: guest_walk_tables_[0-
On 26/10/23 15:54, Julien Grall wrote:
Hi,
On 26/10/2023 13:13, Federico Serafini wrote:
On 26/10/23 12:25, Julien Grall wrote:
Hi,
On 26/10/2023 11:04, Federico Serafini wrote:
Update ECLAIR configuration to deviate Rule 8.3 ("All declarations of
an object or function shall use the
Make function declarations and definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
Changes in v3:
- removed changes involving types with fixed/unfixed width;
- uniformed parameter names of compat_memory_op() with {do,hvm}_memory_op().
---
Changes in v2:
- change
On 22/09/23 10:29, Jan Beulich wrote:
On 21.09.2023 17:05, Federico Serafini wrote:
Make function declaration and definition consistent.
No fuctional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/emul-i8254.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Make function declaration and definition consistent.
No fuctional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/emul-i8254.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c
index 41ec4a1ef1..c48a3606a2 100644
Make object declarations consistent. No functional change.
Signed-off-by: Federico Serafini
---
xen/include/xen/numa.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 29b8c2df89..287e81ff66 100644
--- a/xen/include/xen
Drop bool_t to make function declaration and definition consistent and address
a violation of MISRA C:2012 Rule 8.3.
No functional change.
Signed-off-by: Federico Serafini
---
xen/drivers/video/vesa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/video/vesa.c b
Make function declaration and definition consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/xstate.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c
index f442610fc5..cf94761d05 100644
Make function declaration and definition consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/psr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/psr.h b/xen/arch/x86/include/asm/psr.h
index c2257da7fc
This series contains small and uncontroversial patches to address some
violations of Rule 8.3.
No functonal changes are introduced.
Federico Serafini (4):
video/vesa: drop bool_t
x86/uaccess: address violations of MISRA C:2012 Rule 8.3
x86/xstate: address a violation of MISRA C:2012 Rule
Make function declarations and definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/uaccess.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/include/asm/uaccess.h
b/xen/arch/x86/include/asm/uaccess.h
On 29/09/23 10:56, Federico Serafini wrote:
Drop bool_t to make function declaration and definition consistent and address
a violation of MISRA C:2012 Rule 8.3.
No functional change.
Signed-off-by: Federico Serafini
---
xen/drivers/video/vesa.c | 2 +-
1 file changed, 1 insertion(+), 1
Add missing parameter names and make function declarations and
definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/msi.h | 22 +++---
xen/arch/x86/msi.c | 2 +-
2 files changed, 12 insertions(+), 12 deletions
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/irq.c | 3 ++-
xen/arch/x86/include/asm/irq.h | 4 ++--
xen/arch/x86/irq.c | 8
xen/include/xen/irq.h | 21 +++--
4 files changed, 19
Update the configuration of ECLAIR to deviate some violations of Rule
10.1 in accordance with docs/misra/rules.rst.
Signed-off-by: Federico Serafini
---
automation/eclair_analysis/ECLAIR/deviations.ecl | 12
1 file changed, 12 insertions(+)
diff --git a/automation/eclair_analysis
Make function declaration and definition consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/paging.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/paging.h
b/xen/arch/x86/include/asm/paging.h
index
Make function declarations and definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/mem_access.h | 2 +-
xen/arch/x86/mm/mem_access.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/include/asm
Make function declarations and definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/domain_page.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/xen/arch/x86/domain_page.c b/xen/arch/x86
Add missing parameter names and make function declarations and definitions
consistent. No functional change.
Signed-off-by: Federico Serafini
---
Changes in v3:
- used "nf" as parameter name to denote "new flags".
---
Changes in v2:
- propagated changes to the arm code.
--
On 08/09/23 11:13, Federico Serafini wrote:
Make function declaration consistent with the corresponding definition.
No functional change.
Signed-off-by: Federico Serafini
---
xen/include/xen/vpci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/xen/vpci.h b
Remove forward declarations, including one that violates MISRA C Rule
8.3 ("All declarations of an object or function shall use the same
names and type qualifiers"), and re-order functions.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/emul-i82
On 28/09/23 08:25, Jan Beulich wrote:
On 27.09.2023 17:09, Federico Serafini wrote:
Make function declarations and definitions consistent.
No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/domain_page.c | 36 ++--
1 file changed, 18
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/common/sched/private.h | 93 --
1 file changed, 49 insertions(+), 44 deletions(-)
diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h
index
Julien,
Hi Bertrand,
On 16 Oct 2023, at 11:07, Julien Grall wrote:
Hi,
On 13/10/2023 16:24, Federico Serafini wrote:
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini
---
xen/drivers/passthrough/arm/smmu.c | 6 +++---
This file is using the Linux coding
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/hpet.c | 2 +-
xen/arch/x86/include/asm/hpet.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index 79c07f6a9e
Add missing parameter name. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/cpu/mcheck/mcaction.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/cpu/mcheck/mcaction.h
b/xen/arch/x86/cpu/mcheck/mcaction.h
index 5cbe558fb0..9cb2ad6c9f
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/cpu/mcheck/vmce.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/cpu/mcheck/vmce.h b/xen/arch/x86/cpu/mcheck/vmce.h
index 2e9b32a9bd..a9a325f776 100644
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/cpu/mcheck/mctelem.c | 2 +-
xen/arch/x86/cpu/mcheck/mctelem.h | 25 +
2 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/xen/arch/x86/cpu/mcheck/mctelem.c
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/domain.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/xen/arch/x86/include/asm/domain.h
b/xen/arch/x86/include/asm/domain.h
index
This patch series addresses some of the violations of Rule 8.2 adding the
missing parameter names.
Federico Serafini (7):
x86/mctelem: address violations of MISRA C:2012 Rule 8.2
x86/mtrr: address violation of MISRA C:2012 Rule 8.2
x86/domain: address violations of MISRA C:2012 Rule 8.2
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/cpuidle.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/xen/arch/x86/include/asm/cpuidle.h
b/xen/arch/x86/include/asm/cpuidle.h
index 3edd7a75d2
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/mtrr.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/arch/x86/include/asm/mtrr.h b/xen/arch/x86/include/asm/mtrr.h
index 14246e3387..1d2744eceb
On 16/10/23 17:26, Jan Beulich wrote:
On 03.10.2023 17:24, Federico Serafini wrote:
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5901,17 +5901,17 @@ int destroy_xen_mappings(unsigned long s, unsigned long
e)
* a problem.
*/
void init_or_livepatch modify_xen_mappings_lite
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- fixed names.
---
xen/arch/arm/include/asm/cpufeature.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/include/asm/cpufeature.h
b/xen/arch/arm
Add missing parameter names and remove inconsistencies between GICv3
and GICv2. No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- switched parameter names of gicv3_write_lr().
---
xen/arch/arm/gic-v3.c | 22 +++---
xen/arch/arm/include/asm
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2:
- added parameter names in accordance with schedulers in xen/common/sched/*;
- improved comment format.
---
xen/common/sched/private.h | 99 --
1 file
This patch series addresses some of the violations of Rule 8.2 adding the
missing parameter names.
Federico Serafini (8):
x86/hvm: address violations of MISRA C:2012 Rule 8.2
x86/mmconfig: address violations of MISRA C:2012 Rule 8.2
x86/vpmu: address a violation of MISRA C:2012 Rule 8.2
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/platform_hypercall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/platform_hypercall.c
b/xen/arch/x86/platform_hypercall.c
index 9469de9045..c1ab552c57
Add missing parameter name. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/pci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h
index f4a58c8acf..542e284f14 100644
--- a/xen
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/physdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
index 2f1d955a96..47c4da0af7 100644
--- a/xen/arch/x86
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/x86_64/mmconfig.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/x86_64/mmconfig.h b/xen/arch/x86/x86_64/mmconfig.h
index 2d49fc79a0..3da4b21e9b 100644
Add missing parameter name. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/vpmu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h
index b165acc6c2..7858aec6ca 100644
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
---
xen/drivers/passthrough/x86/hvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/drivers/passthrough/x86/hvm.c
b/xen/drivers/passthrough/x86/hvm.c
index 8175ba629a..d3627e4af7
Add missing parameter name. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index c107f40c62..1d40d82c5a 100644
--- a/xen/arch/x86/sysctl.c
+++ b
Add missing parameter name. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/smp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/include/asm/smp.h b/xen/arch/x86/include/asm/smp.h
index 41a3b6a0da..5c2de4920f 100644
--- a/xen
Add missing parameter name and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini
---
xen/arch/x86/include/asm/p2m.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/arch/x86/include/asm/p2m.h b/xen
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/include/asm/setup.h | 5 +++--
xen/arch/arm/setup.c | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/include/asm/arm32/cmpxchg.h | 2 +-
xen/arch/arm/include/asm/arm64/cmpxchg.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/include/asm/arm32/cmpxchg.h
b
This patch series addresses some of the violations of Rule 8.2 adding the
missing parameter names.
Federico Serafini (10):
arm/gic: address violations of MISRA C:2012 Rule 8.2
arm/cpufeature: address violations of MISRA C:2012 Rule 8.2
arm/smpboot: address violations of MISRA C:2012 Rule
Add missing parameter names, no funtional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/include/asm/domain.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/include/asm/domain.h
b/xen/arch/arm/include/asm/domain.h
index 99e798..5fb8cd79c0
Add missing parameter name, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index ce89f16404..5aa14d4707 100644
--- a/xen/arch/arm/traps.c
+++ b/xen
Add missing parameter name, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/vgic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 05a009409a..cc38327701 100644
--- a/xen/arch/arm/vgic-v3.c
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/include/asm/gic.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h
index f1ef347edc..03f209529b
Add missing parameter name, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/arm64/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c
index 9637f42469..bf81d018b3 100644
--- a/xen/arch
Add missing parameter name, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/include/asm/p2m.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
index 940495d42b..9ad312bfb5 100644
--- a/xen
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini
---
xen/arch/arm/include/asm/cpufeature.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/include/asm/cpufeature.h
b/xen/arch/arm/include/asm/cpufeature.h
index
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini
---
xen/drivers/passthrough/arm/smmu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/drivers/passthrough/arm/smmu.c
b/xen/drivers/passthrough/arm/smmu.c
index 71799064f8
ot;stmt(operator(shl||shr||shl_assign||shr_assign))",
+ "any()"}
+-doc_end
These two deviations for Rule 10.1 have been already proposed by me
in the following (not committed) patch:
https://lists.xenproject.org/archives/html/xen-devel/2023-10/msg00146.html
So, I would suggest dr
Change parameter name and emphasize that it is deliberately not used through a
comment followed by the statement '(void) data;'.
This also addresses a violation of MISRA C:2012 Rule 2.7 ("A function should
not contain unused parameters").
No functional change.
Signed-off-by: Federic
nal change.
Signed-off-by: Federico Serafini
---
I had a discussion with Jan about the reasons behind the choice of parameter
name 'walk' for the definitions of functions guest_walk_tables_[0-9]+_levels()
and the parameter name 'pfec' for the corresponding declarations.
Also for the function set
On 24/10/23 16:32, Jan Beulich wrote:
On 24.10.2023 15:22, Federico Serafini wrote:
Update ECLAIR configuration to deviate Rule 8.3 ("All declarations of
an object or function shall use the same names and type qualifiers")
for the following functions:
- set_px_pminfo();
- guest_walk_t
Make function declarations and definitions consistent to address
violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or
function shall use the same names and type qualifiers").
No functional change.
Signed-off-by: Federico Serafini
---
Changes in v2
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
Changes in v2:
- fixed indentation.
---
docs/misra/exclude-list.json | 12
1 file changed, 12 insertions(+)
diff --git a/docs/misra/exclude
On 17/08/23 11:57, Julien Grall wrote:
Hi,
On 17/08/2023 10:55, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
Changes in v2:
- fixed indentation.
What's the difference
Add files to exclude-list.json and adapt the ECLAIR configuration to keep
track of the changes.
Federico Serafini (2):
automation/eclair: update configuration
misra: add more entires to exclude-list.json
.../eclair_analysis/ECLAIR/deviations.ecl | 29
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
docs/misra/exclude-list.json | 12
1 file changed, 12 insertions(+)
diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json
Mark more files as "adopted" and configure Rule 8.3 in order to:
- exclude violations involving the type ret_t;
- exclude violations involving both an internal and an external file,
thus avoiding touching adopted code.
Signed-off-by: Federico Serafini
---
.../eclair_analy
On 17/08/23 12:02, Federico Serafini wrote:
On 17/08/23 11:57, Julien Grall wrote:
Hi,
On 17/08/2023 10:55, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
Changes in v2
On 17/08/23 11:42, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
docs/misra/exclude-list.json | 12
1 file changed, 12 insertions(+)
diff --git a/docs/misra
On 10/10/23 03:26, Henry Wang wrote:
Hi,
On Oct 10, 2023, at 09:25, Stefano Stabellini wrote:
On Mon, 9 Oct 2023, Federico Serafini wrote:
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini
Reviewed-by: Stefano Stabellini
Release-acked-by: Henry Wang
Rule 8.3.
No functional change.
Signed-off-by: Federico Serafini
---
Changes in v4:
- description improved.
---
Changes in v3:
- applied changes discussed in the following thread
https://lists.xenproject.org/archives/html/xen-devel/2023-08/msg00318.html
Changes in v2:
- memset() adju
Update ECLAIR configuration to take into account the standard search
procedure adopted by Unix linkers.
Signed-off-by: Federico Serafini
---
automation/eclair_analysis/ECLAIR/deviations.ecl | 9 +
1 file changed, 9 insertions(+)
diff --git a/automation/eclair_analysis/ECLAIR
On 10/11/23 13:41, Jan Beulich wrote:
On 10.11.2023 12:23, Federico Serafini wrote:
--- a/automation/eclair_analysis/ECLAIR/deviations.ecl
+++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
@@ -214,6 +214,15 @@ definition is compiled-out or optimized-out by the
compiler)"
-config=
On 08/11/23 17:04, Julien Grall wrote:
Hi,
On 08/11/2023 15:42, Federico Serafini wrote:
Add missing parameter name "regs" and introduce function type
bug_fn_t: this improves readability and helps to validate that the
function passed to run_in_exception_handle() has the expected
Add missing parameter name "regs" and introduce function type
bug_fn_t: this improves readability and helps to validate that the
function passed to run_in_exception_handle() has the expected
prototype.
No functional change.
Suggested-by: Julien Grall
Signed-off-by: Federico Serafini
-
On 08/11/23 17:30, Julien Grall wrote:
Hi Federico,
On 08/11/2023 16:21, Federico Serafini wrote:
On 08/11/23 17:04, Julien Grall wrote:
Hi,
On 08/11/2023 15:42, Federico Serafini wrote:
Add missing parameter name "regs" and introduce function type
bug_fn_t: this improves r
1 - 100 of 381 matches
Mail list logo
