Re: [Xen-devel] [PATCH 16/34] drivers/tee: convert put_page() to put_user_page*()

2019-08-02 Thread Jens Wiklander
, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Jens Wiklander > Signed-off-by: John Hubbard > --- > drivers/tee/tee_shm.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) Acked-by: Jens Wik

[PATCH] xen/arm: ffa: fix guest map RX/TX error code

2023-09-04 Thread Jens Wiklander
that the function is not implemented. Of all the other defined error codes, the least bad is FFA_RET_INVALID_PARAMETERS, so use that instead. Fixes: 38d81e7ccb11 ("xen/arm: ffa: support mapping guest RX/TX buffers") Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 2 +- 1 file

Re: [XEN PATCH v11 00/14] Xen FF-A mediator

2023-08-21 Thread Jens Wiklander
Hi Julien, On Fri, Aug 18, 2023 at 10:32 AM Julien Grall wrote: > > Hi Jens, > > On 31/07/2023 13:15, Jens Wiklander wrote: > > Jens Wiklander (14): > >xen/arm: ffa: add direct request support > >xen/arm: ffa: map SPMC rx/tx buffers > >xen/a

[PATCH v4 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-06-22 Thread Jens Wiklander
/output registers. This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 extended input/output registers") by Sudeep Holla from the Linux kernel The SMCCC version reported to the VM is bumped to 1.2 in order to support handling FF-A messages. Signed-off-by: Jens Wiklander

[PATCH v4 2/2] xen/arm: add FF-A mediator

2022-06-22 Thread Jens Wiklander
://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- SUPPORT.md|7 + tools/libs/light/libxl_arm.c |3 + tools/libs/light/libxl_types.idl |1 + tools/xl/xl_parse.c |3 + xen/arch/arm/Kconfig | 11 + xen

[PATCH v4 0/2] Xen FF-A mediator

2022-06-22 Thread Jens Wiklander
aging to resolve some merge conflicts as requested Jens Wiklander (2): xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers xen/arm: add FF-A mediator SUPPORT.md|7 + tools/libs/light/libxl_arm.c |3 + tools/libs/light/libxl_t

[PATCH 2/2] xen/arm: add FF-A mediator

2022-06-07 Thread Jens Wiklander
://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/Kconfig | 11 + xen/arch/arm/Makefile|1 + xen/arch/arm/domain.c| 10 + xen/arch/arm/ffa.c | 1624 ++ xen/arch/arm/vsmc.c | 17

[PATCH 0/2] Xen FF-A mediator

2022-06-07 Thread Jens Wiklander
Partition using FF-A as transport with this mediator. [1] https://developer.arm.com/documentation/den0077/latest Thanks, Jens Jens Wiklander (2): xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers xen/arm: add FF-A mediator xen/arch/arm/Kconfig | 11

[PATCH 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-06-07 Thread Jens Wiklander
/output registers. This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 extended input/output registers") by Sudeep Holla from the Linux kernel Signed-off-by: Jens Wiklander --- xen/arch/arm/arm64/smc.S| 43 + xen/arch/

Re: [PATCH v2 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-06-15 Thread Jens Wiklander
On Fri, Jun 10, 2022 at 05:41:33PM -0700, Stefano Stabellini wrote: > On Thu, 9 Jun 2022, Jens Wiklander wrote: > > SMCCC v1.2 AArch64 allows x0-x17 to be used as both parameter registers > > and result registers for the SMC and HVC instructions. > > > > Arm F

Re: [PATCH v2 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-06-15 Thread Jens Wiklander
On Wed, Jun 15, 2022 at 08:01:28PM +0100, Julien Grall wrote: > Hi, > > On 15/06/2022 16:58, Jens Wiklander wrote: > > On Fri, Jun 10, 2022 at 05:41:33PM -0700, Stefano Stabellini wrote: > > > > #endif /* __ASSEMBLY__ */ > > > > /* > > > &

Re: [PATCH v2 2/2] xen/arm: add FF-A mediator

2022-06-16 Thread Jens Wiklander
On Fri, Jun 10, 2022 at 06:23:52PM -0700, Stefano Stabellini wrote: > On Thu, 9 Jun 2022, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > The implementation is the bare minimum to be able

Re: [PATCH v2 2/2] xen/arm: add FF-A mediator

2022-06-16 Thread Jens Wiklander
arted with the minimum. We can as a future optimization address the problem with long running operations. > > Jens Wiklander writes: > > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > The implementation is the

Re: [PATCH v2 2/2] xen/arm: add FF-A mediator

2022-06-20 Thread Jens Wiklander
Hi Julien, On Fri, Jun 17, 2022 at 10:16 AM Julien Grall wrote: > > Hi Jens, > > On 16/06/2022 23:37, Jens Wiklander wrote: > > On Tue, Jun 14, 2022 at 07:47:18PM +, Volodymyr Babchuk wrote: > >> > >> Hello Jens, > >> > >> So

[PATCH v2 2/2] xen/arm: add FF-A mediator

2022-06-09 Thread Jens Wiklander
://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/Kconfig | 11 + xen/arch/arm/Makefile |1 + xen/arch/arm/domain.c | 10 + xen/arch/arm/ffa.c| 1624 + xen/arch/arm/include

[PATCH v2 0/2] Xen FF-A mediator

2022-06-09 Thread Jens Wiklander
Partition using FF-A as transport with this mediator. [1] https://developer.arm.com/documentation/den0077/latest Thanks, Jens v1->v2: * Rebased on staging to resolve some merge conflicts as requested Jens Wiklander (2): xen/arm: smccc: add support for SMCCCv1.2 extended input/out

[PATCH v2 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-06-09 Thread Jens Wiklander
/output registers. This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 extended input/output registers") by Sudeep Holla from the Linux kernel Signed-off-by: Jens Wiklander --- xen/arch/arm/arm64/smc.S | 43 xen/arch/arm/i

Re: [PATCH 0/2] Xen FF-A mediator

2022-06-08 Thread Jens Wiklander
On Wed, Jun 8, 2022 at 1:07 AM Stefano Stabellini wrote: > > On Tue, 7 Jun 2022, Stefano Stabellini wrote: > > On Tue, 7 Jun 2022, Jens Wiklander wrote: > > > Hi, > > > > > > This patch sets add a FF-A [1] mediator modeled after the TEE mediator > >

Re: [PATCH 0/2] Xen FF-A mediator

2022-06-07 Thread Jens Wiklander
Hi Stefano, On Tue, Jun 7, 2022 at 11:55 PM Stefano Stabellini wrote: > > On Tue, 7 Jun 2022, Jens Wiklander wrote: > > Hi, > > > > This patch sets add a FF-A [1] mediator modeled after the TEE mediator > > already present in Xen. The FF-A mediator implements

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-26 Thread Jens Wiklander
review in > multiple session/e-mail. > > On 22/06/2022 14:42, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > The implementation is the bare minimum to be able to c

Re: [PATCH v4 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-07-14 Thread Jens Wiklander
Hi Luca, On Fri, Jul 8, 2022 at 2:01 PM Luca Fancellu wrote: > > Hi Jens, > > > On 22 Jun 2022, at 14:42, Jens Wiklander wrote: > > > > SMCCC v1.2 AArch64 allows x0-x17 to be used as both parameter registers > > and result registers for the SMC and HVC i

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-29 Thread Jens Wiklander
Hi, On Thu, Jul 28, 2022 at 9:15 PM Julien Grall wrote: > > Hi, > > On 26/07/2022 07:17, Jens Wiklander wrote: > > On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote: > >> > >> Hi Jens, > >> > >> I haven't checked whether the FFA driver is

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-27 Thread Jens Wiklander
Hi Julien, On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote: > > Hi Jens, > > This is the second part of the review. > > On 22/06/2022 14:42, Jens Wiklander wrote: > > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, > > +

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-27 Thread Jens Wiklander
Hi Bertrand, On Thu, Jul 14, 2022 at 11:51 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Jun 2022, at 14:42, Jens Wiklander wrote: > > > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > >

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-15 Thread Jens Wiklander
ll split my review in multiple > session/e-mail. Thanks for the comments. It's going to take a bit longer than I first thought to go through and respond. I'll get back once I'm though it. Thanks, Jens > > On 22/06/2022 14:42, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] medi

[PATCH] optee: immediately free RPC buffers that are released by OP-TEE

2022-05-03 Thread Jens Wiklander
a new shared memory block. Fix this by freeing the internal command structure buffers first before informing the guest that the buffer can be freed. [1] 5b13eb1d978e ("optee: immediately free buffers that are released by OP-TEE") Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/op

Re: [PATCH v5 2/9] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h

2022-08-29 Thread Jens Wiklander
Hi Michal, On Wed, Aug 24, 2022 at 10:23 AM Michal Orzel wrote: > > Hi Jens, > > On 18/08/2022 12:55, Jens Wiklander wrote: > > Moves the two helper functions regpair_to_uint64() and > > uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm > > specif

[PATCH v5 0/9] Xen FF-A mediator

2022-08-18 Thread Jens Wiklander
the needed features are available before initializing the mediator * Rebased on staging as of 2022-06-20 v1->v2: * Rebased on staging to resolve some merge conflicts as requested Jens Wiklander (9): xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers xen/arm: m

[PATCH v5 2/9] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h

2022-08-18 Thread Jens Wiklander
Moves the two helper functions regpair_to_uint64() and uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm specific regs.h. Signed-off-by: Jens Wiklander --- xen/arch/arm/include/asm/regs.h | 12 xen/arch/arm/tee/optee.c| 11 --- 2 files changed, 12

[PATCH v5 1/9] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-08-18 Thread Jens Wiklander
er.arm.com/documentation/den0028/c/?lang=en Reviewed-by: Luca Fancellu Signed-off-by: Jens Wiklander --- xen/arch/arm/arm64/asm-offsets.c | 9 +++ xen/arch/arm/arm64/smc.S | 43 xen/arch/arm/include/asm/smccc.h | 40 + xen/arch/

[PATCH v5 5/9] xen/arm: ffa: map SPMC rx/tx buffers

2022-08-18 Thread Jens Wiklander
When initializing the FF-A mediator map the RX and TX buffers shared with the SPMC. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 57 +- 1 file changed

[PATCH v5 3/9] xen/arm: add a primitive FF-A mediator

2022-08-18 Thread Jens Wiklander
to use FF-A. This is loosely based on the TEE mediator framework and the OP-TEE mediator. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- SUPPORT.md| 7 + docs/man/xl.cfg.5.pod.in | 15 ++ tools/include/libxl.h

[PATCH v5 4/9] xen/arm: ffa: add direct request support

2022-08-18 Thread Jens Wiklander
Adds support for sending a FF-A direct request. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 119 + 1 file changed, 119 insertions(+) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm

[PATCH v5 9/9] xen/arm: ffa: support sharing memory

2022-08-18 Thread Jens Wiklander
FF-A version 1.1, but the guest is free to use version 1.0 or version 1.1. The implementation is the bare minimum to be able to communicate with OP-TEE running as an SPMC at S-EL1. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c

[PATCH v5 6/9] xen/arm: ffa: send guest events to Secure Partitions

2022-08-18 Thread Jens Wiklander
can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 192 - 1 file changed, 191 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index b1bf5538b111..a829379ad176 100644 --- a/xen/arch/arm/ffa.c +++ b/xen

[PATCH v5 8/9] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2022-08-18 Thread Jens Wiklander
in this case), so once it is done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 126 - 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/xen

[PATCH v5 7/9] xen/arm: ffa: support mapping guest RX/TX buffers

2022-08-18 Thread Jens Wiklander
Adds support in the mediator to map and unmap the RX and TX buffers provided by the guest using the two FF-A functions FFA_RXTX_MAP and FFA_RXTX_UNMAP. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c

Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator

2022-08-31 Thread Jens Wiklander
Hi Michal, On Wed, Aug 24, 2022 at 11:28 AM Michal Orzel wrote: > > Hi Jens, > > On 18/08/2022 12:55, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > This commit brings in o

Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator

2022-09-06 Thread Jens Wiklander
Hi Julien, On Tue, Sep 6, 2022 at 12:25 AM Julien Grall wrote: > > Hi Jens, > > More remarks. > > On 18/08/2022 11:55, Jens Wiklander wrote: > > +/* Negotiated FF-A version to use with the SPMC */ > > +static uint32_t ffa_version __read_mostly; > > NIT: if th

Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator

2022-09-06 Thread Jens Wiklander
Hi Julien, On Tue, Sep 6, 2022 at 12:17 AM Julien Grall wrote: > > Hi Jens, > > On 18/08/2022 11:55, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > This commit brings in o

Re: [PATCH v5 1/9] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-08-24 Thread Jens Wiklander
On Thu, Aug 18, 2022 at 3:45 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 18 Aug 2022, at 11:55, Jens Wiklander wrote: > > > > SMCCC v1.2 [1] AArch64 allows x0-x17 to be used as both parameter > > registers and result registers for the SMC and HVC instruction

Re: [PATCH v5 1/9] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-08-24 Thread Jens Wiklander
Hi, On Thu, Aug 18, 2022 at 7:31 PM Julien Grall wrote: > > Hi Bertrand, > > On 18/08/2022 16:55, Bertrand Marquis wrote: > >> On 18 Aug 2022, at 15:31, Julien Grall wrote: > +/* > + * void arm_smccc_1_2_smc(const struct arm_smccc_1_2_regs *args, > + *

[PATCH v6 2/9] xen/arm: add a primitive FF-A mediator

2022-09-19 Thread Jens Wiklander
to use FF-A. This is loosely based on the TEE mediator framework and the OP-TEE mediator. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- SUPPORT.md | 7 + docs/man/xl.cfg.5.pod.in | 15 ++ tools/golang/xenlight/help

[PATCH v6 0/9] Xen FF-A mediator

2022-09-19 Thread Jens Wiklander
for per guest locking * Addressing style issues and suggestions * Uses FFA_FEATURES to check that all the needed features are available before initializing the mediator * Rebased on staging as of 2022-06-20 v1->v2: * Rebased on staging to resolve some merge conflicts as requested Jens Wiklander

[PATCH v6 4/9] xen/arm: ffa: map SPMC rx/tx buffers

2022-09-19 Thread Jens Wiklander
When initializing the FF-A mediator map the RX and TX buffers shared with the SPMC. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 57 +- 1 file changed

[PATCH v6 3/9] xen/arm: ffa: add direct request support

2022-09-19 Thread Jens Wiklander
Adds support for sending a FF-A direct request. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 125 - 1 file changed, 124 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/ffa.c

[PATCH v6 5/9] xen/arm: ffa: send guest events to Secure Partitions

2022-09-19 Thread Jens Wiklander
can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 192 - 1 file changed, 191 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c index 8cb5c829a394..1e94113b20bd 100644 --- a/xen/arch/arm/ffa.c +++ b/xen

[PATCH v6 7/9] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2022-09-19 Thread Jens Wiklander
in this case), so once it is done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c | 126 - 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/xen

[PATCH v6 6/9] xen/arm: ffa: support mapping guest RX/TX buffers

2022-09-19 Thread Jens Wiklander
Adds support in the mediator to map and unmap the RX and TX buffers provided by the guest using the two FF-A functions FFA_RXTX_MAP and FFA_RXTX_UNMAP. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c

[PATCH v6 8/9] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h

2022-09-19 Thread Jens Wiklander
Moves the two helper functions regpair_to_uint64() and uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm specific regs.h. This enables reuse of these functions in the FF-A mediator in a subsequent patch. Reviewed-by: Michal Orzel Signed-off-by: Jens Wiklander --- xen/arch/arm

[PATCH v6 1/9] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2022-09-19 Thread Jens Wiklander
er.arm.com/documentation/den0028/c/?lang=en Reviewed-by: Luca Fancellu Signed-off-by: Jens Wiklander --- xen/arch/arm/arm64/asm-offsets.c | 9 +++ xen/arch/arm/arm64/smc.S | 42 xen/arch/arm/include/asm/smccc.h | 40 ++ xen/arch/

[PATCH v6 9/9] xen/arm: ffa: support sharing memory

2022-09-19 Thread Jens Wiklander
FF-A version 1.1, but the guest is free to use version 1.0 or version 1.1. The implementation is the bare minimum to be able to communicate with OP-TEE running as an SPMC at S-EL1. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/ffa.c

Re: [PATCH v6 0/9] Xen FF-A mediator

2022-10-14 Thread Jens Wiklander
Hi, I understand that you're busy with the Xen release. When you have time to resume reviewing this patch set please let me know if I should rebase it first. Thanks, Jens On Mon, Sep 19, 2022 at 11:12 AM Jens Wiklander wrote: > > Hi, > > This patch sets add a FF-A [1] mediator m

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-08-11 Thread Jens Wiklander
Hi, On Thu, Jul 28, 2022 at 9:41 PM Julien Grall wrote: > > Hi, > > On 27/07/2022 07:33, Jens Wiklander wrote: > > On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote: > >>> +unsigned int n; > >>> +unsigned int m; > &g

Re: [XEN PATCH v7 20/20] xen/arm: ffa: support sharing large memory ranges

2023-03-15 Thread Jens Wiklander
Hi Bertrand, On Wed, Mar 15, 2023 at 2:35 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 15 Mar 2023, at 12:47, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Wed, Mar 15, 2023 at 11:13 AM Bertrand Marquis > > wrote: > >> &

Re: [XEN PATCH v7 18/20] xen/arm: ffa: support sharing memory

2023-03-15 Thread Jens Wiklander
Hi Bertrand, On Wed, Mar 15, 2023 at 2:24 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 14 Mar 2023, at 18:56, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Mon, Mar 13, 2023 at 9:49 AM Bertrand Marquis > > wrote: > >> &

Re: [XEN PATCH v7 18/20] xen/arm: ffa: support sharing memory

2023-03-14 Thread Jens Wiklander
Hi Bertrand, On Mon, Mar 13, 2023 at 9:49 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds support for a guest to share memory with an SP using FFA_MEM_SHARE > > and FFA_MEM_RECLAIM. Only small m

Re: [XEN PATCH v7 20/20] xen/arm: ffa: support sharing large memory ranges

2023-03-15 Thread Jens Wiklander
Hi Bertrand, On Wed, Mar 15, 2023 at 11:13 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds support for sharing large memory ranges transmitted in fragments > > using FFA_MEM_FRAG_TX. > > >

[XEN PATCH v7 18/20] xen/arm: ffa: support sharing memory

2023-02-22 Thread Jens Wiklander
version 1.0 or version 1.1. Adds a check that the SP supports the needed FF-A features FFA_MEM_SHARE_64 or FFA_MEM_SHARE_32. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 491 + 1 file

[XEN PATCH v7 16/20] xen/arm: ffa: add defines for sharing memory

2023-02-22 Thread Jens Wiklander
Adds defines needed for sharing using the function FFA_MEM_SHARE and friends. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 57 ++ 1 file changed, 57 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index

[XEN PATCH v7 17/20] xen/arm: ffa: add ABI structs for sharing memory

2023-02-22 Thread Jens Wiklander
Adds the ABI structs used by function FFA_MEM_SHARE and friends for sharing memory. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index

[XEN PATCH v7 12/20] xen/arm: ffa: send guest events to Secure Partitions

2023-02-22 Thread Jens Wiklander
(us), so once we're done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 191 - 1 file changed, 190 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm

[XEN PATCH v7 10/20] xen/arm: ffa: add direct request support

2023-02-22 Thread Jens Wiklander
Adds support for sending a FF-A direct request. Checks that the SP also supports handling a 32-bit direct request. 64-bit direct requests are not used by the mediator itself so there is not need to check for that. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 119

[XEN PATCH v7 13/20] xen/arm: ffa: support mapping guest RX/TX buffers

2023-02-22 Thread Jens Wiklander
Adds support in the mediator to map and unmap the RX and TX buffers provided by the guest using the two FF-A functions FFA_RXTX_MAP and FFA_RXTX_UNMAP. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee

[XEN PATCH v7 09/20] xen/arm: ffa: add support for FFA_ID_GET

2023-02-22 Thread Jens Wiklander
Adds support for the FF-A function FFA_ID_GET to return the ID of the calling client. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index

[XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2023-02-22 Thread Jens Wiklander
in this case), so once it is done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 126 - 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/xen

[XEN PATCH v7 15/20] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h

2023-02-22 Thread Jens Wiklander
Moves the two helper functions regpair_to_uint64() and uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm specific regs.h. This enables reuse of these functions in the FF-A mediator in a subsequent patch. Reviewed-by: Michal Orzel Signed-off-by: Jens Wiklander --- xen/arch/arm

[XEN PATCH v7 02/20] xen/arm: tee: add a primitive FF-A mediator

2023-02-22 Thread Jens Wiklander
Adds a FF-A version 1.1 [1] mediator to communicate with a Secure Partition in secure world. This commit brings in only the parts needed to negotiate FF-A version number with guest and SPMC. [1] https://developer.arm.com/documentation/den0077/e Signed-off-by: Jens Wiklander --- xen/arch/arm

[XEN PATCH v7 06/20] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET

2023-02-22 Thread Jens Wiklander
Defines flags used for the function FFA_PARTITION_INFO_GET. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index aa6cdbe0a4f9..f4562ed2defc 100644 --- a/xen

[XEN PATCH v7 04/20] docs: add Arm FF-A mediator

2023-02-22 Thread Jens Wiklander
Describes a FF-A version 1.1 [1] mediator to communicate with a Secure Partition in secure world. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- SUPPORT.md | 7 +++ docs/man/xl.cfg.5.pod.in | 15 +++ 2 files changed

[XEN PATCH v7 08/20] xen/arm: ffa: note dependency on 4k pages

2023-02-22 Thread Jens Wiklander
Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A mediator. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 21 + 1 file changed, 21 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index d04bac9cc47f..8b0b80ce1ff5

[XEN PATCH v7 01/20] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2023-02-22 Thread Jens Wiklander
er.arm.com/documentation/den0028/c/?lang=en Reviewed-by: Luca Fancellu Signed-off-by: Jens Wiklander --- xen/arch/arm/arm64/asm-offsets.c | 9 +++ xen/arch/arm/arm64/smc.S | 42 xen/arch/arm/include/asm/smccc.h | 40 ++ xen/arch/

[XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages

2023-02-22 Thread Jens Wiklander
Adds defines for framework direct request/response messages. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 9 + 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index f4562ed2defc..d04bac9cc47f 100644 --- a/xen/arch/arm/tee/ffa.c

[XEN PATCH v7 11/20] xen/arm: ffa: map SPMC rx/tx buffers

2023-02-22 Thread Jens Wiklander
mode we must use FFA_RXTX_MAP_64 since registers are used to transmit the physical addresses of the RX/TX buffers. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 57 +- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm

[XEN PATCH v7 00/20] Xen FF-A mediator

2023-02-22 Thread Jens Wiklander
ented memory share requests into struct ffa_ctx instead to keep it per guest in order to avoid mixups and simplify locking * Adds a spinlock to struct ffa_ctx for per guest locking * Addressing style issues and suggestions * Uses FFA_FEATURES to check that all the needed features are available befo

[XEN PATCH v7 05/20] xen/arm: ffa: add remaining SMC function IDs

2023-02-22 Thread Jens Wiklander
Adds the remaining SMC function IDs from FF-A 1.1 specification. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 824153c9303a..aa6cdbe0a4f9

[XEN PATCH v7 03/20] tools: add Arm FF-A mediator

2023-02-22 Thread Jens Wiklander
Adds a new "ffa" value to the Enumeration "tee_type" to indicate if a guest is trusted to use FF-A. Signed-off-by: Jens Wiklander --- tools/libs/light/libxl_arm.c | 3 +++ tools/libs/light/libxl_types.idl | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) dif

[XEN PATCH v7 20/20] xen/arm: ffa: support sharing large memory ranges

2023-02-22 Thread Jens Wiklander
Adds support for sharing large memory ranges transmitted in fragments using FFA_MEM_FRAG_TX. The implementation is the bare minimum to be able to communicate with OP-TEE running as an SPMC at S-EL1. Adds a check that the SP supports the needed FF-A feature FFA_MEM_FRAG_TX. Signed-off-by: Jens

[XEN PATCH v7 19/20] xen/arm: ffa: add support to reclaim shared memory

2023-02-22 Thread Jens Wiklander
Adds support to reclaim memory previously shared with FFA_MEM_SHARE. Adds a check that the SP supports the needed FF-A feature FFA_MEM_RECLAIM. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 53 ++ 1 file changed, 53 insertions(+) diff --git

Re: [XEN PATCH v7 13/20] xen/arm: ffa: support mapping guest RX/TX buffers

2023-03-02 Thread Jens Wiklander
Hi Bertrand, On Thu, Mar 2, 2023 at 4:05 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds support in the mediator to map and unmap the RX and TX buffers > > provided by the guest using th

Re: [XEN PATCH v7 13/20] xen/arm: ffa: support mapping guest RX/TX buffers

2023-03-03 Thread Jens Wiklander
Hi, On Fri, Mar 3, 2023 at 9:16 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 3 Mar 2023, at 08:41, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Thu, Mar 2, 2023 at 4:05 PM Bertrand Marquis > > wrote: > >> > >&g

Re: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages

2023-03-02 Thread Jens Wiklander
Hi Bertrand, On Fri, Feb 24, 2023 at 10:39 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds defines for framework direct request/response messages. > > > > Signed-off-by: Jens Wiklander

Re: [XEN PATCH v7 15/20] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h

2023-03-03 Thread Jens Wiklander
On Fri, Mar 3, 2023 at 11:51 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Moves the two helper functions regpair_to_uint64() and > > uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm

Re: [XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2023-03-03 Thread Jens Wiklander
Hi Bertrand, On Fri, Mar 3, 2023 at 10:51 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests > > from a guest. The requests are forwa

Re: [XEN PATCH v7 17/20] xen/arm: ffa: add ABI structs for sharing memory

2023-03-03 Thread Jens Wiklander
Hi Bertrand, On Fri, Mar 3, 2023 at 3:20 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds the ABI structs used by function FFA_MEM_SHARE and friends for > > sharing memory. > > > > Signed-o

Re: [XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2023-03-03 Thread Jens Wiklander
Hi, On Fri, Mar 3, 2023 at 2:50 PM Bertrand Marquis wrote: > > > > > On 3 Mar 2023, at 14:17, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Fri, Mar 3, 2023 at 10:51 AM Bertrand Marquis > > wrote: > >> > >> Hi Jens, &g

Re: [XEN PATCH v7 16/20] xen/arm: ffa: add defines for sharing memory

2023-03-03 Thread Jens Wiklander
Hi Bertrand, On Fri, Mar 3, 2023 at 2:38 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds defines needed for sharing using the function FFA_MEM_SHARE and > > friends. > > > > Signed-off-by:

Re: [XEN PATCH v7 05/20] xen/arm: ffa: add remaining SMC function IDs

2023-02-24 Thread Jens Wiklander
Hi Bertrand, On Thu, Feb 23, 2023 at 4:28 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds the remaining SMC function IDs from FF-A 1.1 specification. > > > > Signed-off-by: Jens Wiklander &g

Re: [XEN PATCH v7 02/20] xen/arm: tee: add a primitive FF-A mediator

2023-02-24 Thread Jens Wiklander
Hi, On Thu, Feb 23, 2023 at 3:43 PM Julien Grall wrote: > > Hi, > > I have only skimmed through the patch so far and I have one question below. > > On 22/02/2023 15:32, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure >

Re: [XEN PATCH v7 03/20] tools: add Arm FF-A mediator

2023-02-24 Thread Jens Wiklander
On Thu, Feb 23, 2023 at 5:50 PM Anthony PERARD wrote: > > On Wed, Feb 22, 2023 at 04:33:00PM +0100, Jens Wiklander wrote: > > diff --git a/tools/libs/light/libxl_types.idl > > b/tools/libs/light/libxl_types.idl > > index 0cfad8508dbd..64fb570bc19a 100644 &g

Re: [XEN PATCH v7 02/20] xen/arm: tee: add a primitive FF-A mediator

2023-02-24 Thread Jens Wiklander
Hi, On Thu, Feb 23, 2023 at 3:47 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:32, Jens Wiklander wrote: > > > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > >

Re: [XEN PATCH v7 01/20] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers

2023-02-24 Thread Jens Wiklander
On Thu, Feb 23, 2023 at 3:35 PM Julien Grall wrote: > > Hi Jens, > > On 22/02/2023 15:32, Jens Wiklander wrote: > > SMCCC v1.2 [1] AArch64 allows x0-x17 to be used as both parameter > > registers and result registers for the SMC and HVC instructions. > > > &

Re: [XEN PATCH v7 04/20] docs: add Arm FF-A mediator

2023-02-24 Thread Jens Wiklander
Hi Bertrand, On Thu, Feb 23, 2023 at 4:10 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Describes a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. >

Re: [XEN PATCH v7 06/20] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET

2023-02-24 Thread Jens Wiklander
Hi Bertrand, On Fri, Feb 24, 2023 at 10:30 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Defines flags used for the function FFA_PARTITION_INFO_GET. > > > > Signed-off-by: Jens Wiklander

Re: [XEN PATCH v7 11/20] xen/arm: ffa: map SPMC rx/tx buffers

2023-03-01 Thread Jens Wiklander
Hi, On Wed, Mar 1, 2023 at 10:56 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 1 Mar 2023, at 10:30, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Tue, Feb 28, 2023 at 1:57 PM Bertrand Marquis > > wrote: > >> > >&g

Re: [XEN PATCH v7 12/20] xen/arm: ffa: send guest events to Secure Partitions

2023-03-01 Thread Jens Wiklander
Hi Bertrand, On Tue, Feb 28, 2023 at 5:49 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > The FF-A specification defines framework messages sent as direct > > requests when certain events occurs. For instance

Re: [XEN PATCH v7 10/20] xen/arm: ffa: add direct request support

2023-03-01 Thread Jens Wiklander
Hi Bertrand, On Mon, Feb 27, 2023 at 4:28 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds support for sending a FF-A direct request. Checks that the SP also > > supports handling a 32-bit direc

Re: [XEN PATCH v7 09/20] xen/arm: ffa: add support for FFA_ID_GET

2023-02-28 Thread Jens Wiklander
Hi, On Mon, Feb 27, 2023 at 4:00 PM Julien Grall wrote: > > Hi, > > On 27/02/2023 14:48, Bertrand Marquis wrote: > >> On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > >> > >> Adds support for the FF-A function FFA_ID_GET to return the ID of the &g

Re: [XEN PATCH v7 08/20] xen/arm: ffa: note dependency on 4k pages

2023-02-28 Thread Jens Wiklander
Hi Bertrand, On Fri, Feb 24, 2023 at 4:27 PM Bertrand Marquis wrote: > > HI Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A > > mediator. > > > > Signed-of

Re: [XEN PATCH v7 10/20] xen/arm: ffa: add direct request support

2023-03-01 Thread Jens Wiklander
On Wed, Mar 1, 2023 at 4:50 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 1 Mar 2023, at 11:55, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Mon, Feb 27, 2023 at 4:28 PM Bertrand Marquis > > wrote: > >> > >> Hi Jens, &g

  1   2   3   4   >