Re: [PATCH v3] Input: xen-kbdfront - drop keys to shrink modalias

Hi Jason, On Sun, Apr 21, 2024 at 07:57:24PM -0400, Jason Andryuk wrote: > Hi Dmitry, > > On Thu, Mar 28, 2024 at 2:05 PM Dmitry Torokhov > wrote: > > > > Hi Jason, > > > > On Wed, Mar 20, 2024 at 01:42:27PM -0400, Jason Andryuk wrote: > > > Hi

Re: [PATCH v3] Input: xen-kbdfront - drop keys to shrink modalias

Hi Jason, On Wed, Mar 20, 2024 at 01:42:27PM -0400, Jason Andryuk wrote: > Hi Dmitry, > > Do you have any feedback, or can you pick up this patch? It solves a > real issue affecting udev, which crashes the Debian installer and > breaks the mouse for Gnome. > > Or would you be okay if this

Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it

Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see

Re: [PATCH] Xen Keyboard: don't advertise every key known to man

On Thu, May 06, 2021 at 02:36:54PM +, Phillip Susi wrote: > For reasons I still don't understand, the input subsystem allows > input devices to advertise what keys they have, and adds this > information to the modalias for the device. The Xen Virtual > Keyboard was advertising every known

Re: Xen Virtual Keyboard modalias breaking uevents

On Thu, Apr 29, 2021 at 08:11:03PM -0400, Phillip Susi wrote: > > Dmitry Torokhov writes: > > > Not every keyboard, but all keycodes above KEY_MIN_INTERESTING which is > > KEY_MUTE, so that interested handlers could match on devices they are > > interested in without f

Re: Xen Virtual Keyboard modalias breaking uevents

On Thu, Apr 29, 2021 at 04:10:09PM -0400, Phillip Susi wrote: > > It appears that input/input.c is responsible for the insane modalias > length. If I am reading input_print_modalias() correctly, it appends a > "k" plus every key code that the keyboard supports, Not every keyboard, but all

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

On June 12, 2018 11:13:40 PM PDT, Oleksandr Andrushchenko wrote: >On 06/13/2018 09:11 AM, Dmitry Torokhov wrote: >> On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko > wrote: >>> On 06/13/2018 02:40 AM, Dmitry Torokhov wrote: >>>> On Tue, Jun 12, 2018 a

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko wrote: >On 06/13/2018 02:40 AM, Dmitry Torokhov wrote: >> On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote: >>> On 12/06/18 09:48, Oleksandr Andrushchenko wrote: >>>> From: Oleksandr Andrushchen

Re: [Xen-devel] [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen

On Tue, Jun 12, 2018 at 03:46:10PM +0200, Juergen Gross wrote: > On 12/06/18 09:48, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > > > This is the sync up with the canonical definitions of the input, > > sound and display protocols in Xen. > > > > Changes to kbdif: > > 1.

Re: [Xen-devel] [PATCH v5 3/3] Input: xen-kbdfront - allow better run-time configuration

On Tue, Jun 12, 2018 at 10:48:56AM +0300, Oleksandr Andrushchenko wrote: > > + if (!(with_kbd | with_ptr | with_mtouch)) { I changed this to logical "OR" and applied, thank you. > + ret = -ENXIO; > + goto error; > + } > + > ret =

Re: [Xen-devel] [PATCH v3 2/2] Input: xen-kbdfront - allow better run-time configuration

On Wed, May 16, 2018 at 08:47:30PM +0300, Oleksandr Andrushchenko wrote: > On 05/16/2018 08:15 PM, Dmitry Torokhov wrote: > > Hi Oleksandr, > > > > On Mon, May 14, 2018 at 05:40:29PM +0300, Oleksandr Andrushchenko wrote: > > > @@ -211,93 +220,114 @@ static int xen

Re: [Xen-devel] [PATCH v3 2/2] Input: xen-kbdfront - allow better run-time configuration

Hi Oleksandr, On Mon, May 14, 2018 at 05:40:29PM +0300, Oleksandr Andrushchenko wrote: > @@ -211,93 +220,114 @@ static int xenkbd_probe(struct xenbus_device *dev, > if (!info->page) > goto error_nomem; > > - /* Set input abs params to match backend screen res */ > -

Re: [Xen-devel] [PATCH] xen/kbdif: Add frontend's virtual device options

Hi Oleksandr, On Tue, Apr 24, 2018 at 10:31:38AM +0300, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > It is now not possible to control if and which virtual devices > are created by the frontend, e.g. keyboard and pointer devices > are

Re: [Xen-devel] [PATCH] Input: xen-kbdfront - allow better run-time configuration

On Tue, Apr 24, 2018 at 08:55:19AM +0300, Oleksandr Andrushchenko wrote: > On 04/23/2018 09:53 PM, Dmitry Torokhov wrote: > > On Thu, Apr 19, 2018 at 02:44:19PM +0300, Oleksandr Andrushchenko wrote: > > > On 04/19/2018 02:25 PM, Juergen Gross wrote: > > > >

Re: [Xen-devel] [PATCH v2] Input: xen-kbdfront - allow better run-time configuration

On Mon, Apr 23, 2018 at 11:29:45AM +0300, Oleksandr Andrushchenko wrote: > On 04/23/2018 11:23 AM, Juergen Gross wrote: > > On 23/04/18 10:02, Oleksandr Andrushchenko wrote: > > > Juergen, Jason, Dmitry > > > any comment on this? > > Oleksandr, please give us some time. I can't speak for others,

Re: [Xen-devel] [PATCH] Input: xen-kbdfront - allow better run-time configuration

On Thu, Apr 19, 2018 at 02:44:19PM +0300, Oleksandr Andrushchenko wrote: > On 04/19/2018 02:25 PM, Juergen Gross wrote: > > On 18/04/18 17:04, Oleksandr Andrushchenko wrote: > > > From: Oleksandr Andrushchenko > > > > > > It is now only possible to control if