Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Jan Beulich
On 22.04.2024 13:34, Roger Pau Monné wrote: > On Mon, Apr 22, 2024 at 12:57:55PM +0200, Jan Beulich wrote: >> On 22.04.2024 12:49, Roger Pau Monné wrote: >>> On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: On 22.04.2024 09:54, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Roger Pau Monné
On Mon, Apr 22, 2024 at 12:57:55PM +0200, Jan Beulich wrote: > On 22.04.2024 12:49, Roger Pau Monné wrote: > > On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: > >> On 22.04.2024 09:54, Roger Pau Monné wrote: > >>> On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: > On

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Jan Beulich
On 22.04.2024 12:49, Roger Pau Monné wrote: > On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: >> On 22.04.2024 09:54, Roger Pau Monné wrote: >>> On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: On 19.04.2024 12:50, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Roger Pau Monné
On Mon, Apr 22, 2024 at 10:25:40AM +0200, Jan Beulich wrote: > On 22.04.2024 09:54, Roger Pau Monné wrote: > > On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: > >> On 19.04.2024 12:50, Roger Pau Monné wrote: > >>> On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: > On

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Jan Beulich
On 22.04.2024 09:54, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: >> On 19.04.2024 12:50, Roger Pau Monné wrote: >>> On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: On 19.04.2024 12:02, Roger Pau Monne wrote: > Livepatch payloads

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-22 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 04:34:41PM +0200, Jan Beulich wrote: > On 19.04.2024 12:50, Roger Pau Monné wrote: > > On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: > >> On 19.04.2024 12:02, Roger Pau Monne wrote: > >>> Livepatch payloads containing symbols that belong to init sections can

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Jan Beulich
On 19.04.2024 12:50, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: >> On 19.04.2024 12:02, Roger Pau Monne wrote: >>> Livepatch payloads containing symbols that belong to init sections can only >>> lead to page faults later on, as by the time the livepatch

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: > On 19.04.2024 12:02, Roger Pau Monne wrote: > > Livepatch payloads containing symbols that belong to init sections can only > > lead to page faults later on, as by the time the livepatch is loaded init > > sections have already been

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 11:10:33AM +0100, Andrew Cooper wrote: > On 19/04/2024 11:02 am, Roger Pau Monne wrote: > > Livepatch payloads containing symbols that belong to init sections can only > > lead to page faults later on, as by the time the livepatch is loaded init > > sections have already

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Jan Beulich
On 19.04.2024 12:02, Roger Pau Monne wrote: > Livepatch payloads containing symbols that belong to init sections can only > lead to page faults later on, as by the time the livepatch is loaded init > sections have already been freed. > > Refuse to resolve such symbols and return an error instead.

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Andrew Cooper
On 19/04/2024 11:02 am, Roger Pau Monne wrote: > Livepatch payloads containing symbols that belong to init sections can only > lead to page faults later on, as by the time the livepatch is loaded init > sections have already been freed. > > Refuse to resolve such symbols and return an error

[PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Roger Pau Monne
Livepatch payloads containing symbols that belong to init sections can only lead to page faults later on, as by the time the livepatch is loaded init sections have already been freed. Refuse to resolve such symbols and return an error instead. Note such resolutions are only relevant for symbols