Re: [XEN PATCH v1 1/7] x86/vpmu: separate amd/intel vPMU code

2024-04-30 Thread Sergiy Kibrik
29.04.24 18:28, Jan Beulich: Any reason you don't follow the approach used in patch 7, putting simple #ifdef in the switch() in vpmu_init()? That would avoid the need for the three almost identical stubs. I didn't want to put that many preprocessor statements into this small switch() block (4

Re: [XEN PATCH v1 1/7] x86/vpmu: separate amd/intel vPMU code

2024-04-29 Thread Jan Beulich
On 23.04.2024 10:48, Sergiy Kibrik wrote: > --- a/xen/arch/x86/include/asm/vpmu.h > +++ b/xen/arch/x86/include/asm/vpmu.h > @@ -11,6 +11,7 @@ > #define __ASM_X86_HVM_VPMU_H_ > > #include > +#include > > #define vcpu_vpmu(vcpu) (&(vcpu)->arch.vpmu) > #define vpmu_vcpu(vpmu)

Re: [XEN PATCH v1 1/7] x86/vpmu: separate amd/intel vPMU code

2024-04-26 Thread Stefano Stabellini
On Tue, 23 Apr 2024, Sergiy Kibrik wrote: > Build AMD vPMU when CONFIG_AMD is on, and Intel vPMU when CONFIG_INTEL > is on respectively, allowing for a plaftorm-specific build. Also separate > arch_vpmu_ops initializers using these options and static inline stubs. > > No functional change

[XEN PATCH v1 1/7] x86/vpmu: separate amd/intel vPMU code

2024-04-23 Thread Sergiy Kibrik
Build AMD vPMU when CONFIG_AMD is on, and Intel vPMU when CONFIG_INTEL is on respectively, allowing for a plaftorm-specific build. Also separate arch_vpmu_ops initializers using these options and static inline stubs. No functional change intended. Signed-off-by: Sergiy Kibrik CC: Andrew Cooper