Re: [PATCH] xen/efi: Rewrite DOS/PE magic checking without memcmp()

On Tue, Apr 16, 2024 at 04:52:51PM +0100, Andrew Cooper wrote: > Misra Rule 21.16 doesn't like the use of memcmp() between a string literal and > a UINT8 array. Rewrite using plain compares. The commit message makes it look like it's a type mismatch issue between the two elements being compared,

Re: docs/misra: add R21.6 R21.14 R21.15 R21.16

Hi Stefano, > Other deviations: > - > > diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst > index b7b447e152..00db02ad34 100644 > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst > @@ -652,12 +652,38 @@ maintainers if you want to suggest a change. >declared

Re: [PATCH] docs: arm: Update where Xen should be loaded in memory

Hi, On 12/04/2024 07:41, Luca Fancellu wrote: On 12 Apr 2024, at 07:16, Michal Orzel wrote: Since commit 6cd046c501bc ("xen/arm: Enlarge identity map space to 10TB") Xen can be loaded below 10 TiB. Update docs accordingly. Take the opportunity to update stale links to Linux docs.

Re: [ImageBuilder 3/5] uboot-script-gen: Add ability to specify grant table params

On 17/04/2024 14:07, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > Use DOMU_GRANT_VER to set "max_grant_version" dt property. > Use DOMU_GRANT_FRAMES to set "max_grant_frames" dt property. > Use DOMU_MAPTRACK_FRAMES to set "max_maptrack_frames" dt property. > >

Re: [PATCH] public: xen: Define missing guest handle for int32_t

Hi Michal, > On 17 Apr 2024, at 13:14, Michal Orzel wrote: > > Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t > in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined > for it. This results in a build failure. Example on Arm: > >

[PATCH v8 13/17] xen/riscv: add minimal stuff to mm.h to build full Xen

Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V8: - Nothing changed only rebase. --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- Changes in V6:

[PATCH v8 15/17] xen/riscv: add minimal amount of stubs to build full Xen

Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplmented...")

[PATCH v8 10/17] xen/riscv: add definition of __read_mostly

The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v8 00/17] Enable build of full Xen for RISC-V

This patch series performs all of the additions necessary to drop the build overrides for RISCV and enable the full Xen build. Except in cases where compatibile implementations already exist (e.g. atomic.h and bitops.h), the newly added definitions are simple. The patch series is based on the

[PATCH v8 09/17] xen/riscv: introduce monitor.h

Signed-off-by: Oleksii Kurochko --- Changes in V4-V8: - Nothing changed. Only rebase. --- Changes in V3: - new patch. --- xen/arch/riscv/include/asm/monitor.h | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 xen/arch/riscv/include/asm/monitor.h diff --git

[PATCH v8 07/17] xen/riscv: introduce io.h

The header taken form Linux 6.4.0-rc1 and is based on arch/riscv/include/asm/mmio.h with the following changes: - drop forcing of endianess for read*(), write*() functions as no matter what CPU endianness, what endianness a particular device (and hence its MMIO region(s)) is using is entirely

[PATCH v8 11/17] xen/riscv: add required things to current.h

Add minimal requied things to be able to build full Xen. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V5-V8: - Nothing changed. Only rebase. --- Changes in V4: - BUG() was changed to BUG_ON("unimplemented"); - Change "xen/bug.h" to "xen/lib.h" as BUG_ON is defined in

[PATCH v8 04/17] xen/bitops: put __ffs() into linux compatible header

The mentioned macros exist only because of Linux compatible purpose. The patch defines __ffs() in terms of Xen bitops and it is safe to define in this way ( as __ffs() - 1 ) as considering that __ffs() was defined as __builtin_ctzl(x), which has undefined behavior when x=0, so it is assumed that

[PATCH v8 16/17] xen/riscv: enable full Xen build

Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- Changes in V5-V8: - Nothing changed. Only rebase. --- Changes in V4: - drop stubs for irq_actor_none() and irq_actor_none() as common/irq.c is compiled now. - drop defintion of max_page in stubs.c as common/page_alloc.c is compiled

[PATCH v8 05/17] xen/riscv: introduce bitops.h

Taken from Linux-6.4.0-rc1 Xen's bitops.h consists of several Linux's headers: * linux/arch/include/asm/bitops.h: * The following function were removed as they aren't used in Xen: * test_and_set_bit_lock * clear_bit_unlock * __clear_bit_unlock * The following functions

[PATCH v8 08/17] xen/riscv: introduce atomic.h

Initially the patch was introduced by Bobby, who takes the header from Linux kernel. The following changes were done on top of Bobby's changes: - atomic##prefix##_*xchg_*(atomic##prefix##_t *v, c_t n) were updated to use__*xchg_generic() - drop casts in write_atomic() as they are unnecessary

[PATCH v8 01/17] xen/riscv: disable unnecessary configs

Disables unnecessary configs for two cases: 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds (GitLab CI jobs). 2. By using tiny64_defconfig for non-randconfig builds. Only configs which lead to compilation issues were disabled. Remove lines related to disablement of configs which

[PATCH v8 02/17] xen: introduce generic non-atomic test_*bit()

The following generic functions were introduced: * test_bit * generic__test_and_set_bit * generic__test_and_clear_bit * generic__test_and_change_bit Also, the patch introduces the following generics which are used by the functions mentioned above: * BITOP_BITS_PER_WORD * BITOP_MASK * BITOP_WORD *

[PATCH v8 14/17] xen/riscv: introduce vm_event_*() functions

Signed-off-by: Oleksii Kurochko --- Changes in V5-V8: - Only rebase was done. --- Changes in V4: - New patch. --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/vm_event.c | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 xen/arch/riscv/vm_event.c diff --git

[PATCH v8 06/17] xen/riscv: introduce cmpxchg.h

The header was taken from Linux kernl 6.4.0-rc1. Addionally, were updated: * add emulation of {cmp}xchg for 1/2 byte types using 32-bit atomic access. * replace tabs with spaces * replace __* variale with *__ * introduce generic version of xchg_* and cmpxchg_*. * drop

[PATCH v8 12/17] xen/riscv: add minimal stuff to page.h to build full Xen

Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V5-V8: - Nothing changed. Only rebase. --- Changes in V4: --- - Change message -> subject in "Changes in V3" - s/BUG/BUG_ON("...") - Do proper rebase ( pfn_to_paddr() and paddr_to_pfn() aren't removed ). --- Changes in V3:

Re: [PATCH] xen/arm: imx8qm: Re-license file to GPL-2.0-only

Hi John, Thanks for the patch! On 17/04/2024 01:47, Stefano Stabellini wrote: On Tue, 16 Apr 2024, Peng Fan wrote: Subject: [PATCH] xen/arm: imx8qm: Re-license file to GPL-2.0-only New contributions are recommended to be under GPL-2.0-only [1], since this code piece originally came from the

[PATCH] public: xen: Define missing guest handle for int32_t

Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined for it. This results in a build failure. Example on Arm: ./include/public/arch-arm.h:205:41: error: unknown type name ‘__guest_handle_64_int32_t’ 205 |

Re: [ImageBuilder 4/5] uboot-script-gen: Add ability to unselect "vpl011"

On 17/04/2024 14:07, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > Introduce new option DOMU_VPL011[nr] that can be set to 0 > or 1 (default). > > Also align "console=ttyAMA0" Linux cmd arg setting with "vpl011" presense. > > Suggested-by: Michal Orzel > Signed-off-by:

Re: Serious AMD-Vi(?) issue

On 11.04.2024 04:41, Elliott Mitchell wrote: > On Thu, Mar 28, 2024 at 07:25:02AM +0100, Jan Beulich wrote: >> On 27.03.2024 18:27, Elliott Mitchell wrote: >>> On Mon, Mar 25, 2024 at 02:43:44PM -0700, Elliott Mitchell wrote: On Mon, Mar 25, 2024 at 08:55:56AM +0100, Jan Beulich wrote: >

[PATCH v8 03/17] xen/bitops: implement fls{l}() in common logic

Return type was left 'int' because of the following compilation error: ./include/xen/kernel.h:18:21: error: comparison of distinct pointer types lacks a cast [-Werror] 18 | (void) (&_x == &_y);\ | ^~ common/page_alloc.c:1843:34: note:

[xen-unstable-smoke test] 185715: regressions - trouble: blocked/fail

flight 185715 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185715/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 185684 build-amd64

[ImageBuilder 3/5] uboot-script-gen: Add ability to specify grant table params

From: Oleksandr Tyshchenko Use DOMU_GRANT_VER to set "max_grant_version" dt property. Use DOMU_GRANT_FRAMES to set "max_grant_frames" dt property. Use DOMU_MAPTRACK_FRAMES to set "max_maptrack_frames" dt property. Signed-off-by: Oleksandr Tyshchenko --- README.md| 10

[ImageBuilder 1/5] uboot-script-gen: Update to deal with uImage which is not executable

From: Oleksandr Tyshchenko uImage is the Image that has a U-Boot wrapper, it doesn't contain "executable" string which subsequent "file" command is looking for when inspecting it. Below the proof: otyshchenko@EPUAKYIW03DD:~/work/xen_tests/input$ file -L binaries/uImage.gz binaries/uImage.gz:

[ImageBuilder 5/5] uboot-script-gen: Add ability to specify "nr_spis"

From: Oleksandr Tyshchenko This is needed to have a possibility of assigning a specified number of shared peripheral interrupts (SPIs) to domain. Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stefano Stabellini --- README.md| 5 + scripts/uboot-script-gen | 4 2

[ImageBuilder 0/5] Misc updates for the dom0less support

From: Oleksandr Tyshchenko Hello all, this is a collection of patches (#2-5) for improving the dom0less support and a patch (#1) for dealing with uImage. Oleksandr Tyshchenko (5): uboot-script-gen: Update to deal with uImage which is not executable uboot-script-gen: Extend DOMU_ENHANCED

[ImageBuilder 2/5] uboot-script-gen: Extend DOMU_ENHANCED to specify "no-xenstore"

From: Oleksandr Tyshchenko We need some Xen services to be available within single dom0less DomU. Just using "enabled" will lead to Xen panic because of no Dom0. (XEN) (XEN) Panic on CPU 0: (XEN) At the moment, Xenstore support requires dom0 to be

[ImageBuilder 4/5] uboot-script-gen: Add ability to unselect "vpl011"

From: Oleksandr Tyshchenko Introduce new option DOMU_VPL011[nr] that can be set to 0 or 1 (default). Also align "console=ttyAMA0" Linux cmd arg setting with "vpl011" presense. Suggested-by: Michal Orzel Signed-off-by: Oleksandr Tyshchenko --- README.md| 7 ++-

Re: [ImageBuilder 2/5] uboot-script-gen: Extend DOMU_ENHANCED to specify "no-xenstore"

On 17/04/2024 14:07, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > We need some Xen services to be available within single dom0less DomU. > Just using "enabled" will lead to Xen panic because of no Dom0. > > (XEN) > (XEN) Panic on

Re: [ImageBuilder 1/5] uboot-script-gen: Update to deal with uImage which is not executable

On 17/04/2024 14:07, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > uImage is the Image that has a U-Boot wrapper, it doesn't contain > "executable" string which subsequent "file" command is looking for > when inspecting it. > > Below the proof: > >

[PATCH v8 17/17] xen/README: add compiler and binutils versions for RISC-V64

This patch doesn't represent a strict lower bound for GCC and GNU Binutils; rather, these versions are specifically employed by the Xen RISC-V container and are anticipated to undergo continuous testing. Older GCC and GNU Binutils would work, but this is not a guarantee. While it is feasible to

Re: [ImageBuilder 5/5] uboot-script-gen: Add ability to specify "nr_spis"

On 17/04/2024 14:07, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > This is needed to have a possibility of assigning a specified number > of shared peripheral interrupts (SPIs) to domain. > > Signed-off-by: Oleksandr Tyshchenko > Signed-off-by: Stefano Stabellini

[xen-unstable-smoke test] 185718: regressions - trouble: blocked/fail

flight 185718 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185718/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 185684 build-amd64

Re: [PATCH v3 3/9] xen/ppc: Introduce stub asm/static-shmem.h

On 10.04.2024 01:35, Shawn Anastasio wrote: > On 3/25/24 10:24 AM, Jan Beulich wrote: >> On 14.03.2024 23:15, Shawn Anastasio wrote: >>> Required for bootfdt.c to build. >>> >>> Signed-off-by: Shawn Anastasio >> >> As a temporary workaround this may be okay, but was the alternative >> considered

Re: [PATCH v7 2/2] x86/PVH: Support relocatable dom0 kernels

On 08.04.2024 18:56, Jason Andryuk wrote: > On 2024-04-08 03:00, Jan Beulich wrote: >> On 04.04.2024 23:25, Jason Andryuk wrote: >>> --- a/xen/arch/x86/hvm/dom0_build.c >>> +++ b/xen/arch/x86/hvm/dom0_build.c >>> @@ -537,6 +537,111 @@ static paddr_t __init find_memory( >>> return

[PATCH v2 1/6] gzip: drop unused define checks

Dropping the define checks for PKZIP_BUG_WORKAROUND and NOMEMCPY define as they never are set. Signed-off-by: Daniel P. Smith --- xen/common/gzip/inflate.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/xen/common/gzip/inflate.c b/xen/common/gzip/inflate.c index

[PATCH v2 0/6] Clean up of gzip decompressor

An issue ran into by hyperlaunch was the need to use the gzip decompressor multiple times. The current implementation fails when reused due to tainting of decompressor state from a previous usage. This series seeks to colocate the gzip unit files under a single directory similar to the other

Re: [XEN PATCH V1] x86/ucode: optional amd/intel ucode build & load

On 09.04.2024 23:49, Stefano Stabellini wrote: > On Tue, 9 Apr 2024, Sergiy Kibrik wrote: >> 05.04.24 13:57, Andrew Cooper: >>> On 05/04/2024 11:30 am, Sergiy Kibrik wrote: Introduce configuration variables to make it possible to selectively turn on/off CPU microcode management code in

Re: docs/misra: add R21.6 R21.14 R21.15 R21.16

Hi Stefano, On 16/04/2024 20:27, Stefano Stabellini wrote: Also add two specific project-wide deviations for R21.6 and R21.15. In general, I am fine with add the two rules. However... Signed-off-by: Stefano Stabellini diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst

Re: [PATCH v2 1/6] gzip: drop unused define checks

On 17/04/2024 3:37 pm, Daniel P. Smith wrote: > Dropping the define checks for PKZIP_BUG_WORKAROUND and NOMEMCPY define as > they > never are set. > > Signed-off-by: Daniel P. Smith It looks like ARCH_HAS_DECOMP_WDOG is another one that can go. There's only a single instance, in inflate(),

Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation

On 11.04.2024 14:03, Andrew Cooper wrote: > On 09/04/2024 8:45 pm, Nicola Vetrini wrote: >> On 2024-04-08 09:32, Jan Beulich wrote: >>> On 05.04.2024 11:14, Nicola Vetrini wrote: Remove unneded blank lines between switch clauses. >>> >>> "Unneeded" based on what? We're carefully trying to

[xen-4.18-testing test] 185705: regressions - FAIL

flight 185705 xen-4.18-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185705/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail in 185695 REGR. vs. 185285 Tests which

Re: [PATCH v2] libxl: Enable stubdom cdrom changing

On Sun, Apr 07, 2024 at 10:36:33AM -0400, Jason Andryuk wrote: > diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c > index fa7856f28c..819d34933b 100644 > --- a/tools/libs/light/libxl_disk.c > +++ b/tools/libs/light/libxl_disk.c > @@ -829,21 +829,122 @@ int

[PATCH] x86/cpuid-policy: Add AMD SVM CPUID leaf to featureset

Currently, the CPUID leaf for SVM features (extd 0xa.edx) is manually twiddled: - hvm_max_policy takes host_policy and clamps it to supported features (with some features unilaterally enabled because they're always emulated - hvm_default_policy is copied from there - When

Re: [PATCH v2 1/2] x86: Add support for building a multiboot2 PE binary

On Wed, Apr 17, 2024 at 3:15 PM Jan Beulich wrote: > > On 10.04.2024 11:41, Ross Lagerwall wrote: > > On Mon, Apr 8, 2024 at 11:25 AM Jan Beulich wrote: > >> On 28.03.2024 16:11, Ross Lagerwall wrote: > >>> * The image base address is set to 0 since it must necessarily be below > >>> 4 GiB and

Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service

On 2024-04-17 16:57, Julien Grall wrote: Hi Nicola, On 17/04/2024 15:51, Nicola Vetrini wrote: The service STD.emptrecd is in the process of being removed in favour of STD.anonstct. I am guessing this is not a new feature and the current ECLAIR version is supporting it? Cheers, Yes, it

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

On 11.04.2024 16:39, Oleksii wrote: > On Wed, 2024-04-03 at 13:53 +0200, Jan Beulich wrote: >> On 03.04.2024 12:54, Oleksii wrote: >>> On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: On 03.04.2024 12:19, Oleksii Kurochko wrote: > This patch disables unnecessary configs for two

Re: [PATCH v3 2/2] drivers/char: mark extra reserved device memory in memory map

On 14.04.2024 02:32, Marek Marczykowski-Górecki wrote: > On Wed, Apr 03, 2024 at 09:10:40AM +0200, Jan Beulich wrote: >> On 27.03.2024 03:53, Marek Marczykowski-Górecki wrote: >>> The IOMMU driver checks if RMRR/IVMD are marked as reserved in memory >>> map. This should be true for addresses

Re: [PATCH] public: xen: Define missing guest handle for int32_t

Hi Michal, On 17/04/2024 13:14, Michal Orzel wrote: Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined for it. This results in a build failure. Example on Arm: ./include/public/arch-arm.h:205:41: error:

[PATCH v2 2/6] gzip: clean up comments and fix code alignment

This commit cleans up the comments and fixes the code alignment using Xen coding style. This is done to make the code more legible before refactoring. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 10 +- xen/common/gzip/inflate.c | 790 +++--- 2

[PATCH v2 3/6] gzip: remove custom memory allocator

All the other decompression routines use xmalloc_bytes(), thus there is no reason for gzip to be handling its own allocation of memory. In fact, there is a bug somewhere in the allocator as decompression started to break when adding additional allocations. Instead of troubleshooting the allocator,

[PATCH v2 4/6] gzip: refactor state tracking

Move the core state into struct gzip_data to allow a per decompression instance. Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 55 +++- xen/common/gzip/inflate.c | 174 +++--- 2 files changed, 120 insertions(+), 109 deletions(-) diff

[PATCH v2 6/6] gzip: drop huffman code table tracking

The "tracking" bits does not appear to be used, so dropping from the code. Signed-off-by: Daniel P. Smith --- xen/common/gzip/inflate.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/xen/common/gzip/inflate.c b/xen/common/gzip/inflate.c index c18ce20210b0..15bc187c2bbe 100644 ---

[PATCH v2 5/6] gzip: move crc state into consilidated gzip state

Signed-off-by: Daniel P. Smith --- xen/common/gzip/gunzip.c | 11 +++ xen/common/gzip/inflate.c | 12 +--- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/xen/common/gzip/gunzip.c b/xen/common/gzip/gunzip.c index 8178a05a0190..bef324d3d166 100644 ---

Re: [XEN PATCH v1 00/15] x86: make cpu virtualization support configurable

On 16.04.2024 08:18, Sergiy Kibrik wrote: > This series aims to continue what Xenia started a year ago: > > https://lore.kernel.org/xen-devel/20230213145751.1047236-1-burzalod...@gmail.com/ > > Here's an attempt to provide a means to render the cpu virtualization > technology support in Xen

[XEN PATCH] automation/eclair_analysis: substitute deprecated service

The service STD.emptrecd is in the process of being removed in favour of STD.anonstct. No functional change. Signed-off-by: Nicola Vetrini --- automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service

Hi Nicola, On 17/04/2024 15:51, Nicola Vetrini wrote: The service STD.emptrecd is in the process of being removed in favour of STD.anonstct. I am guessing this is not a new feature and the current ECLAIR version is supporting it? Cheers, No functional change. Signed-off-by: Nicola

Re: [PATCH v2 1/2] x86: Add support for building a multiboot2 PE binary

On 17.04.2024 17:05, Ross Lagerwall wrote: > On Wed, Apr 17, 2024 at 3:15 PM Jan Beulich wrote: >> >> On 10.04.2024 11:41, Ross Lagerwall wrote: >>> On Mon, Apr 8, 2024 at 11:25 AM Jan Beulich wrote: On 28.03.2024 16:11, Ross Lagerwall wrote: > * The image base address is set to 0 since

Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service

On 17/04/2024 16:05, Nicola Vetrini wrote: On 2024-04-17 16:57, Julien Grall wrote: Hi Nicola, On 17/04/2024 15:51, Nicola Vetrini wrote: The service STD.emptrecd is in the process of being removed in favour of STD.anonstct. I am guessing this is not a new feature and the current ECLAIR

Re: [PATCH v3 9/9] xen/ppc: mm-radix: Allocate all paging structures at runtime

On 12.04.2024 05:19, Shawn Anastasio wrote: > On 3/25/24 10:39 AM, Jan Beulich wrote: >> On 14.03.2024 23:15, Shawn Anastasio wrote: >>> -static __init struct lvl2_pd *lvl2_pd_pool_alloc(void) >>> -{ >>> -if ( initial_lvl2_lvl3_pd_pool_used >= INITIAL_LVL2_LVL3_PD_COUNT ) >>> -{ >>> -

Re: [PATCH v2 1/2] x86: Add support for building a multiboot2 PE binary

On 10.04.2024 11:41, Ross Lagerwall wrote: > On Mon, Apr 8, 2024 at 11:25 AM Jan Beulich wrote: >> On 28.03.2024 16:11, Ross Lagerwall wrote: >>> * The image base address is set to 0 since it must necessarily be below >>> 4 GiB and the loader will relocate it anyway. >> >> While technically

Re: [PATCH v3 2/2] drivers/char: mark extra reserved device memory in memory map

On Wed, Apr 17, 2024 at 04:17:48PM +0200, Jan Beulich wrote: > On 14.04.2024 02:32, Marek Marczykowski-Górecki wrote: > > On Wed, Apr 03, 2024 at 09:10:40AM +0200, Jan Beulich wrote: > >> On 27.03.2024 03:53, Marek Marczykowski-Górecki wrote: > >>> The IOMMU driver checks if RMRR/IVMD are marked

Re: [PATCH v2 6/6] gzip: drop huffman code table tracking

On 17/04/2024 3:37 pm, Daniel P. Smith wrote: > The "tracking" bits does not appear to be used, so dropping from the code. > > Signed-off-by: Daniel P. Smith > --- > xen/common/gzip/inflate.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/xen/common/gzip/inflate.c

Re: [PATCH v2 3/6] gzip: remove custom memory allocator

On 17/04/2024 3:37 pm, Daniel P. Smith wrote: > All the other decompression routines use xmalloc_bytes(), thus there is no > reason for gzip to be handling its own allocation of memory. In fact, there is > a bug somewhere in the allocator as decompression started to break when adding > additional

Re: [PATCH v3 6/9] xen/common: Move Arm's bootfdt.c to common

Hi Shawn, On 12/04/2024 03:53, Shawn Anastasio wrote: Hi Julien, On 3/21/24 12:50 PM, Julien Grall wrote: Hi Shawn, On 14/03/2024 22:15, Shawn Anastasio wrote: Move Arm's bootfdt.c to xen/common so that it can be used by other device tree architectures like PPC and RISCV. Suggested-by:

Re: [PATCH v2 4/6] gzip: refactor state tracking

On 17/04/2024 3:37 pm, Daniel P. Smith wrote: > diff --git a/xen/common/gzip/gunzip.c b/xen/common/gzip/gunzip.c > index 1b448d6e3655..8178a05a0190 100644 > --- a/xen/common/gzip/gunzip.c > +++ b/xen/common/gzip/gunzip.c > @@ -4,18 +4,25 @@ > #include > #include > > -static unsigned char

[XEN PATCH v3 2/2] eclair_analysis: deviate x86 emulator for Rule 16.2

MISRA C Rule 16.2 states: "A switch label shall only be used when the most closely-enclosing compound statement is the body of a switch statement". Since complying with this rule of the x86 emulator would lead to a lot of code duplication, it is deemed better to exempt those files for this

[XEN PATCH v3 1/2] xen/domctl: address violations of MISRA C Rule 16.2

Refactor the first clauses so that a violation of MISRA C Rule 16.2 is resolved (a switch label should be immediately enclosed in the compound statement of the switch). Note that the switch clause ending with the pseudo keyword "fallthrough" is an allowed exception to Rule 16.3. Convert

[XEN PATCH v3 0/2] address violations of MISRA C Rule 16.2

A respin of the last two patches from the previous series. No changes other than the different SAF comment id because SAF-4-safe was already taken. Nicola Vetrini (2): xen/domctl: address violations of MISRA C Rule 16.2 eclair_analysis: deviate x86 emulator for Rule 16.2

Re: [PATCH v2 5/6] gzip: move crc state into consilidated gzip state

On 17/04/2024 3:37 pm, Daniel P. Smith wrote: > Signed-off-by: Daniel P. Smith The change in type is fine, but does need discussing.  Furthermore, ... > diff --git a/xen/common/gzip/gunzip.c b/xen/common/gzip/gunzip.c > index 8178a05a0190..bef324d3d166 100644 > --- a/xen/common/gzip/gunzip.c >

Re: [PATCH] public: xen: Define missing guest handle for int32_t

On Wed, 17 Apr 2024, Julien Grall wrote: > Hi Michal, > > On 17/04/2024 13:14, Michal Orzel wrote: > > Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t > > in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined > > for it. This results in a build failure.

Re: docs/misra: add R21.6 R21.14 R21.15 R21.16

On Wed, 17 Apr 2024, Julien Grall wrote: > Hi Stefano, > > On 16/04/2024 20:27, Stefano Stabellini wrote: > > Also add two specific project-wide deviations for R21.6 and R21.15. > > In general, I am fine with add the two rules. However... > > > > > Signed-off-by: Stefano Stabellini > > > >

[xen-4.15-testing test] 185709: tolerable FAIL - PUSHED

flight 185709 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185709/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185282

Re: [PATCH 3/3] arm: platform: qcom: add basic support SA8155P SoC

Hi Volodymyr, On 29/03/2024 00:08, Volodymyr Babchuk wrote: Qualcomm SA8155P is the automotive variant of SM8150 aka Snapdragon 855. This patch adds very basic support for the platform. We need to handle Qualcomm-specific SMC to workaround quirk in the QCOM SCM driver in the Linux kernel.

[ovmf test] 185725: all pass - PUSHED

flight 185725 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185725/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6ced1e91eff13dae1bfba95734e2b34a73601db2 baseline version: ovmf

Re: docs/misra: add R21.6 R21.14 R21.15 R21.16

+Bugseng On Wed, 17 Apr 2024, Julien Grall wrote: > Hi Stefano, > > On 17/04/2024 20:10, Stefano Stabellini wrote: > > On Wed, 17 Apr 2024, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 16/04/2024 20:27, Stefano Stabellini wrote: > > > > Also add two specific project-wide deviations for

Re: [PATCH 1/3] arm: smmu: allow SMMU to have more IRQs than context banks

Hi, On 02/04/2024 08:28, Michal Orzel wrote: Hello, On 29/03/2024 01:08, Volodymyr Babchuk wrote: I encountered platform, namely Qualcomm SA8155P where SMMU-compatible NIT: a commit msg should be written in imperative mood IO-MMU advertises more context IQRs than there are context banks.

Re: [PATCH 2/3] drivers: serial: add Qualcomm GENI-based serial driver

Hi, On 29/03/2024 00:08, Volodymyr Babchuk wrote: Generic Interface (GENI) is a newer interface for low speed interfaces like UART, I2C or SPI. This patch adds the simple driver for the UART instance of GENI. Code is based on similar drivers in U-Boot and Linux kernel. If this is based on

[ovmf test] 185726: all pass - PUSHED

flight 185726 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185726/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0afb8743493853e30171f6000de51242e22a1eb8 baseline version: ovmf

[xen-4.16-testing test] 185710: tolerable FAIL - PUSHED

flight 185710 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185710/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185283

Re: docs/misra: add R21.6 R21.14 R21.15 R21.16

Hi Stefano, On 17/04/2024 20:10, Stefano Stabellini wrote: On Wed, 17 Apr 2024, Julien Grall wrote: Hi Stefano, On 16/04/2024 20:27, Stefano Stabellini wrote: Also add two specific project-wide deviations for R21.6 and R21.15. In general, I am fine with add the two rules. However...

Re: [PATCH 2/3] drivers: serial: add Qualcomm GENI-based serial driver

Hi, On 02/04/2024 22:19, Volodymyr Babchuk wrote: Hi Michal, Michal Orzel writes: Hello, On 29/03/2024 01:08, Volodymyr Babchuk wrote: Generic Interface (GENI) is a newer interface for low speed interfaces like UART, I2C or SPI. This patch adds the simple driver for the UART instance

[xen-4.17-testing test] 185711: tolerable FAIL - PUSHED

flight 185711 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185711/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185284