[PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-13 Thread Maarten Maathuis
- When the driver handles the prepare access no copying is needed. - Delayed pixmap creation should be fine, because it's handled by the first prepare access, but the exaPixmapIsOffscreen check in finish access will return FALSE without a driver pixmap. Signed-off-by: Maarten Maathuis

Re: [PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-13 Thread Michel Dänzer
On Fri, 2009-11-13 at 21:52 +0100, Maarten Maathuis wrote: 2009/11/12 Michel Dänzer mic...@daenzer.net: On Mon, 2009-11-09 at 19:52 +0100, Maarten Maathuis wrote: On Mon, Nov 9, 2009 at 12:14 AM, Maarten Maathuis madman2...@gmail.com wrote: This is just an observation, but I do find

Re: [PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-12 Thread Michel Dänzer
On Mon, 2009-11-09 at 19:52 +0100, Maarten Maathuis wrote: On Mon, Nov 9, 2009 at 12:14 AM, Maarten Maathuis madman2...@gmail.com wrote: This is just an observation, but I do find the fact we have two things exaPixmapIsOffscreen(pPixmap) and !pExaPixmap-offscreen Like I know they

Re: [PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-12 Thread Michel Dänzer
On Sat, 2009-11-07 at 13:32 +0100, Maarten Maathuis wrote: - When the driver handles the prepare access no copying is needed. - Delayed pixmap creation should be fine, because it's handled by the first prepare access, but the exaPixmapIsOffscreen check in finish access will return FALSE

Re: [PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-11 Thread Maarten Maathuis
exaPixmapIsOffscreen() is related to having a driver/vram/whatever pixmap pExaPixmap-offscreen says if the offscreen pixmap is the current choice of rendering to The naming came from classic exa. Some better names might be: exaPixmapHasOffscreen() and

Re: [PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-09 Thread Maarten Maathuis
On Mon, Nov 9, 2009 at 12:14 AM, Maarten Maathuis madman2...@gmail.com wrote: This is just an observation, but I do find the fact we have two things exaPixmapIsOffscreen(pPixmap) and !pExaPixmap-offscreen Like I know they are different but really seriously can anyone know the difference

Re: [PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-08 Thread Dave Airlie
On Sat, 2009-11-07 at 13:32 +0100, Maarten Maathuis wrote: - When the driver handles the prepare access no copying is needed. - Delayed pixmap creation should be fine, because it's handled by the first prepare access, but the exaPixmapIsOffscreen check in finish access will return FALSE

[PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-07 Thread Maarten Maathuis
- When the driver handles the prepare access no copying is needed. - Delayed pixmap creation should be fine, because it's handled by the first prepare access, but the exaPixmapIsOffscreen check in finish access will return FALSE without a driver pixmap. Signed-off-by: Maarten Maathuis

Re: [PATCH 1/3] exa/mixed: avoid copying back pixmap data when no migration took place

2009-11-07 Thread Maarten Maathuis
On Sat, Nov 7, 2009 at 1:32 PM, Maarten Maathuis madman2...@gmail.com wrote: - When the driver handles the prepare access no copying is needed. - Delayed pixmap creation should be fine, because it's handled by the  first prepare access, but the exaPixmapIsOffscreen check in finish access  will