Re: [Yade-dev] Shop::aabbExtrema() : from boost::python::tuple return type to std::vector ?

2018-08-13 Thread Jerome Duriez
See this commit. Regarding your suggestions, Bruno : " - dereferencing body pointer without checking it" should be corrected now [*] "- dynamic cast" Are you referring to the Shape cast [**] ? If yes, I understand

Re: [Yade-dev] Shop::aabbExtrema() : from boost::python::tuple return type to std::vector ?

2018-08-08 Thread Bruno Chareyre
Hi Jérôme, This change would be sensible, seems to me (especially regarding your second bullet point). Note that pair would make more sense than a vector<>. I would point out that the implementation of this function looks sloppy in various other ways: - dereferencing body pointer without checking

[Yade-dev] Shop::aabbExtrema() : from boost::python::tuple return type to std::vector ?

2018-08-01 Thread Jerome Duriez
Hi again, I would like changing in pkg/dem/Shop*pp the py::tuple aabbExtrema() [*] to std::vectoraabbExtrema() (keeping obviously the Python exposure). I think this would - make the Shop C++ files one (small) step closer from the ideal situation discussed at