[james-project] 10/21: [Refactoring] Improve Expunge command parser readability

[rcordier]

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit ad63013927640474f2e0032f7fba66d57ee8c1cd
Author: Benoit Tellier <btell...@linagora.com>
AuthorDate: Fri Dec 13 07:41:03 2019 +0100

    [Refactoring] Improve Expunge command parser readability
---
 .../apache/james/imap/decode/parser/ExpungeCommandParser.java | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git 
a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ExpungeCommandParser.java
 
b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ExpungeCommandParser.java
index 04040f7..5216975 100644
--- 
a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ExpungeCommandParser.java
+++ 
b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/ExpungeCommandParser.java
@@ -39,13 +39,16 @@ public class ExpungeCommandParser extends 
AbstractUidCommandParser {
 
     @Override
     protected ImapMessage decode(ImapRequestLineReader request, Tag tag, 
boolean useUids, ImapSession session) throws DecodingException {
-        IdRange[] uidSet = null;
-        if (useUids) {
-            uidSet = request.parseIdRange(session);
-        }
+        IdRange[] uidSet = parseIdRange(request, useUids, session);
         request.eol();
 
         return new ExpungeRequest(tag, uidSet);
     }
 
+    private IdRange[] parseIdRange(ImapRequestLineReader request, boolean 
useUids, ImapSession session) throws DecodingException {
+        if (useUids) {
+            return request.parseIdRange(session);
+        }
+        return null;
+    }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org