On 4/18/24 9:38 AM, Severin Gehwolf wrote:
On Thu, 18 Apr 2024 13:27:38 GMT, Jan Kratochvil <jkratoch...@openjdk.org>
wrote:
Could not we rename `is_containerized()` to `use_container_limit()` ? As that
is the current only purpose of `is_containerized()`.
I'm not sure. There is value to have `is_containerized()` like it would behave after this
patch. Specifically the first table row difference in [your
comment](https://github.com/openjdk/jdk/pull/18201#issuecomment-2063868908) concerns me.
JVMs running in a container without limit wouldn't be detected as
"containerized". That seems a large share of deployments to miss.
agree 100%
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18201#issuecomment-2064487567
