Review: Needs Fixing
Diff comments: > diff --git a/backend/msm/db/queries.py b/backend/msm/db/queries.py > index 8a3bd32..c8369f9 100644 > --- a/backend/msm/db/queries.py > +++ b/backend/msm/db/queries.py > @@ -30,7 +33,7 @@ from ._tables import ( > > def filters_from_arguments( > table: Table, > - **filter_args: list[str] | None, > + **filter_args: list[Any] | None, Can we keep this more specific than Any, still? > ) -> list[ColumnOperators]: > """Return clauses to join with AND and all entries for a single arg by > OR. > This enables to convert query params such as > diff --git a/backend/msm/schema/_models.py b/backend/msm/schema/_models.py > index 24a732d..6128eec 100644 > --- a/backend/msm/schema/_models.py > +++ b/backend/msm/schema/_models.py > @@ -37,11 +37,7 @@ class CreateSite(BaseModel): > > name: str > city: str | None > -<<<<<<< backend/msm/schema/_models.py > country: str | None = Field(min_length=2, max_length=2) > -======= ups. > - country: str | None > ->>>>>>> backend/msm/schema/_models.py > latitude: str | None > longitude: str | None > note: str | None -- https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/441168 Your team MAAS Committers is subscribed to branch ~ack/maas-site-manager:filters-group. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-sponsors More help : https://help.launchpad.net/ListHelp
