On Thu, Jan 26, 2023 at 03:28:07PM +0000, Visa Hankala wrote:
> On Thu, Jan 26, 2023 at 01:57:56AM +0300, Vitaliy Makkoveev wrote:
> > On Wed, Jan 25, 2023 at 10:43:50PM +0300, Vitaliy Makkoveev wrote:
> > > visa@, mpi@, I'm asking you to review, because you are involved in the
> > > kevent(9) development.
> > > 
> > > Hrvoje, if you want to test this diff, you need to disable pipex(4) with
> > > "net.pipex.enable=0".
> > > 
> > 
> > I missed we already have klist_init_mutex(), so the redundant *_klistops
> > removed from previous diff.
> 
> I have a similar patch lying around, shown below. The main differences:
> 
> * Use the same mutex for both read and write side of the klists.
>   Having dedicated mutexes feels overkill.
> 
> * Use klist_insert() and klist_remove() for shorter code.
> 
> * Share f_modify and f_process functions for read and write filters.
> 

Looks more reasonable, ok by me.

Reply via email to