Hi,
On 07.05.2013 15:08, Simon McVittie wrote:
On 07/05/13 08:55, Reto Zingg wrote:
My understanding is that fakeconnectivity.py should "play" connman on
the temporary session dbus.
This is how it works during "make check". It emulates both ConnMan and
NetworkManager (simultaneously!), in fact. We set
DBUS_SYSTEM_BUS_ADDRESS="$DBUS_SESSION_BUS_ADDRESS" when executing MC,
so that MC thinks the fake session bus is the real system bus.
it seems that tp-m-c started from dbus does not get that! I added some
output to run-mc.sh, but DBUS_SYSTEM_BUS_ADDRESS was empty! Seems dbus
strips some env vars out?
So I added DBUS_SYSTEM_BUS_ADDRESS="$DBUS_SESSION_BUS_ADDRESS" to
run-mc.sh now it works, see patch[1].
And the tests should not depend on any real network being available.
This is how it works during "make check".
I run the tests with the run-test.sh script
Is this using --enable-installed-tests (which you might remember us
yes --enable-installed-tests is set, just the install directory I patch
to an other location.
using for CITA in Maemo)? If so, you will probably have to support it
yourself if you want it. The configuration we test ourselves (i.e. the
one I ran when making the releases) is "make check" and "make
distcheck", running the tests inside the built tree. This is also
somewhat more thorough than the installed tests, because we use a debug
version of MC that can be manipulated by the tests.
It is entirely possible that the installed tests are broken in
situations where ConnMan doesn't think you have connectivity: MC
(correctly!) refuses to go online there. You might need to run the MC
tests with a fake ConnMan that always says "yes, I am online".
it seems with the above mentioned patch it just works now?! Yes we run
it in similar manner as CITA.
My patches on https://bugs.freedesktop.org/show_bug.cgi?id=56635 might
improve matters for the installed tests, if someone reviews them (and
"real-world" testing demonstrates that they actually work).
I noticed that bug this morning. Let's see what it changes :-)
Thanks and best regards
Reto
[1]
https://build.merproject.org/package/view_file?file=nemo-fix-system-dbus-for-tests.patch&package=telepathy-mission-control&project=nemo%3Adevel%3Amw&rev=21dd75c1aa7a06f849485c851fccf911
_______________________________________________
telepathy mailing list
telepathy@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/telepathy
