[ 
https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737318#action_12737318
 ] 

Kevin Clark commented on THRIFT-547:
------------------------------------

Yeah, the goal is that it doesn't, functionally, change anything, but the 
behavior is more consistent with the other transports.

But that's not a blocker for me. I think it's more important to get the patch 
in. I'd +1 it post ruby-debug removal if you feel strongly about it.

> Thrift deserializer hangs when deserializing empty string
> ---------------------------------------------------------
>
>                 Key: THRIFT-547
>                 URL: https://issues.apache.org/jira/browse/THRIFT-547
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>    Affects Versions: 0.1
>         Environment: ruby 1.8.6
>            Reporter: Dayo Esho
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-547.patch
>
>
> Expect this to throw an error on empty strings and any other strings that 
> cannot be deserialized. Here is some code to reproduce:
> require 'thrift'
> class MyClass
>   include ::Thrift::Struct
>   FIELDS = {}
>   def struct_fields; FIELDS; end
>   def validate; end
> end
> deserializer = Thrift::Deserializer.new(Thrift::CompactProtocolFactory.new)
> deserializer.deserialize(MyClass.new, '') ###### hangs 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to