** Description changed:

+ [Impact]
+ 
+  * networkd aborts, whilst failing to update address for a
+ failed/lingering link.
+ 
+ [Test Case]
+ 
+  * Sending invalid or flooding the system with RA requests typically
+ reproduces this bug.
+ 
+ Examples:
+ https://github.com/systemd/systemd/issues/2977
+ https://github.com/systemd/systemd/issues/2228
+ https://github.com/systemd/systemd/issues/3204
+ 
+ 
+ [Regression Potential] 
+ 
+  * This patch is a cherrypick form upstream, which adds additional
+ checks to prevent attempts to configure a link which is not ready yet.
+ This patch is present in v230+ thus the code path should have been well
+ exercised in Ubuntu by now, in later releases.
+ 
+ Otherwise, the code behaviour is not changed. Simply, in case of broken
+ links, address update is not attempted and error is returned.
+ 
+ 
https://github.com/systemd/systemd/commit/7209086d8a0df862d04428877c2d2b9e562034f1
+ 
+ 
+ [Other Info]
+  
+  * Original bug report
+ 
  Hi,
  
  the net of my PC is configured via systemd-networkd + systemd-resolved.
  And last two weeks I faced with the problem when my net is down.
  "journalctl -xe" helped to detect this issue:
  
  окт 19 13:36:22 work-pc systemd-resolved[10417]: Failed to read DNS servers 
for interface enp3s0, ignoring: Argument list too long
  окт 19 13:36:22 work-pc kernel: e1000e: enp2s0 NIC Link is Down
  окт 19 13:36:25 work-pc systemd-networkd[2200]: enp2s0: Gained carrier
  окт 19 13:36:25 work-pc systemd-networkd[2200]: Assertion 'link->state == 
LINK_STATE_SETTING_ROUTES' failed at ../src/network/networkd-link.c:697, 
function link_enter_configured(). Aborting.
  окт 19 13:36:25 work-pc systemd-resolved[10417]: Failed to read DNS servers 
for interface enp3s0, ignoring: Argument list too long
  
- 
- When I type "systemctl restart systemd-networkd", nothing happens, net is 
still down. When I type "systemctl restart systemd-resolved", it's all starting 
to work fine, as usual.
+ When I type "systemctl restart systemd-networkd", nothing happens, net
+ is still down. When I type "systemctl restart systemd-resolved", it's
+ all starting to work fine, as usual.
  
  A little bit of googling gave me this bug in systemd bugtracker: 
https://github.com/systemd/systemd/issues/2228
  and this PR: https://github.com/systemd/systemd/pull/3224
  
  Looks like this issue was fixed in systemd-230. So can you backport this
  patch to systemd package?
  
  I can patch it and test it myself, actually, but it would be really nice
  if there will be no need to.
  
  ProblemType: Bug
  DistroRelease: Ubuntu 16.04
  Package: systemd 229-4ubuntu11
  ProcVersionSignature: Ubuntu 4.4.0-38.57-generic 4.4.19
  Uname: Linux 4.4.0-38-generic x86_64
  ApportVersion: 2.20.1-0ubuntu2.1
  Architecture: amd64
  Date: Wed Oct 19 13:58:42 2016
  InstallationDate: Installed on 2016-09-29 (19 days ago)
  InstallationMedia: Ubuntu 16.04.1 LTS "Xenial Xerus" - Release amd64 
(20160719)
  MachineType: ASUS All Series
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.4.0-38-generic 
root=UUID=1c4d999b-22b7-40c0-b803-7117cc57067a ro quiet splash vt.handoff=7
  SourcePackage: systemd
  SystemdDelta:
-  [EXTENDED]   /lib/systemd/system/rc-local.service → 
/lib/systemd/system/rc-local.service.d/debian.conf
-  [EXTENDED]   /etc/systemd/system/display-manager.service → 
/lib/systemd/system/display-manager.service.d/xdiagnose.conf
-  [EXTENDED]   /lib/systemd/system/systemd-timesyncd.service → 
/lib/systemd/system/systemd-timesyncd.service.d/disable-with-time-daemon.conf
-  
-  3 overridden configuration files found.
+  [EXTENDED]   /lib/systemd/system/rc-local.service → 
/lib/systemd/system/rc-local.service.d/debian.conf
+  [EXTENDED]   /etc/systemd/system/display-manager.service → 
/lib/systemd/system/display-manager.service.d/xdiagnose.conf
+  [EXTENDED]   /lib/systemd/system/systemd-timesyncd.service → 
/lib/systemd/system/systemd-timesyncd.service.d/disable-with-time-daemon.conf
+ 
+  3 overridden configuration files found.
  UpgradeStatus: No upgrade log present (probably fresh install)
  dmi.bios.date: 05/14/2015
  dmi.bios.vendor: American Megatrends Inc.
  dmi.bios.version: 1103
  dmi.board.asset.tag: To be filled by O.E.M.
  dmi.board.name: H81M-K
  dmi.board.vendor: ASUSTeK COMPUTER INC.
  dmi.board.version: Rev X.0x
  dmi.chassis.asset.tag: Asset-1234567890
  dmi.chassis.type: 3
  dmi.chassis.vendor: Chassis Manufacture
  dmi.chassis.version: Chassis Version
  dmi.modalias: 
dmi:bvnAmericanMegatrendsInc.:bvr1103:bd05/14/2015:svnASUS:pnAllSeries:pvrSystemVersion:rvnASUSTeKCOMPUTERINC.:rnH81M-K:rvrRevX.0x:cvnChassisManufacture:ct3:cvrChassisVersion:
  dmi.product.name: All Series
  dmi.product.version: System Version
  dmi.sys.vendor: ASUS

** Changed in: systemd (Ubuntu Xenial)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1634855

Title:
  Assertion 'link->state == LINK_STATE_SETTING_ROUTES' failed at
  ../src/network/networkd-link.c:697, function link_enter_configured().
  Aborting.

Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Xenial:
  In Progress

Bug description:
  [Impact]

   * networkd aborts, whilst failing to update address for a
  failed/lingering link.

  [Test Case]

   * Sending invalid or flooding the system with RA requests typically
  reproduces this bug.

  Examples:
  https://github.com/systemd/systemd/issues/2977
  https://github.com/systemd/systemd/issues/2228
  https://github.com/systemd/systemd/issues/3204

  
  [Regression Potential] 

   * This patch is a cherrypick form upstream, which adds additional
  checks to prevent attempts to configure a link which is not ready yet.
  This patch is present in v230+ thus the code path should have been
  well exercised in Ubuntu by now, in later releases.

  Otherwise, the code behaviour is not changed. Simply, in case of
  broken links, address update is not attempted and error is returned.

  
https://github.com/systemd/systemd/commit/7209086d8a0df862d04428877c2d2b9e562034f1

  
  [Other Info]
   
   * Original bug report

  Hi,

  the net of my PC is configured via systemd-networkd + systemd-
  resolved. And last two weeks I faced with the problem when my net is
  down. "journalctl -xe" helped to detect this issue:

  окт 19 13:36:22 work-pc systemd-resolved[10417]: Failed to read DNS servers 
for interface enp3s0, ignoring: Argument list too long
  окт 19 13:36:22 work-pc kernel: e1000e: enp2s0 NIC Link is Down
  окт 19 13:36:25 work-pc systemd-networkd[2200]: enp2s0: Gained carrier
  окт 19 13:36:25 work-pc systemd-networkd[2200]: Assertion 'link->state == 
LINK_STATE_SETTING_ROUTES' failed at ../src/network/networkd-link.c:697, 
function link_enter_configured(). Aborting.
  окт 19 13:36:25 work-pc systemd-resolved[10417]: Failed to read DNS servers 
for interface enp3s0, ignoring: Argument list too long

  When I type "systemctl restart systemd-networkd", nothing happens, net
  is still down. When I type "systemctl restart systemd-resolved", it's
  all starting to work fine, as usual.

  A little bit of googling gave me this bug in systemd bugtracker: 
https://github.com/systemd/systemd/issues/2228
  and this PR: https://github.com/systemd/systemd/pull/3224

  Looks like this issue was fixed in systemd-230. So can you backport
  this patch to systemd package?

  I can patch it and test it myself, actually, but it would be really
  nice if there will be no need to.

  ProblemType: Bug
  DistroRelease: Ubuntu 16.04
  Package: systemd 229-4ubuntu11
  ProcVersionSignature: Ubuntu 4.4.0-38.57-generic 4.4.19
  Uname: Linux 4.4.0-38-generic x86_64
  ApportVersion: 2.20.1-0ubuntu2.1
  Architecture: amd64
  Date: Wed Oct 19 13:58:42 2016
  InstallationDate: Installed on 2016-09-29 (19 days ago)
  InstallationMedia: Ubuntu 16.04.1 LTS "Xenial Xerus" - Release amd64 
(20160719)
  MachineType: ASUS All Series
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.4.0-38-generic 
root=UUID=1c4d999b-22b7-40c0-b803-7117cc57067a ro quiet splash vt.handoff=7
  SourcePackage: systemd
  SystemdDelta:
   [EXTENDED]   /lib/systemd/system/rc-local.service → 
/lib/systemd/system/rc-local.service.d/debian.conf
   [EXTENDED]   /etc/systemd/system/display-manager.service → 
/lib/systemd/system/display-manager.service.d/xdiagnose.conf
   [EXTENDED]   /lib/systemd/system/systemd-timesyncd.service → 
/lib/systemd/system/systemd-timesyncd.service.d/disable-with-time-daemon.conf

   3 overridden configuration files found.
  UpgradeStatus: No upgrade log present (probably fresh install)
  dmi.bios.date: 05/14/2015
  dmi.bios.vendor: American Megatrends Inc.
  dmi.bios.version: 1103
  dmi.board.asset.tag: To be filled by O.E.M.
  dmi.board.name: H81M-K
  dmi.board.vendor: ASUSTeK COMPUTER INC.
  dmi.board.version: Rev X.0x
  dmi.chassis.asset.tag: Asset-1234567890
  dmi.chassis.type: 3
  dmi.chassis.vendor: Chassis Manufacture
  dmi.chassis.version: Chassis Version
  dmi.modalias: 
dmi:bvnAmericanMegatrendsInc.:bvr1103:bd05/14/2015:svnASUS:pnAllSeries:pvrSystemVersion:rvnASUSTeKCOMPUTERINC.:rnH81M-K:rvrRevX.0x:cvnChassisManufacture:ct3:cvrChassisVersion:
  dmi.product.name: All Series
  dmi.product.version: System Version
  dmi.sys.vendor: ASUS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1634855/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to