> For this SRU, I'd therefore expect to see being added only the hashes
involved in the specific issue being fixed - presumably only one -
rather than 117. Usually the above never comes up, but I think it's
relevant when there are 117, rather than the one or two entries that are
common.

> Similarly, for Hirsute, I'd have expected only the hashes since Focal
and onwards to be included.

Agreed Robie, I think this project needs that release-specific set of
md5sums to add. Lucas will limit this SRU to just the needed md5sum for
trusty -> xenial to avoid prompting.

Ultimately I'd like to track an upstream bug for the md5sum filtering
per release because there are 5 different versions of 50unattended-
upgrades for Debian/Raspbian/SteamOS/Devuan and the tooling to generate
these md5sum files should be distribution and release aware. This is
risk that we don't want to inadvertently add to this SRU.

So, let's track that upstream feature as LP:# 1917677

I think you are right that a subset of md5sums should be

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unattended-upgrades in
Ubuntu.
https://bugs.launchpad.net/bugs/1915547

Title:
  Users are prompted by ucf on upgrade from Trusty to Xenial

Status in unattended-upgrades package in Ubuntu:
  Fix Released
Status in unattended-upgrades source package in Xenial:
  Triaged

Bug description:
  [Impact]
  During an upgrade from trusty to xenial, users will be prompted to make a 
decision regarding the diff on unattended-upgrades. This is not a good user 
experience, specially because the user can make an uninformed decision of 
keeping the old config file, which will make unattended-upgrades to not work as 
we expect.

  [Test case]

  To reproduce the issue, you can:

  1. Launch a trusty vm
  2. Perform a do-release-upgrade and observe that you will be prompted with 
the 50unattended-upgrades change

  To verify that the error is fixed:

  1. Launch a trusty vm
  2. Import this ppa into the system:
     https://launchpad.net/~lamoura/+archive/ubuntu/unattended-upgrades-ppa
  3. Configure do-release-upgrade to allow using third parties during upgrade
  4. Run a do-release-upgrade
  5. Verify the prompt is no longer there and that we end up with the 
     expected 50unattended-upgrades config file

  [Where problems could occur]

  The changes in this package should only surface during an upgrade
  operation.  With this change, we are now delivering a new file to the
  system and configuring postinst to use it. Because of that, we believe
  this is the only scenario that could be affected in case of a
  regression is discovered in the package.

  
  [Discussion]
  When upgrading from trusty to xenial, we are prompted about config changes on 
50unattended-upgrades with the following diff:

  --- /etc/apt/apt.conf.d/50unattended-upgrades root.root 0644 2017-05-08 
19:21:39
  +++ /etc/apt/apt.conf.d/50unattended-upgrades.ucftmp root.root 0644 
2020-02-17 18:03:38
  @@ -1,11 +1,13 @@
   // Automatically upgrade packages from these (origin:archive) pairs
   Unattended-Upgrade::Allowed-Origins {
  + "${distro_id}:${distro_codename}";
   "${distro_id}:${distro_codename}-security";
   // Extended Security Maintenance; doesn't necessarily exist for
   // every release and this system may not have it installed, but if
   // available, the policy for updates is such that unattended-upgrades
   // should also install from here by default.
  - "${distro_id}ESM:${distro_codename}";
  + "${distro_id}ESMApps:${distro_codename}-apps-security";
  + "${distro_id}ESM:${distro_codename}-infra-security";
   // "${distro_id}:${distro_codename}-updates";
   // "${distro_id}:${distro_codename}-proposed";
   // "${distro_id}:${distro_codename}-backports";

  The reason we are presented with this diff is that the xenial package
  does not contain a md5sum history file that informs ucf about all the
  supported configs for 50unattended-upgrades. To fix that upgrade
  problem, we are prosing the following changes on the xenial package of
  unattended-upgrades:

      - Add 50unattended-upgrades.md5sum file into the xenial package
      - Add md5sum of the current xenial 50unattende-upgrades file into the 
md5sum history file
      - Modify ucf command in postinst to be aware of the md5sum history file

  See the changelog entry below for a full list of changes and bugs.

  We have performed a manual test with a modified version of the xenial package:
  https://launchpad.net/~lamoura/+archive/ubuntu/unattended-upgrades-ppa

  Using that package, we were able to verify that the config change
  prompt no longer happens from trusty to xenial.

  Since we are modifying are features on unattended-upgrades, just
  adding a new file to package, we don't believe there is any regression
  potential

  
  == Changelog ==

    * data: add md5sum history file on the data folder
      - This file contains md5sum of several supported 50unattended-upgrades
        config files
    * data: add xenial md5sum of 50unattented-upgrades into md5sum file
    * debian/postint: make ucf command reference the md5sum history file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1915547/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to