Leon, I'm not hugely bothered because I don't use this class myself, but weren't you additionally going to check that the primary key was an integer before setting idMethod="idbroker"? Because idbroker ain't going to work with String/Date/etc primary keys. Sean On Fri, Feb 23, 2001 at 03:54:37AM -0800, Java Apache CVS Development wrote: > User: leonm > Date: 01/02/23 03:54:37 > > Modified: src/java/org/apache/turbine/torque/transform > SQLToAppData.java > Log: > I added better IDMethod for SQL to AppData. > > Revision Changes Path > 1.5 +13 -2 >turbine/src/java/org/apache/turbine/torque/transform/SQLToAppData.java > > Index: SQLToAppData.java > =================================================================== > RCS file: >/products/cvs/turbine/turbine/src/java/org/apache/turbine/torque/transform/SQLToAppData.java,v > retrieving revision 1.4 > retrieving revision 1.5 > diff -u -r1.4 -r1.5 > --- SQLToAppData.java 2001/02/17 22:39:00 1.4 > +++ SQLToAppData.java 2001/02/23 11:54:36 1.5 > @@ -71,7 +71,7 @@ > * > * @author <a href="mailto:[EMAIL PROTECTED]">Leon Messerschmidt</a> > * @author <a href="mailto:[EMAIL PROTECTED]">Jon S. Stevens</a> > - * @version $Id: SQLToAppData.java,v 1.4 2001/02/17 22:39:00 mcnally Exp $ > + * @version $Id: SQLToAppData.java,v 1.5 2001/02/23 11:54:36 leonm Exp $ > */ > public class SQLToAppData > { > @@ -174,11 +174,22 @@ > next(); > > Table tbl = new Table (tableName); > - tbl.setIdMethod("none"); > + //tbl.setIdMethod("none"); > while (!token.getStr().equals(";")) > { > Create_Table_Column(tbl); > } > + > + if (tbl.getPrimaryKeys().size() == 1) > + { > + tbl.setIdMethod("idbroker"); > + } > + else > + { > + tbl.setIdMethod("none"); > + } > + > + > appDataDB.addTable (tbl); > } > > > > -- Sean Legassick [EMAIL PROTECTED] As a person, nothing human can be alien to me ------------------------------------------------------------ To subscribe: [EMAIL PROTECTED] To unsubscribe: [EMAIL PROTECTED] Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/> Problems?: [EMAIL PROTECTED]