On Thu, 5 Feb 2009, Anatolij Gustschin wrote:
> Hi Guennadi,
>
> Guennadi Liakhovetski wrote:
>
> > diff --git a/drivers/gpio/mx31_gpio.c b/drivers/gpio/mx31_gpio.c
> > new file mode 100644
> > index 0000000..6487e63
> > --- /dev/null
> > +++ b/drivers/gpio/mx31_gpio.c
> <snip>
> > +#include <common.h>
> > +#include <asm/arch/mx31.h>
> > +#include <asm/arch/mx31-regs.h>
> > +
> > +/* GPIO port description */
> > +static unsigned long gpio_ports[] = {
> > + [0] = 0x53fcc000,
> > + [1] = 0x53fd0000,
> > + [2] = 0x53fa4000,
> > +};
>
> Ilya send a patch for mx31 GPIO register definitions today
> http://lists.denx.de/pipermail/u-boot/2009-February/046884.html
>
> Could you please provide additional patch for drivers/gpio/mx31_gpio.c
> based on Ilya's patch to use these GPIOx_BASE macros here and to
> use GPIO_DR / GPIO_GDIR for 0 / 4 below? Thanks!
Do you mean an incremental patch or a v3?
> > diff --git a/include/asm-arm/arch-mx31/mx31.h
> > b/include/asm-arm/arch-mx31/mx31.h
> > index 0552c27..e957d72 100644
> > --- a/include/asm-arm/arch-mx31/mx31.h
> > +++ b/include/asm-arm/arch-mx31/mx31.h
> > @@ -27,4 +27,24 @@
> > extern u32 mx31_get_ipg_clk(void);
> > extern void mx31_gpio_mux(unsigned long mode);
> >
> > +enum mx31_gpio_direction {
> > + MX31_GPIO_DIRECTION_IN,
> > + MX31_GPIO_DIRECTION_OUT,
> > +};
> > +
> > +#ifdef CONFIG_MX31_GPIO
> > +extern int mx31_gpio_direction(unsigned int gpio,
> > + enum mx31_gpio_direction direction);
> ________________________^^^^^^^
> please remove spaces here, Thanks!
No, these are intentional and correct. They align beginning of the second
line with the first character after the opening parenthesis.
> > +extern void mx31_gpio_set(unsigned int gpio, unsigned int value);
> > +#else
> > +static inline int mx31_gpio_direction(unsigned int gpio,
> > + enum mx31_gpio_direction direction)
> ________________________^^^^^^^
> please remove spaces here too, Thanks!
Ok, this one I just copy-pasted from above, so, it broke alignment.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
