Public bug reported: No matter how much we improve the per guest dynamic profiles, there might always be edge cases not covered.
We do have a generic profile which all lbvirt-qemu are using via an include from the base guest template. Each guest profile does: #include <abstractions/libvirt-qemu> <- generic things #include <libvirt/libvirt-d424f51d-4fee-409d-87d0-e613089f3ec4.files> <- generated for the guest We have a local override for special cases that affect libvirt or virt-aa-helper: grep -Hrn include /etc/apparmor.d/* | grep local | grep libvirt /etc/apparmor.d/usr.lib.libvirt.virt-aa-helper:92: #include <local/usr.lib.libvirt.virt-aa-helper> /etc/apparmor.d/usr.sbin.libvirtd:107: #include <local/usr.sbin.libvirtd> Those overrides are for users to modify, and are not messed with by packaging updates and similar. But we miss two things: 1. a local override for ALL GUESTS (that would be included from abstractions/libvirt-qemu) 2. a local override PER GUEST (to only allow something very specific for one guest) that would be included from the guests libvirt/libvirt-<uuid>.files So I propose at: libvirt/libvirt-<uuid>: #include <local/libvirt-<uuid>.files> <- local override for the guest itself And at: abstractions/libvirt-qemu #include <local/libvirt-qemu> <- local override for guest in general I see that people might prefer names, but those might be ambiguous - did you really mean "test" yesterday to be the same as "test" today and similar? So it shall be uuids. So far this is for remembering the idea, need to prep something for upstream to ack on once I get to it. ** Affects: libvirt (Ubuntu) Importance: Low Assignee: ChristianEhrhardt (paelzer) Status: Triaged ** Changed in: libvirt (Ubuntu) Status: New => Triaged ** Changed in: libvirt (Ubuntu) Assignee: (unassigned) => ChristianEhrhardt (paelzer) ** Changed in: libvirt (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745114 Title: Please add guest uuid and guest-generic local include files To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1745114/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs