** Description changed:

- When net_prio is used without setting ifpriomap and BFP cgroup is used,
- memory may be leaked. This was fixed by upstream commit
- 090e28b229af92dc5b40786ca673999d59e73056, but it had to be reverted to
- fix LP #1886668.
+ [Impact]
+ In some container scenarios, there will be a memory leak, leading to OOM.
+ 
+ [Test case]
+ Run the following:
+ 
+ while true ; do mkdir net_prio/a unified/a ; bash -c 'echo $$ >
+ unified/a/cgroup.procs ; echo $$ > net_prio/a/tasks ; ping -c 1
+ localhost > /dev/null' ; rmdir net_prio/a unified/a ; done
+ 
+ Or the attached program cgroup_leak.c, which is faster. A leak would be
+ produced without the fix, while there should be no constant leak with
+ the fix applied.
+ 
+ [Potential regression]
+ This patch has also caused breakage with BPF cgroup in the past, when racing 
with its disabling, when one attachs a process to netprio cgroup. Similar 
breakage could happen.
+ 
+ 
+ ---------------------------------
+ 
+ 
+ When net_prio is used without setting ifpriomap and BFP cgroup is used, 
memory may be leaked. This was fixed by upstream commit 
090e28b229af92dc5b40786ca673999d59e73056, but it had to be reverted to fix LP 
#1886668.
  
  When a real fix for this cgroup BFP crash lands, this patch should be
  reinstated.
  
  Cascardo.

** Attachment added: "Reproducer"
   
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1886859/+attachment/5438034/+files/cgroup_leak.c

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1886859

Title:
  memory is leaked when tasks are moved to net_prio

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1886859/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to