Thanks for having a look at this SRU. The general compile of the socat code works after just having commit 5ebf36038f39 "Under certain circumstances, options of the first address were applied to the second address" applied.
However, the build also triggers a huge amount of tests, and one, test case 385 'TERMIOS_PH_ALL', is related to this modification and starts to fail. (Btw. this is roughly like the case you mentioned that "affected users of 20.04 may rely on the current behaviour".) Hence a fix is needed to make the 'TERMIOS_PH_ALL' test case work again. And I think this is also reasonable for other (non-test) cases. This was meanwhile upstream fixed "as part of" 9de26f1d0528 "minor corrections, not affecting binaries" (not a great commit msg). The commit 9de26f1d0528 covers different aspects, that are not well documented in the commit description. For this case the modification (as part of 9de26f1d0528) in Makefile.in (and obviously in CHANGES). are not needed. And even the hunks in test.sh: @@ -183,7 +183,7 @@ and @@ -13020,7 +13020,7 @@ are not relevant for the 'TERMIOS_PH_ALL' test case. Only the hunks: @@ -13057,8 +13057,10 @@ and @@ -13066,6 +13068,7 @@ (Whereas hunk '@@ -13066,6 +13068,7 @@' is again not absolutely required for a fixed test.) So yes, the patch could be minimized, for example to cover only: @@ -13057,8 +13057,10 @@ and @@ -13066,6 +13068,7 @@ Well, I thought about this, but from other work (esp. in the kernel area) I've learned (and I generally agree with that) that it is better to stick to entire upstream commits/patches (if possible) for the reason of future maintainability. I think this can be helpful if further patches (due to other bugs are needed) and will reduce risk as well, since the patch is like upstream, means tested like this and incl. like this in never versions. However, if you insist of having this patch minimized; I can do that of course. I think it's close to a philosophical question what is best to do in case "users of 20.04 relying on the current behaviour". I personally believe that since the behavior is wrong, that it needs to be corrected. Please notice that the behavior is correct in all releases newer than focal - means if not fixing this now with an upgrade, things will break at least after a dist-upgrade. Working around this in mkvterm might make the situation (imho) not a lot better (or even worse) and would introduce modification at another place (and would be for focal only, and mkvterm code in never releases might diverge). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056485 Title: Behaviour of socat in Ubuntu 20.04 unexpected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-power-systems/+bug/2056485/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
