** Description changed: [ Impact ] When resizing the terminal window, intel_gpu_top may crash if the window becomes small enough. The output when it crashes is: intel_gpu_top: ../tools/intel_gpu_top.c:1202: print_percentage_bar: Assertion `max_len > 0' failed. The fix has been reported and fixed upstream recently : https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/143 The fix has been part of a serie of fixes that improve intel_gpu_top UI behavior for some corner cases : https://patchwork.freedesktop.org/series/124890/ The proposed fix consists of backporting these fixes to affected Ubuntu releases (Jammy, Mantic and Noble) Tvrtko Ursulin (4): - tools/intel_gpu_top: Fix clients header width when no clients - tools/intel_gpu_top: Fix client layout on first sample period - tools/intel_gpu_top: Optimise interactive display a bit - tools/intel_gpu_top: Handle narrow terminals more gracefully + tools/intel_gpu_top: Fix clients header width when no clients + tools/intel_gpu_top: Fix client layout on first sample period + tools/intel_gpu_top: Optimise interactive display a bit + tools/intel_gpu_top: Handle narrow terminals more gracefully + + NOTES: + For Noble, all the 4 patches will be backported + For Mantic, Jammy, only "tools/intel_gpu_top: Handle narrow terminals more gracefully" will be backported because the others are not applicable to Jammy/Mantic (related to refactoring that happened after Mantic release) [ Test Plan ] Run intel_gpu_top inside a console Resize the console with the mouse to it smallest size [ Where problems could occur ] The problem occurs when intel_gpu_top try to draw information on the console [ Other Info ] This fix should not cause regression on any other feature. ---- When resizing the terminal window, intel_gpu_top may crash if the window become small enough. The output when it crashes is: intel_gpu_top: ../tools/intel_gpu_top.c:1202: print_percentage_bar: Assertion `max_len > 0' failed. Abortado I was able to reproduce this crash with tilix and xterm. ProblemType: Bug DistroRelease: Ubuntu 22.04 Package: intel-gpu-tools 1.26-2 ProcVersionSignature: Ubuntu 5.13.0-19.19-generic 5.13.14 Uname: Linux 5.13.0-19-generic x86_64 ApportVersion: 2.20.11-0ubuntu72 Architecture: amd64 CasperMD5CheckResult: unknown CurrentDesktop: XFCE Date: Sun Oct 31 21:06:01 2021 InstallationDate: Installed on 2017-06-13 (1601 days ago) InstallationMedia: Xubuntu 17.04 "Zesty Zapus" - Release amd64 (20170412) SourcePackage: intel-gpu-tools UpgradeStatus: Upgraded to jammy on 2019-12-22 (679 days ago) modified.conffile..etc.cron.daily.apport: [deleted]
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1949314 Title: intel_gpu_top crashes with intel_gpu_top: ../tools/intel_gpu_top.c:1202: print_percentage_bar: Assertion `max_len > 0' failed. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/intel-gpu-tools/+bug/1949314/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
