On 03/06/19 13:39 +0200, Jan Pokorný wrote: > Yes, there are at least two issues in ocf:heartbeat:VirtualDomain: > > 1/ dealing with user input derived value, in an unchecked manner, while > such value can be an empty string or may contain spaces > (for the latter, see also I've raised back then: > https://lists.clusterlabs.org/pipermail/users/2015-May/007629.html > https://lists.clusterlabs.org/pipermail/developers/2015-May/000620.html > ) > > 2/ agent doesn't try to figure out whether is tries to parse > a reasonably familiar file, in this case, it means it can > be grep'ing file spanning up to terabytes of data > > In your case, you mistakenly pointed the agent (via "config" parameter > as highlighted above) not to the expected configuration, but rather to > the disk image itself -- that's not how talk to libvirt -- only such > a guest configuration XML shall point to where the disk image itself > is located instead. See ocf_heartbeat_VirtualDomain(7) or the output > you get when invoking the agent with "meta-data" argument. > > Such configuration issue could be indicated reliably with "validate-all" > passed as an action for configured set of agent parameters would > 1/ and/or 2/ not exist in the agent's implementation. > Please, file issues against VirtualDomain agent to that effect at > https://github.com/ClusterLabs/fence-agents/issues
sorry, apparently resource-agents, hence https://github.com/ClusterLabs/resource-agents/issues (I don't think GitHub allows after-the-fact issue retargeting, sadly) -- Jan (Poki)
pgpnoFDROu6cE.pgp
Description: PGP signature
_______________________________________________ Manage your subscription: https://lists.clusterlabs.org/mailman/listinfo/users ClusterLabs home: https://www.clusterlabs.org/